[CONSENSUS] Find issue with sending metadata request

consensus/debugging.go

@@ -184,7 +184,7 @@ func (m *consensusModule) sendGetMetadataStateSyncMessage(_ *messaging.DebugMess
 	}
 
 	for _, val := range validators {
-		if m.GetNodeAddress() != val.GetAddress() {
+		if m.GetNodeAddress() == val.GetAddress() {
 			continue
 		}
 		valAddress := cryptoPocket.AddressFromString(val.GetAddress())

consensus/doc/CHANGELOG.md

@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.0.0.35] - 2023-02-25
+
+- Fixed bug in `sendGetMetadataStateSyncMessage`
+
 ## [0.0.0.34] - 2023-02-24
 
 - Fixed `TestPacemakerCatchupSameStepDifferentRounds` test

consensus/state_sync/helpers.go

@@ -38,9 +38,9 @@ func getMessageType(msg *typesCons.StateSyncMessage) string {
 	case *typesCons.StateSyncMessage_MetadataRes:
 		return "StateSyncMetadataResponse"
 	case *typesCons.StateSyncMessage_GetBlockReq:
-		return "GetBlockRequest"
+		return "PeerGetBlockRequest"
 	case *typesCons.StateSyncMessage_GetBlockRes:
-		return "GetBlockResponse"
+		return "PeerGetBlockResponse"
 	default:
 		return "Unknown"
 	}

consensus/state_sync_handler.go

@@ -11,6 +11,7 @@ import (
 func (m *consensusModule) HandleStateSyncMessage(stateSyncMessageAny *anypb.Any) error {
 	m.m.Lock()
 	defer m.m.Unlock()
+	m.logger.Info().Msg("Received a state sync message")
 
 	switch stateSyncMessageAny.MessageName() {
 	case StateSyncMessageContentType:
@@ -33,13 +34,15 @@ func (m *consensusModule) HandleStateSyncMessage(stateSyncMessageAny *anypb.Any)
 func (m *consensusModule) handleStateSyncMessage(stateSyncMessage *typesCons.StateSyncMessage) error {
 	switch stateSyncMessage.Message.(type) {
 	case *typesCons.StateSyncMessage_MetadataReq:
+		m.logger.Info().Msg("It is a StateSyncMessage_MetadataReq")
 		if !m.stateSync.IsServerModEnabled() {
 			return fmt.Errorf("server module is not enabled")
 		}
 		return m.stateSync.HandleStateSyncMetadataRequest(stateSyncMessage.GetMetadataReq())
 	case *typesCons.StateSyncMessage_MetadataRes:
 		return m.stateSync.HandleStateSyncMetadataResponse(stateSyncMessage.GetMetadataRes())
 	case *typesCons.StateSyncMessage_GetBlockReq:
+		m.logger.Info().Msg("It is a StateSyncMessage_GetBlockReq")
 		if !m.stateSync.IsServerModEnabled() {
 			return fmt.Errorf("server module is not enabled")
 		}