Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nucleic acid modalities #138

Open
fteufel opened this issue Jul 18, 2024 · 1 comment
Open

Add nucleic acid modalities #138

fteufel opened this issue Jul 18, 2024 · 1 comment
Labels
feature Annotates any PR that adds new features; Used in the release process

Comments

@fteufel
Copy link
Contributor

fteufel commented Jul 18, 2024

Modality right now only supports a very limited number of cases. It would be helpful to have biomolecules beyond proteins, starting with nucleic acids.

Describe the solution you'd like

Add dna and rna to polaris.dataset.Modality.

Would this be sufficient to get the functionality?

@fteufel fteufel added the feature Annotates any PR that adds new features; Used in the release process label Jul 18, 2024
@cwognum
Copy link
Collaborator

cwognum commented Jul 19, 2024

Thanks @fteufel. This shouldn't be all that difficult to add, but since it doesn't affect the functionality of a dataset it's a low priority for now. With the ICML launch around the corner, there are some other, more pressing feature requests and issues to work on first.

For context: No functionality is currently conditioned on the modality field in the ColumnAnnotation. It's just metadata. There are ideas on our roadmap to add modality-specific functionality (e.g. visualizations). I expect that working on such modality-specific features will require us to change the type and structure of the modality field. For example, right now we we have Modality.MOLECULE, but we don't differentiate different molecular representations. Maybe we will also (or instead?) need to annotate that a column has SMILES or SELFIES or molecular graphs!

Of course, if you would really like to have more modalities supported in the meantime, please feel free to make a PR. It may take a while to make the necessary changes on the Hub's side as well, but I promise you we won't forget.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Annotates any PR that adds new features; Used in the release process
Projects
None yet
Development

No branches or pull requests

2 participants