-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: PolarisFileSystem
uses the dataset name instead of the dataset slug, causing a 404
#146
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @zhu0619 ! Just some minor suggestions.
PolarisFileSystem
uses the dataset name instead of the dataset slug, causing a 404
Hey @zhu0619 ! Seems I'm too late, but one more thought came to mind when I saw you push the latest changes: Do we need to sluggify the owner too? I don't think so, because even though we type-hint Maybe we should just drop the |
Changelogs
PolarisFileSystem
.cache_dir
to a string.Checklist:
- [ ] Was this PR discussed in an issue? It is recommended to first discuss a new feature into a GitHub issue before opening a PR.- [ ] Add tests to cover the fixed bug(s) or the newly introduced feature(s) (if appropriate).- [ ] Update the API documentation if a new function is added, or an existing one is deleted.feature
,fix
,chore
,documentation
ortest
(or ask a maintainer to do it for you).When uploading the dataset, the dataset slug has to be used to get the correct path to the R2 bucket. Otherwise, the Hub returns a
404
.