Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add timeout argument #194

Merged
merged 1 commit into from
Sep 6, 2024
Merged

add timeout argument #194

merged 1 commit into from
Sep 6, 2024

Conversation

zhu0619
Copy link
Contributor

@zhu0619 zhu0619 commented Sep 6, 2024

Changelogs

  • Add argument timeout to Dataset.upload_to_hub function, to keep the consistency to client function.

Checklist:

  • Was this PR discussed in an issue? It is recommended to first discuss a new feature into a GitHub issue before opening a PR.
  • Add tests to cover the fixed bug(s) or the newly introduced feature(s) (if appropriate).
  • Update the API documentation if a new function is added, or an existing one is deleted.
  • Write concise and explanatory changelogs above.
  • If possible, assign one of the following labels to the PR: feature, fix, chore, documentation or test (or ask a maintainer to do it for you).

The timeout argument is crucial for the success of large dataset uploading.

@zhu0619 zhu0619 added the fix Annotates any PR that fixes bugs label Sep 6, 2024
Copy link
Collaborator

@cwognum cwognum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zhu0619 zhu0619 merged commit f245e9e into main Sep 6, 2024
4 checks passed
@zhu0619 zhu0619 deleted the fix/upload branch September 7, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Annotates any PR that fixes bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants