This repository has been archived by the owner on Feb 8, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 25
Attempt to delete and reload the same index path #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
let dummy = Task() | ||
value = dummy.primaryKeyValue() | ||
} | ||
it("should be nil") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be 0
👍 |
polqf
force-pushed
the
bug/deleteAndReloadSameIndex
branch
from
February 10, 2016 11:28
eaf6db2
to
2638758
Compare
let dummy2 = Task() | ||
value = dummy1.hasSamePrimaryKeyValue(dummy2) | ||
} | ||
it("should return false") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should return true
🍏 👍 |
polqf
force-pushed
the
bug/deleteAndReloadSameIndex
branch
from
February 10, 2016 14:48
b809bcc
to
15da28f
Compare
polqf
added a commit
that referenced
this pull request
Feb 10, 2016
Attempt to delete and reload the same index path
This was referenced Feb 10, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
As #66 pointed out, there is a case where the RRC is provoking a crash on the
tableView.endUpdates()
This seems that is happening due to a deletion + an insertion of the same object in a background thread.
👻 GIF
Closes #66