Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly implement Interface Method Dispatch from Runtime #31

Open
dz333 opened this issue Aug 24, 2018 · 0 comments
Open

Properly implement Interface Method Dispatch from Runtime #31

dz333 opened this issue Aug 24, 2018 · 0 comments

Comments

@dz333
Copy link
Collaborator

dz333 commented Aug 24, 2018

There is a function in jni_help.h (CallJavaInterfaceMethod) that allows runtime code to call methods which are defined as interface methods (and therefore are not in a class' CDV). The normal functions for calling methods doesn't delegate to this in the case where the method is an interface method.

In order to correctly call methods in general from runtime, we need to 1) check if the method is defined in an interface and then 2) use CallJavaInterfaceMethod to call it.

This isn't terribly important since it is not a common case and currently doesn't prevent our test suites from passing, but should be done at some point to enable any method to be called via runtime code easily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant