app-swift bindings #55
Conversation
|
In order to show the e2e developer experience, can we please create a template project that uses these bindings? Similar to: https://github.com/polywrap/cli/blob/origin-dev/packages/templates/app/typescript/src/index.ts |
| "as" | "break" | "const" | "continue" | "crate" | ||
| | "else" | "enum" | "extern" | "false" | "fn" | ||
| | "for" | "if" | "impl" | "in" | "let" | "loop" | ||
| | "match" | "mod" | "move" | "mut" | "pub" | "ref" | ||
| | "return" | "self" | "Self" | "static" | "struct" | "super" | ||
| | "trait" | "true" | "type" | "unsafe" | "use" | "where" | ||
| | "while" | "async" | "await" | "dyn" | "abstract" | ||
| | "become" | "box" | "Box" | "do" | "final" | "macro" | ||
| | "override" | "priv" | "typeof" | "unsized" | ||
| | "virtual" | "yield" | "try" | "macro_rules" | ||
| | "union" => true, | ||
| _ => false, |
There was a problem hiding this comment.
i think these do not apply to swift right?
There was a problem hiding this comment.
I updated the keywords in the swift plugin and app bindings. Please take a look!
| @@ -0,0 +1 @@ | |||
| #import * from "wrap://ens/wraps.eth:abi-bindgen@0.1" | |||
There was a problem hiding this comment.
For sure. What is it? The other bindings wraps aren't using it yet and I don't know how to get it.
There was a problem hiding this comment.
I think @dOrgJelli was working on this.
There was a problem hiding this comment.
Yah we'll do this in another PR, will do this today
implementations/app-swift/src/__tests__/cases/000-sanity/output/Types.swift
Outdated
Show resolved
Hide resolved
| if (self.client == nil) { | ||
| self.client = BuilderConfig().addSystemDefault().addWeb3Default().build() | ||
| } | ||
| return self.client! |
There was a problem hiding this comment.
We should not use ! because its equivalent to unwrap() of a result in rust; I would to propose doing something like
if let client = self.client {
return client
} else {
let newClient = BuilderConfig()...
self.client = newClient
return newClient
}this is more idiomatic imo
| if (self.uri == nil) { | ||
| self.uri = try? Uri("testimport.uri.eth") | ||
| } | ||
| return self.uri! |
There was a problem hiding this comment.
since we are doing a try? here, handling this without ! would mean to add throws keyword in the definition of the function; hence, changing how the dev exp is... So let's keep it like this for now
noob q: this Uri should never be wrong the CLI would not create these bindings right? 🤔
There was a problem hiding this comment.
Yes, exactly. It is using the same URI used for the import in the polywrap.graphql schema, so if the URI were wrong then the app bindings wouldn't be generated in the first place.
Let me know if there is a better pattern you'd like to see here
There was a problem hiding this comment.
I updated the pattern to match the getDefaultClient pattern. Let me know your thoughts!
|
|
||
| pub fn load_templates() -> Vec<Template> { | ||
| vec!( | ||
| Types_swift::load(), |
There was a problem hiding this comment.
is there any reason for having only the Types template? Would it be possible to also have the Module template so we can have things separately? Like in plugins
There was a problem hiding this comment.
I can separate these bindings into Module.swift and Types.swift.
I was just copying how the others are done. I think separating into more files is a great idea. To me, it would be ideal to have a separate file for each module.
…ariable for import uri
| } | ||
| } | ||
|
|
||
| func getDefaultUri() -> Uri { |
There was a problem hiding this comment.
We also need getDefaultEnv method
There was a problem hiding this comment.
Talked with Niraj, we can do this in another PR and release a new version on wrapscan (CLI will get updated automatically).
There was a problem hiding this comment.
You're right that this is an oversight. I'm fixing this now.
template PR: polywrap/wrap-cli#1870
related: #76