Merge pull request #1291 from polywrap/pileks/make-config-props-read-…

…only Make config props read only
polywrap · Oct 5, 2022 · 6436804 · 6436804
2 parents fe40e5f + 12eea9a
commit 6436804
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 12 deletions.
diff --git a/packages/cli/src/lib/helpers/validate-client-config.ts b/packages/cli/src/lib/helpers/validate-client-config.ts
@@ -12,7 +12,7 @@ import {
 
 export function validateRedirects<
   TUri extends PluginPackage<unknown> | Uri | string
->(redirects: UriRedirect<TUri>[]): void {
+>(redirects: readonly UriRedirect<TUri>[]): void {
   if (!Array.isArray(redirects)) {
     throw new Error(intlMsg.commands_run_error_redirectsExportNotArray());
   }
@@ -44,7 +44,7 @@ export function validateRedirects<
 }
 
 export function validatePlugins<TUri extends Uri | string = string>(
-  plugins: PluginRegistration<TUri>[]
+  plugins: readonly PluginRegistration<TUri>[]
 ): void {
   if (!Array.isArray(plugins)) {
     throw new Error(intlMsg.commands_run_error_pluginsExportNotArray());
@@ -88,7 +88,7 @@ export function validatePlugins<TUri extends Uri | string = string>(
 }
 
 export function validateInterfaces<TUri extends Uri | string = string>(
-  interfaces: InterfaceImplementations<TUri>[]
+  interfaces: readonly InterfaceImplementations<TUri>[]
 ): void {
   if (!Array.isArray(interfaces)) {
     throw new Error(intlMsg.commands_run_error_interfacesExportNotArray());
@@ -138,7 +138,7 @@ export function validateInterfaces<TUri extends Uri | string = string>(
 }
 
 export function validateEnvs<TUri extends Uri | string = string>(
-  envs: Env<TUri>[]
+  envs: readonly Env<TUri>[]
 ): void {
   if (!Array.isArray(envs)) {
     throw new Error(intlMsg.commands_run_error_envsExportNotArray());

diff --git a/packages/js/client/src/PolywrapClient.ts b/packages/js/client/src/PolywrapClient.ts
@@ -45,8 +45,8 @@ import { Result, ResultErr, ResultOk } from "@polywrap/result";
 
 export interface PolywrapClientConfig<TUri extends Uri | string = string>
   extends ClientConfig<TUri> {
-  tracerConfig: Partial<TracerConfig>;
-  wrapperCache?: IWrapperCache;
+  readonly tracerConfig: Readonly<Partial<TracerConfig>>;
+  readonly wrapperCache?: Readonly<IWrapperCache>;
 }
 
 export class PolywrapClient implements Client {
@@ -111,7 +111,10 @@ export class PolywrapClient implements Client {
     } else {
       Tracer.disableTracing();
     }
-    this._config.tracerConfig = tracerConfig ?? {};
+    this._config = {
+      ...this._config,
+      tracerConfig: tracerConfig ?? {},
+    };
   }
 
   @Tracer.traceMethod("PolywrapClient: getRedirects")

diff --git a/packages/js/core/src/types/Client.ts b/packages/js/core/src/types/Client.ts
@@ -16,11 +16,11 @@ import { WrapManifest } from "@polywrap/wrap-manifest-types-js";
 import { Result } from "@polywrap/result";
 
 export interface ClientConfig<TUri extends Uri | string = string> {
-  redirects: UriRedirect<TUri>[];
-  plugins: PluginRegistration<TUri>[];
-  interfaces: InterfaceImplementations<TUri>[];
-  envs: Env<TUri>[];
-  resolver: IUriResolver<unknown>;
+  readonly redirects: Readonly<UriRedirect<TUri>[]>;
+  readonly plugins: Readonly<PluginRegistration<TUri>[]>;
+  readonly interfaces: Readonly<InterfaceImplementations<TUri>[]>;
+  readonly envs: Readonly<Env<TUri>[]>;
+  readonly resolver: Readonly<IUriResolver<unknown>>;
 }
 
 export interface GetManifestOptions {