Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URI Resolver Wrapper Infinite Loop #715

Closed
Tracked by #714
nerfZael opened this issue Mar 3, 2022 · 1 comment · Fixed by #777
Closed
Tracked by #714

URI Resolver Wrapper Infinite Loop #715

nerfZael opened this issue Mar 3, 2022 · 1 comment · Fixed by #777
Assignees
Milestone

Comments

@nerfZael
Copy link
Contributor

nerfZael commented Mar 3, 2022

From my current understanding of the client URI resolution process, there is an infinite loop if using a URI Resolve Wrapper

Lets say you have an "ens-resolver.eth" URI resolver wrapper
Invoking a URI "test.eth" would work like this:

client.invoke("test.eth")
resolveUri
client.getImplementations("uri-resolver") -> returns ["ens-resolver.eth"]
forEach URI resolver wrapper
client.invoke("ens-resolver.eth")
resolveUri
client.getImplementations("uri-resolver") -> returns ["ens-resolver.eth"]
forEach URI resolver wrapper
client.invoke("ens-resolver.eth")
resolveUri
client.getImplementations("uri-resolver") -> returns ["ens-resolver.eth"]

This is still just a theory and needs to be tested. If there is indeed an infinite loop, we can address it as a separate issue.

@nerfZael nerfZael added this to the 1. Alpha - Must have milestone Mar 3, 2022
@evanjacobs evanjacobs removed this from the 1. Alpha - Must have milestone Mar 4, 2022
@nerfZael nerfZael added this to the alpha milestone Mar 15, 2022
@nerfZael nerfZael self-assigned this Mar 15, 2022
@evanjacobs evanjacobs removed this from the alpha milestone Mar 17, 2022
@nerfZael nerfZael modified the milestone: alpha Mar 22, 2022
@nerfZael
Copy link
Contributor Author

More details on possible solution: https://hackmd.io/CJjkN8OzSv-3vEBPzOwQBQ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants