Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename nullable to optional everywhere #937

Closed
fetsorn opened this issue Jun 21, 2022 · 0 comments
Closed

rename nullable to optional everywhere #937

fetsorn opened this issue Jun 21, 2022 · 0 comments

Comments

@fetsorn
Copy link
Contributor

fetsorn commented Jun 21, 2022

Right now msgpack (de)serializers have methods like "read_nullable_array", "write_nullable_array", "applyNullable". But the underlying implementations use option types, not nullable types.

The core difference between option types and nullable types is that option types support nesting (e.g. Maybe (Maybe String) ≠ Maybe String), while nullable types do not (e.g. String?? = String?). -- Wikipedia

Both assemblyscript and rust methods should be renamed to "read_optional_array", "write_optional_array", "applyOptional" etc.
Haven't done it in #936 because its scope did not include rust.

fetsorn added a commit that referenced this issue Jun 24, 2022
dOrgJelli added a commit that referenced this issue Jun 27, 2022
@fetsorn fetsorn closed this as completed Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant