support ipv6 by default #1146
support ipv6 by default #1146
Conversation
sinasab
force-pushed
the
sina/ipv6-support
branch
from
321a4fe
to
9344fe6
Compare
|
Thanks for opening and apologies for the regression. Rather than update our default to override theirs, should we try to upstream this change into https://github.com/honojs/node-server/blob/main/src/server.ts#L24 - server.listen(options?.port ?? 3000, options.hostname ?? '0.0.0.0', () => {
+ server.listen(options?.port ?? 3000, options.hostname, () => {The property that Ponder's |
Nice, I like that idea. I'd assumed that getting the change into ponder would be significantly quicker than upstreaming it, but you inspired me to submit the upstream PR anyway-- it's here: honojs/node-server#206
Yes definitely, when it works 😜 in light of it not working as expected though, I was thinking the tradeoff of not default-supporting ipv4-only platforms would be stomacheable, esp since most users will be running ponder on railway where private networking is recommended but is breaking opaquely out of the box. I'm not sure how quickly the upstream PR will be addressed, but once it's landed I can bump the version to get it into ponder/core as well. In the meantime, feel free to leave this PR open or close it, whatever seems appropriate to you 🫡 |
See context here: ponder-sh#1146 Upstream change to hono/node-server was included @ honojs/node-server#206 This PR bumps the version of hono/node-server to include the upstream change. I also added a test to ensure ipv6 works, which should help avoid future regressions as well!
|
Upstream change got merged! Closing this in favor of #1155 |
See context here: ponder-sh#1146 Upstream change to hono/node-server was included @ honojs/node-server#206 This PR bumps the version of hono/node-server to include the upstream change. I also added a test to ensure ipv6 works, which should help avoid future regressions as well!
* chore: bumping hono/node-server to support ipv6 See context here: #1146 Upstream change to hono/node-server was included @ honojs/node-server#206 This PR bumps the version of hono/node-server to include the upstream change. I also added a test to ensure ipv6 works, which should help avoid future regressions as well! * Update stupid-cooks-wash.md --------- Co-authored-by: typedarray <90073088+0xOlias@users.noreply.github.com>
Since updating the internal server to hono, it seems this behavior has changed; looks like ponder always defaults to using
0.0.0.0as the hostname when unspecified, rather than adaptively choosing between that and::as node did. See here for where this behavior lives.I added a small fix that defaults the
hostnamearg to::when unset, and a test that validates this behavior.As with before, this can easily be worked around via using the --hostname flag (eg.
ponder start --hostname=::)