Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add API to define and run report custom converter #29

Open
1 of 2 tasks
jerome-benoit opened this issue Oct 1, 2024 · 0 comments · Fixed by #32
Open
1 of 2 tasks

[Feature] Add API to define and run report custom converter #29

jerome-benoit opened this issue Oct 1, 2024 · 0 comments · Fixed by #32
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jerome-benoit
Copy link
Contributor

jerome-benoit commented Oct 1, 2024 •
edited
Loading

  • report converter API: a callback as a run() option:
<T>(report: Report) => T
  • report display converter API: display is done incrementally by the following primitives:
  benchmarkError
  benchmarkReport
  br
  groupHeader
  header
  size
  summary
  units
  warning

Exposing an API to override them all will result in a bloated one. The way report is displayed must be simplified first.
@jerome-benoit jerome-benoit added enhancement New feature or request good first issue Good for newcomers labels Oct 1, 2024
@jerome-benoit jerome-benoit mentioned this issue Oct 1, 2024
Closed
jerome-benoit added a commit that referenced this issue Oct 4, 2024
@jerome-benoit
feat!: add custom benchmark reporter support
4c16a3a 
reference #29

Signed-off-by: Jérôme Benoit <jerome.benoit@piment-noir.org>
@jerome-benoit jerome-benoit mentioned this issue Oct 4, 2024
Merged
@jerome-benoit jerome-benoit reopened this Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(master): release 0.8.0 poolifier/tatami-ng
1 participant
@jerome-benoit