From ba2c0460861279636291dc4f1405718e1b49c552 Mon Sep 17 00:00:00 2001 From: pengyin-shan Date: Tue, 21 Feb 2023 11:50:46 -0500 Subject: [PATCH 1/3] add setup-node action to Github workflow to force node using v16 --- .github/workflows/mysql.yml | 3 +++ .github/workflows/postgres.yml | 3 +++ 2 files changed, 6 insertions(+) diff --git a/.github/workflows/mysql.yml b/.github/workflows/mysql.yml index 331a981385..ec194cad36 100644 --- a/.github/workflows/mysql.yml +++ b/.github/workflows/mysql.yml @@ -16,6 +16,9 @@ jobs: - uses: actions/checkout@v3 with: fetch-depth: 1 + - uses: actions/setup-node@v3 + with: + node-version: 16 - name: 'Install MySQL Packages' run: | diff --git a/.github/workflows/postgres.yml b/.github/workflows/postgres.yml index 3d340eefda..1a5d3852f3 100644 --- a/.github/workflows/postgres.yml +++ b/.github/workflows/postgres.yml @@ -32,6 +32,9 @@ jobs: - uses: actions/checkout@v3 with: fetch-depth: 1 + - uses: actions/setup-node@v3 + with: + node-version: 16 - name: 'Install Postgresql Packages' run: | From 928941999bee9fa0a3f6947586211031e3d03c24 Mon Sep 17 00:00:00 2001 From: pengyin-shan Date: Tue, 21 Feb 2023 12:05:19 -0500 Subject: [PATCH 2/3] following main codebase suggestion on PR3292 to exclude lib tasks from debugger rubocop only --- .rubocop.yml | 4 +++- app/models/application_record.rb | 1 - 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.rubocop.yml b/.rubocop.yml index b3d42f1656..66853ae6ff 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -106,7 +106,9 @@ Lint/UnmodifiedReduceAccumulator: # new in 1.1 Enabled: true Lint/Debugger: # new in 1.45.0 Description: 'Check for debugger calls.' - Enabled: false + Enabled: true + Exclude: + - 'lib/tasks/**/*' # ----------- # - METRICS - diff --git a/app/models/application_record.rb b/app/models/application_record.rb index 2b56b0d0b2..833a2e34e3 100644 --- a/app/models/application_record.rb +++ b/app/models/application_record.rb @@ -20,7 +20,6 @@ def postgres_db? # Generates the appropriate where clause for a JSON field based on the DB type def safe_json_where_clause(column:, hash_key:) - p mysql_db? return "(#{column}->>'#{hash_key}' LIKE ?)" if postgres_db? # return "#{column} LIKE ?)" if maria_db? From fe11c0cadcaff2cf45f88b07bfb62f379b043e2d Mon Sep 17 00:00:00 2001 From: pengyin-shan Date: Tue, 21 Feb 2023 12:08:23 -0500 Subject: [PATCH 3/3] update Changelog --- CHANGELOG.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index b50d035d4f..f9b89a5218 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -126,6 +126,9 @@ - Fixed some potential PDF downloading problems +- Updated Github Actions to use specified node version [#319](https://github.com/portagenetwork/roadmap/issues/319) + + ## [3.0.4+portage-3.0.16] - 2022-12-14 ### Changed