Fix User Lookup Via SSO Email: Make Query Case-Insensitive #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is intended to resolve the following issue: #900
- `user.email` is already set as desired within `user = User.find_or_initialize_by(email: email)` - Also, the `.presence` method seems to simplify the assignment of `firstname` and `surname`. https://apidock.com/rails/Object/presence
lagoan
requested changes
Oct 10, 2024
Comment on lines
+195
to
+196
| firstname: provider_data.info&.first_name.presence || _('First name'), | ||
| surname: provider_data.info&.last_name.presence || _('Last name'), |
There was a problem hiding this comment.
I like this way so much better!
This was referenced Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #900
Changes proposed in this PR:
Applied .downcase to the SSO email for case-insensitive user lookup:
User.find_or_initialize_by(email: email)is case-insensitive (whereemailis the email provided by SSO/CILogon).identifierstable (whereprovider.info.emailvalues are stored) shows that some emails contain capital letters, whereas no capitalised emails exist within theuserstable. Without applying.downcase, the code was susceptible to the bug illustrated in the following comment: ActiveRecord::RecordInvalid: Validation failed: Email has already been taken #900 (comment)Some factoring has also been done: ade1189