Fix broken Node#parent

postcss · Oct 16, 2018 · 1ec9169 · 1ec9169
1 parent 57ab747
commit 1ec9169
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/lib/hacks/grid-utils.js b/lib/hacks/grid-utils.js
@@ -623,7 +623,8 @@ function insertAreas (css, isDisabled) {
       .filter(p => p !== 'lastRule')
       .forEach(params => {
         if (data[params].length > 0 && lastRule) {
-          lastRule.after({ name: 'media', nodes: data[params], params })
+          lastRule.after({ name: 'media', params })
+          lastRule.next().append(data[params])
         }
       })
   })

diff --git a/test/autoprefixer.test.js b/test/autoprefixer.test.js
@@ -336,6 +336,20 @@ it('prevents doubling prefixes', () => {
   }
 })
 
+it('does not broke AST', () => {
+  function checkParent (node) {
+    node.walk(child => {
+      expect(child.parent).toBeDefined()
+      if (child.nodes) checkParent(child)
+    })
+  }
+  for (let type of COMMONS) {
+    let processor = postcss([prefixer(type)])
+    let input = read(type)
+    checkParent(processor.process(input).root)
+  }
+})
+
 it('parses difficult files', () => {
   let input = read('syntax')
   let result = postcss([cleaner]).process(input)