Update extension to not use mcrypt directly but rather mcryptcompat (magento core 194x) or openssl

[seansan]

To Reproduce
Steps to reproduce the behavior:

• php 7.2 Openmage LTS

Expected result

• Extension does no direct calls to mcrypt

Actual result

• Mcrypt warnings in log and mcrypt usage => need to remove it from the code asap

Solution

• Update extension to not use mcrypt directly but rather mcryptcompat (magento core 194x) or openssl

OpenMage/magento-lts#129

https://github.com/OpenMage/magento-lts/blob/1.9.4.x/app/Mage.php#L50

Screenshots

[28-Sep-2020 21:34:40 UTC] PHP Deprecated: Function mdecrypt_generic() is deprecated in lib/Varien/Crypt/Mcrypt.php on line 133
[29-Sep-2020 09:35:24 UTC] PHP Deprecated: Function mdecrypt_generic() is deprecated in lib/Varien/Crypt/Mcrypt.php on line 133
[29-Sep-2020 09:35:24 UTC] PHP Deprecated: Function mdecrypt_generic() is deprecated in lib/Varien/Crypt/Mcrypt.php on line 133
[30-Sep-2020 09:33:04 UTC] PHP Deprecated: Function mcrypt_module_open() is deprecated in lib/Varien/Crypt/Mcrypt.php on line 77
[30-Sep-2020 09:33:04 UTC] PHP Deprecated: Function mcrypt_enc_get_iv_size() is deprecated in lib/Varien/Crypt/Mcrypt.php on line 86
[30-Sep-2020 09:33:04 UTC] PHP Deprecated: Function mcrypt_create_iv() is deprecated in lib/Varien/Crypt/Mcrypt.php on line 86
[30-Sep-2020 09:33:04 UTC] PHP Deprecated: Function mcrypt_enc_get_key_size() is deprecated in lib/Varien/Crypt/Mcrypt.php on line 90
[30-Sep-2020 09:33:04 UTC] PHP Deprecated: Function mcrypt_generic_init() is deprecated in lib/Varien/Crypt/Mcrypt.php on line 97

[tig-jaspersmits]

Hello @seansan ,

When answering your other case I stumbled upon this one. As mentioned in the other issue as well, we unfortunately can't implement any feature requests like this any more. I'm sorry to say I would need to close this request as our focus is on the M2 extension since M1 has reached EOL.

Kind regards,
Jasper
TIG