-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First try at creating builders from existing object #1793
base: main
Are you sure you want to change the base?
Conversation
0829a17
to
fdf9975
Compare
…t implementation, not in merging view) Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
fdf9975
to
a68a1e1
Compare
Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
Kudos, SonarCloud Quality Gate passed! |
Nice feature! Maybe we should be more clear about what is copied from the reference element and what is not. So l2 = n.newLine(l1)
.setId("l2")
.setNode1(3)
.setNode(4)
.add(); Would create a l2 which is exactly like l2 (in parallel) but with a different connection point. In case of bus/breaker this is different, it is allowed to have multiple elements connected to same bus so we would only need to specify a new id. l2 = n.newLine(l1)
.setId("l2")
.add(); |
Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com> # Conflicts: # iidm/iidm-api/src/main/java/com/powsybl/iidm/network/VoltageLevel.java # iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/AbstractVoltageLevel.java # iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/NetworkImpl.java # iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/ThreeWindingsTransformerAdderImpl.java # iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/TwoWindingsTransformerAdderImpl.java # iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/VoltageLevelAdderImpl.java # iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/VscConverterStationAdderImpl.java # iidm/iidm-mergingview/src/test/java/com/powsybl/iidm/mergingview/BatteryAdapterTest.java # iidm/iidm-mergingview/src/test/java/com/powsybl/iidm/mergingview/TwoWindingsTransformerAdapterTest.java # iidm/iidm-mergingview/src/test/java/com/powsybl/iidm/mergingview/VscConverterStationAdapterTest.java # iidm/iidm-tck/src/test/java/com/powsybl/iidm/network/tck/AbstractGeneratorTest.java # iidm/iidm-tck/src/test/java/com/powsybl/iidm/network/tck/AbstractLineTest.java # iidm/iidm-tck/src/test/java/com/powsybl/iidm/network/tck/AbstractThreeWindingsTransformerTest.java # iidm/iidm-tck/src/test/java/com/powsybl/iidm/network/tck/AbstractTwoWindingsTransformerTest.java
Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com>
Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com>
Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com>
Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com>
Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com>
SonarCloud Quality Gate failed. |
I have modified the PR for the builder to copy everything in any case from the existing object (which would be what a user expects). No field is left blank, the user has to rewrite the ones they need/want to define. |
Signed-off-by: RALAMBOTIANA MIORA miora.ralambotiana@rte-france.com
Please check if the PR fulfills these requirements (please use
'[x]'
to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'
and skip the restWhat kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature: create components from existing components (e.g. a new generator initialized with all the values of an existing generator)
Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
No
Other information:
Documentation not complete: adders for partial contained objects must be documented (if everyone agrees)