Replace components xml file by json file (issue #238) #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
flo-dup
requested changes
Sep 17, 2021
single-line-diagram-core/src/main/java/com/powsybl/sld/library/ComponentMetadata.java
Outdated
Show resolved
Hide resolved
single-line-diagram-core/src/main/java/com/powsybl/sld/library/ComponentMetadata.java
Outdated
Show resolved
Hide resolved
single-line-diagram-core/src/main/java/com/powsybl/sld/library/Component.java
Outdated
Show resolved
Hide resolved
single-line-diagram-core/src/test/java/com/powsybl/sld/library/ComponentsTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
|
Kudos, SonarCloud Quality Gate passed! |
flo-dup
approved these changes
Sep 20, 2021
flo-dup
deleted the
issue_238_replace_components_xml_file_by_json_file
branch
flo-dup
pushed a commit
that referenced
this pull request
Sep 22, 2021
* Remove jaxb dependency * Replace components.xml file by components.json file * Delete unused jaxb adapter files * Merge ComponentMetadata class into Component class Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Thomas ADAM tadam@silicom.fr
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the rest'#238'
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
Using JAXB dependency
What is the new behavior (if this is a feature change)?
No JAXB dependency needed
Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)