Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Middle twt node refactoring #349

Merged
merged 6 commits into from
Feb 17, 2022
Merged

Middle twt node refactoring #349

merged 6 commits into from
Feb 17, 2022

Conversation

BenoitJeanson
Copy link
Contributor

@BenoitJeanson BenoitJeanson commented Feb 14, 2022

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest
no

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
decoupling dependencies of MiddleTwtNodes to Graph

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?
unchanged

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

… Test NOK

Signed-off-by: BenoitJeanson <benoit.jeanson@rte-france.com>
@flo-dup flo-dup force-pushed the MiddleTwtNodeRefactoring branch from 92da1a2 to b4a372c Compare February 14, 2022 12:33
Signed-off-by: BenoitJeanson <benoit.jeanson@rte-france.com>
Signed-off-by: BenoitJeanson <benoit.jeanson@rte-france.com>
Signed-off-by: BenoitJeanson <benoit.jeanson@rte-france.com>
@flo-dup flo-dup force-pushed the MiddleTwtNodeRefactoring branch from b4a372c to 9e1ae0e Compare February 14, 2022 12:43
BenoitJeanson and others added 2 commits February 17, 2022 16:52
Signed-off-by: BenoitJeanson <benoit.jeanson@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@flo-dup flo-dup merged commit 8a8a5e3 into main Feb 17, 2022
@flo-dup flo-dup deleted the MiddleTwtNodeRefactoring branch February 17, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants