Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flip horizontally components in bottom direction cells #377

Merged
merged 35 commits into from
Apr 20, 2022
Merged

Flip horizontally components in bottom direction cells #377

merged 35 commits into from
Apr 20, 2022

Conversation

tadam50
Copy link
Contributor

@tadam50 tadam50 commented Mar 23, 2022

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest
#191

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature

What is the current behavior? (You can also link to an open issue here)
Components can be rotated when being in bottom direction cells but not flipped horizontally

What is the new behavior (if this is a feature change)?
Components can be easily flipped horizontally if in bottom direction cells

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

tadam50 added 4 commits March 23, 2022 14:27
@tadam50
Replace isAllowRotation by transformations map
dd25590 
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
@tadam50
Make changes near as previous tests results
12f0867 
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
@tadam50
Fix checkstyle
9189b26 
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
@tadam50
Fix referenced tests results json files
fd62034 
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
@tadam50 tadam50 requested a review from flo-dup March 23, 2022 15:27
@tadam50 tadam50 self-assigned this Mar 23, 2022
tadam50 and others added 10 commits March 23, 2022 17:17
@tadam50
Remove rotationAngle from metadata
a0f0367 
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
@tadam50
Remove rotationAngle from Node
0faec91 
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
@tadam50
Implement setOrientation into AbstractPrimaryBlock (setOrientation on…
c4cc96d 
… nodes removed from BodyPrimaryBlock)

Signed-off-by: Thomas ADAM <tadam@silicom.fr>
@tadam50
Add flip transformation
e14cf53 
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
@tadam50
Move 2wt & 3wt orientation management into manageSnakelines
724bffe 
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
@tadam50
Set nominal provider into TestSVGWriter::testSubstation
5ec1109 
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
@tadam50
Make easier to get windingNode
add9e53 
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
@tadam50
Fix code smell
265dca1 
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
@tadam50
Fix checkstyle
582c1ca 
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
@flo-dup
Merge branch 'main' into issue_191
7718d50 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
tadam50 and others added 8 commits March 31, 2022 14:50
@tadam50
Taking into account PR comments
dc8233c 
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
@tadam50
Remove isRotated in getWindingVoltageLevelInfos
4fd8dd1 
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
@flo-dup
Simplify windings rotations
e581bba 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Fix simplification
3728279 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@tadam50
Remove Node::isRotated
b8198cb 
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
@tadam50
Implement Down Flip for 3wt
d07e7c2 
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
@tadam50
Fix CGMES compilation issues
ece42ef 
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
@tadam50
Fix code smell
5cf46e4 
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
@tadam50 tadam50 marked this pull request as ready for review April 7, 2022 12:45
flo-dup added 3 commits April 19, 2022 16:39
@flo-dup
Keep block orders when merging two parallel blocks
0a6a50a 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Handle 3WT orientation in vertical substation layout
2c9dee7 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Fix anchor point transformation
d6aa449 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
flo-dup added 10 commits April 19, 2022 16:39
@flo-dup
Adjust TestCase11 unit test
eb08c61 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Support of 3wt embedded in voltage level graphs
3a7d2d7 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Fix test
81dd263 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Invert LEFT/RIGHT rotations
147ffd2 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Do not rotate disconnectors
96f9f18 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Update unit tests references
e08f207 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Fix code smell
d46b2b2 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Merge branch 'main' into issue_191
9a24741 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Fix BusNode orientation
ad20327 
Default to RIGHT, then getOrientation().isHorizontal() is true
Can be UP from CGMES DL data

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Update unit tests
905eb75 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

88.0% 88.0% Coverage
0.0% 0.0% Duplication

@flo-dup flo-dup merged commit d047487 into main Apr 20, 2022
@flo-dup flo-dup deleted the issue_191 branch April 20, 2022 15:06
@flo-dup flo-dup linked an issue Sep 30, 2022 that may be closed by this pull request
Flip horizontally components in bottom direction cells #191
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flo-dup flo-dup flo-dup approved these changes

Assignees

@tadam50 tadam50

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flip horizontally components in bottom direction cells
2 participants
@tadam50 @flo-dup