Decoupling cells and layout, blocks and layout #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: BenoitJeanson <benoit.jeanson@rte-france.com>
Signed-off-by: BenoitJeanson <benoit.jeanson@rte-france.com>
flo-dup
requested changes
Apr 1, 2022
single-line-diagram-core/src/main/java/com/powsybl/sld/layout/BlockCalculationVisitors.java
Outdated
Show resolved
Hide resolved
single-line-diagram-core/src/main/java/com/powsybl/sld/layout/BlockCalculationVisitors.java
Outdated
Show resolved
Hide resolved
single-line-diagram-core/src/main/java/com/powsybl/sld/layout/BlockCalculationVisitors.java
Outdated
Show resolved
Hide resolved
single-line-diagram-core/src/main/java/com/powsybl/sld/layout/BlockCalculationVisitors.java
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,131 @@ | |||
| /** | |||
| * Copyright (c) 2019, RTE (http://www.rte-france.com) | |||
There was a problem hiding this comment.
could you change the header of the all the new added files by replacing 2019 by 2022?
single-line-diagram-core/src/main/java/com/powsybl/sld/layout/CalculateCellCoordVisitor.java
Outdated
Show resolved
Hide resolved
| * @author Benoit Jeanson <benoit.jeanson at rte-france.com> | ||
| */ | ||
| public class BlockCalculationVisitors { | ||
| LayoutParameters layoutParameters; |
There was a problem hiding this comment.
Could be final and private. But you can remove it in fact, BlockCalculationVisitors can be final, with private constructor and with only static methods.
single-line-diagram-core/src/main/java/com/powsybl/sld/layout/BlockCalculationVisitors.java
Outdated
Show resolved
Hide resolved
single-line-diagram-core/src/main/java/com/powsybl/sld/layout/CalculateCellCoordVisitor.java
Outdated
Show resolved
Hide resolved
single-line-diagram-core/src/main/java/com/powsybl/sld/layout/PositionVoltageLevelLayout.java
Outdated
Show resolved
Hide resolved
Signed-off-by: BenoitJeanson <benoit.jeanson@rte-france.com>
Signed-off-by: BenoitJeanson <benoit.jeanson@rte-france.com>
|
Kudos, SonarCloud Quality Gate passed! |
flo-dup
approved these changes
Apr 5, 2022
flo-dup
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the restno
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
decoupling of subpackage from model by decoupling LayoutParameters and LayoutContext to avoid circular dependencies of subpackages.
(if any of the questions/checkboxes don't apply, please delete them entirely)