Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Refactor DC Outer Loops creation #1144

Conversation

vmouradian
Copy link
Member

@vmouradian vmouradian commented Dec 5, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

Part of #1091 + adds consistency (imo)

What kind of change does this PR introduce?

Feature

  • DC Outerloops creation is made more consistent with AC ones (created in the OLF parameters class then are contained in DcLoadFlowParameters)

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

@vmouradian vmouradian self-assigned this Dec 5, 2024
@vmouradian vmouradian force-pushed the feature/refactor-outer-loops branch 2 times, most recently from 822e54b to 5b602bd Compare December 6, 2024 13:57
@vmouradian vmouradian changed the title [WIP] Feature: Refactor outer loops : new "active" parameter + more consistent DC OL creation [WIP] Feature: More consistent DC Outer Loop creation Dec 6, 2024
@vmouradian vmouradian force-pushed the feature/refactor-outer-loops branch from ef819c4 to 5d88652 Compare December 17, 2024 13:46
@vmouradian vmouradian changed the title [WIP] Feature: More consistent DC Outer Loop creation Feature: More consistent DC Outer Loop creation Dec 18, 2024
@vmouradian vmouradian changed the base branch from feature/contingency-parameters-extension to main December 18, 2024 10:44
@vmouradian vmouradian changed the base branch from main to feature/contingency-parameters-extension December 18, 2024 10:45
@vmouradian vmouradian changed the title Feature: More consistent DC Outer Loop creation Feature: Refactor DC Outer Loop creation Dec 18, 2024
@vmouradian vmouradian changed the title Feature: Refactor DC Outer Loop creation Feature: Refactor DC Outer Loops creation Dec 18, 2024
@vmouradian vmouradian force-pushed the feature/refactor-outer-loops branch from 5d88652 to 1a417ae Compare December 18, 2024 15:13
@vmouradian vmouradian merged commit 1a417ae into feature/contingency-parameters-extension Dec 18, 2024
4 of 6 checks passed
@vmouradian vmouradian force-pushed the feature/contingency-parameters-extension branch from d47e484 to 69fe35c Compare December 18, 2024 15:14
@vmouradian vmouradian deleted the feature/refactor-outer-loops branch December 18, 2024 15:14
@vmouradian vmouradian restored the feature/refactor-outer-loops branch December 18, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant