Update makefile to add a build_rules
#2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It would be really useful to be able to pull in `core` to a repo the same way `KE-complex_modifications` does. It's entirely possible to make rules that are not useful or reasonable to have polluting the public page. This allows one to do that and run `make -C core build_rules`, which will just build the rules without trying to build the 'groups' or webpage stuff. Currently this is how I have my repo setup, and then I simply symlink `~/.config/karabiner/assets/<file>` to `<repo>/public/json/<file>`. This modification has `all` call `build_rules`, so there's absolutely no change in workflow for anyone contributing their rules to the primary repo. Signed-off-by: Phil Dibowitz <phil@ipom.com>
|
Thanks! |
|
Thanks for the quick response. And thanks for this project! I recently got a new job which forces me to use a Mac (instead of linux), and KE has been the only thing keeping me sane. (I sponsored as well.) |
|
Thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be really useful to be able to pull in
coretoa repo the same way
KE-complex_modificationsdoes. It's entirelypossible to make rules that are not useful or reasonable to have
polluting the public page.
This allows one to do that and run
make -C core build_rules, whichwill just build the rules without trying to build the 'groups' or
webpage stuff.
Currently this is how I have my repo setup, and then I simply symlink
~/.config/karabiner/assets/<file>to<repo>/public/json/<file>.This modification has
allcallbuild_rules, so there's absolutelyno change in workflow for anyone contributing their rules to the
primary repo.