Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deactivate top menu bar when mouse leaves #25

Merged
merged 4 commits into from
Mar 24, 2021

Conversation

sunhwan
Copy link
Contributor

@sunhwan sunhwan commented Mar 22, 2021

The code left the menu item highlighted when the mouse clicked other element on the screen. This fixes the top menu item to be deactivates when the mouse leaves the menu bar and other elements are clicked.

The active menu is preserved when the mouse simply moves away from the menu, but deactivates when the mouse is clicked on other part of the screen.

Copy link
Owner

@prabhuignoto prabhuignoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sunhwan thanks for fixing this. can you take a look at the minor linting issue. otherwise the fix looks solid

src/components/MenuBar.vue Outdated Show resolved Hide resolved
@prabhuignoto prabhuignoto merged commit 1880091 into prabhuignoto:master Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants