added future DOB validation

praekeltfoundation · Nov 12, 2024 · 072673c · 072673c
1 parent 5802e61
commit 072673c
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 1 deletion.
diff --git a/go-app-ussd_clinic_rapidpro.js b/go-app-ussd_clinic_rapidpro.js
@@ -911,13 +911,19 @@ go.app = function() {
                             "Enter the day that baby was born as a number. For example if baby was born on 12th May, type in 12"
                         ].join("\n"));
                     }
+                    if (date > current_date){
+                        return $(
+                            "Sorry, that date is in the future. Please enter a valid date."
+                        );
+                    }
                     if (!date.isBetween(current_date.clone().add(-2, "years"), current_date.add(1, "days")) ) {
                         return $(
                             "Unfortunately MomConnect doesn't send messages to children older " +
                             "than 2 years. Please try again by entering the day the baby was " +
                             "born as a number, e.g. 12."
                         );
-                    }
+                        }
+
                 },
                 next: "state_id_type"
             });

diff --git a/src/ussd_clinic_rapidpro.js b/src/ussd_clinic_rapidpro.js
@@ -650,6 +650,11 @@ go.app = function() {
                             "Enter the day that baby was born as a number. For example if baby was born on 12th May, type in 12"
                         ].join("\n"));
                     }
+                    if (date > current_date){
+                        return $(
+                            "Sorry, that date is in the future. Please enter a valid date."
+                        );
+                    }
                     if (!date.isBetween(current_date.clone().add(-2, "years"), current_date.add(1, "days")) ) {
                         return $(
                             "Unfortunately MomConnect doesn't send messages to children older " +

diff --git a/test/ussd_clinic_rapidpro.test.js b/test/ussd_clinic_rapidpro.test.js
@@ -1108,6 +1108,17 @@ describe("ussd_clinic app", function() {
                 })
                 .run();
         });
+        it("should return an error if the date of birth is in the future", function() {
+            return tester
+                .setup.user.state("state_birth_day")
+                .setup.user.answer("state_birth_month","2020-04")
+                .input("1")
+                .check.interaction({
+                    reply:
+                    "Sorry, that date is in the future. Please enter a valid date."
+                })
+                .run();
+        });
         it("should pass if the date of birth is today", function() {
             return tester
                 .setup.user.state("state_birth_day")