From 70549b65a0c7dd48930282de85cb1fe4bf8ff559 Mon Sep 17 00:00:00 2001 From: Gerrit Vermeulen Date: Mon, 21 Oct 2024 09:54:56 +0200 Subject: [PATCH] Add a check to see that edd gets written to flow results --- .github/workflows/ci.yaml | 2 +- Onboarding/QA/tests/edd-reminders_test.exs | 2 +- Onboarding/README.md | 4 ++++ 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 3a50803..c79196f 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -29,7 +29,7 @@ jobs: uses: actions/checkout@v4 with: repository: praekeltfoundation/flow_tester - ref: v0.3.0 + ref: v0.3.5 path: flow_tester ssh-key: ${{ secrets.SSH_PRIVATE_KEY }} diff --git a/Onboarding/QA/tests/edd-reminders_test.exs b/Onboarding/QA/tests/edd-reminders_test.exs index 4afd0bc..0af8049 100644 --- a/Onboarding/QA/tests/edd-reminders_test.exs +++ b/Onboarding/QA/tests/edd-reminders_test.exs @@ -484,7 +484,7 @@ defmodule EDDRemindersTest do text: ^edd_confirmation_text, }) |> contact_matches(%{"edd" => ^full_edd}) - # TODO: Add a test for the write_result + |> result_matches(%{name: "edd", value: ^full_edd}) end test "edd confirmed -> main menu" do diff --git a/Onboarding/README.md b/Onboarding/README.md index f886051..b766af8 100644 --- a/Onboarding/README.md +++ b/Onboarding/README.md @@ -28,6 +28,10 @@ Pull requests are welcome. For major changes, please open an issue first to disc Please make sure to update tests as appropriate. +## Tests + +Running the tests requires elixir >= 1.17 (for Date.shift) + ## Opening Journey as Markdown You can open a Turn Journey as a markdown file by taking the url, removing `/app` and appending `?format=md`. A one click solution is to add the following code as a bookmark