Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bugfix / revert
Did you add tests for your changes?
N/A
Summary
TLDR:
Partial revert of #1426
Having used it for a bit, I don't find it to be particularly compelling, especially w/ Webpack v5 --
methodName
is often null and not correct enough for determining user vs lib code.Additionally, I've found the stack trace locations (from Node / v8, to be clear) to be exceptionally poor on Webpack's minimized output, and so have elected to not minimize our SSR build.
Take the following:
As
foo
is not defined, we should get a (reference) error here (and we do). However, the stack trace ofssr-bundle.js
actually points to theh("div", { class: ... }, ...)
.Why this is, I don't know. Mix of Webpack's output and Node maybe? Regardless, it's not great and reduces the quality of our error reporting (as it highlights the wrong line). But what we can do is just not minimize the SSR output. As it's only ran in Node, we don't have any particular reason to minimize, and a couple against, such as:
Does this PR introduce a breaking change?
No