From 3c0951ce22350746d8d54f00d0d95cb206ba1011 Mon Sep 17 00:00:00 2001 From: jdecroock Date: Sat, 25 Feb 2023 09:35:21 +0100 Subject: [PATCH 1/2] changeset --- .changeset/fluffy-poets-happen.md | 5 +++++ src/util.js | 7 ++++--- 2 files changed, 9 insertions(+), 3 deletions(-) create mode 100644 .changeset/fluffy-poets-happen.md diff --git a/.changeset/fluffy-poets-happen.md b/.changeset/fluffy-poets-happen.md new file mode 100644 index 00000000..591f6ed5 --- /dev/null +++ b/.changeset/fluffy-poets-happen.md @@ -0,0 +1,5 @@ +--- +'preact-render-to-string': patch +--- + +Follow up fixes to #278 diff --git a/src/util.js b/src/util.js index bb761980..a50bfc3b 100644 --- a/src/util.js +++ b/src/util.js @@ -66,14 +66,15 @@ export function styleObjToCss(s) { (JS_TO_CSS[prop] = prop.replace(CSS_REGEX, '-$1').toLowerCase()); let suffix = ';'; - if (SUFFIX_CACHE[name]) { + let isNumber = typeof val === 'number'; + if (isNumber && SUFFIX_CACHE[name]) { suffix = 'px'; } else if ( - typeof val === 'number' && + isNumber && IS_NON_DIMENSIONAL.test(prop.toLowerCase()) === false ) { SUFFIX_CACHE[name] = true; - suffix = 'px'; + suffix = 'px;'; } str = str + name + ':' + val + suffix; } From dfac25a419aaa725fe33f25a382f0797e4a53e69 Mon Sep 17 00:00:00 2001 From: Jovi De Croock Date: Sat, 25 Feb 2023 09:38:52 +0100 Subject: [PATCH 2/2] Update util.js --- src/util.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util.js b/src/util.js index a50bfc3b..db59ed19 100644 --- a/src/util.js +++ b/src/util.js @@ -68,7 +68,7 @@ export function styleObjToCss(s) { let suffix = ';'; let isNumber = typeof val === 'number'; if (isNumber && SUFFIX_CACHE[name]) { - suffix = 'px'; + suffix = 'px;'; } else if ( isNumber && IS_NON_DIMENSIONAL.test(prop.toLowerCase()) === false