Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add http-compression #951

Closed
wants to merge 1 commit into from
Closed

Conversation

Kikobeats
Copy link

Hello,

I backported @polka/compression into a standalone package, so you don't need to copy/paste anymore 🙂

@changeset-bot
Copy link

changeset-bot bot commented Jan 26, 2023

⚠️ No Changeset found

Latest commit: 6ee9d26

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@rschristian
Copy link
Member

Fully agree with what Patak wrote over on Vite: vitejs/vite#11815 (comment)

Adding a dependency is always something to be careful about, and the selling point for this one is... moving a little bit of code outside the project? I don't think it's particularly compelling.

Thanks for writing a PR though.

@Kikobeats Kikobeats deleted the http-compression branch April 24, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants