PAAPI: fix bug where auctions break if adunits have only placeholder …

…sizes (#12222)
prebid · Sep 10, 2024 · 657228d · 657228d
1 parent 0a7627e
commit 657228d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/modules/paapi.js b/modules/paapi.js
@@ -314,9 +314,11 @@ function getFledgeConfig(bidder) {
  * Given an array of size tuples, return the one that should be used for PAAPI.
  */
 export const getPAAPISize = hook('sync', function (sizes) {
+  sizes = sizes
+    ?.filter(([w, h]) => !(w === h && w <= 5));
+
   if (sizes?.length) {
     return sizes
-      .filter(([w, h]) => !(w === h && w <= 5))
       .reduce(maximum(keyCompare(([w, h]) => w * h)));
   }
 }, 'getPAAPISize');

diff --git a/test/spec/modules/paapi_spec.js b/test/spec/modules/paapi_spec.js
@@ -1122,6 +1122,10 @@ describe('paapi module', () => {
       'can handle no input': {
         in: undefined,
         out: undefined
+      },
+      'can handle placeholder sizes': {
+        in: [[1, 1]],
+        out: undefined
       }
     }).forEach(([t, {in: input, out}]) => {
       it(t, () => {