From 907a9c7bac5f3f400d68ee7e980356d879f5d0d3 Mon Sep 17 00:00:00 2001
From: yuvalgg <57989766+yuvalgg@users.noreply.github.com>
Date: Fri, 2 Oct 2020 00:39:35 +0300
Subject: [PATCH] Intentiq id add validation (#5797)

* Add validity check to ignore not-available response

* Added tests

* Added error log
---
 modules/intentIqIdSystem.js                | 36 ++++++++++++++++++++--
 test/spec/modules/intentIqIdSystem_spec.js |  8 +++++
 2 files changed, 41 insertions(+), 3 deletions(-)

diff --git a/modules/intentIqIdSystem.js b/modules/intentIqIdSystem.js
index 88da7d44481..bb74b1210cb 100644
--- a/modules/intentIqIdSystem.js
+++ b/modules/intentIqIdSystem.js
@@ -11,6 +11,32 @@ import {submodule} from '../src/hook.js'
 
 const MODULE_NAME = 'intentIqId';
 
+const NOT_AVAILABLE = 'NA';
+
+/**
+ * Verify the id is valid - Id value or Not Found (ignore not available response)
+ * @param id
+ * @returns {boolean|*|boolean}
+ */
+function isValidId(id) {
+  return id && id != '' && id != NOT_AVAILABLE && isValidResponse(id);
+}
+
+/**
+ * Ignore not available response JSON
+ * @param obj
+ * @returns {boolean}
+ */
+function isValidResponse(obj) {
+  try {
+    obj = JSON.parse(obj);
+    return obj && obj['RESULT'] != NOT_AVAILABLE;
+  } catch (error) {
+    utils.logError(error);
+    return true;
+  }
+}
+
 /** @type {Submodule} */
 export const intentIqIdSubmodule = {
   /**
@@ -22,10 +48,10 @@ export const intentIqIdSubmodule = {
    * decode the stored id value for passing to bid requests
    * @function
    * @param {{string}} value
-   * @returns {{intentIqId:string}}
+   * @returns {{intentIqId: {string}}|undefined}
    */
   decode(value) {
-    return (value && value != '') ? { 'intentIqId': value } : undefined;
+    return isValidId(value) ? { 'intentIqId': value } : undefined;
   },
   /**
    * performs action to obtain id and return a value in the callback's response argument
@@ -47,7 +73,11 @@ export const intentIqIdSubmodule = {
     const resp = function (callback) {
       const callbacks = {
         success: response => {
-          callback(response);
+          if (isValidId(response)) {
+            callback(response);
+          } else {
+            callback();
+          }
         },
         error: error => {
           utils.logError(`${MODULE_NAME}: ID fetch encountered an error`, error);
diff --git a/test/spec/modules/intentIqIdSystem_spec.js b/test/spec/modules/intentIqIdSystem_spec.js
index 2dccde18855..951cfab5f50 100644
--- a/test/spec/modules/intentIqIdSystem_spec.js
+++ b/test/spec/modules/intentIqIdSystem_spec.js
@@ -55,6 +55,14 @@ describe('IntentIQ tests', function () {
     expect(callBackSpy.calledOnce).to.be.true;
   });
 
+  it('should ignore NA and invalid responses', function () {
+    let resp = JSON.stringify({'RESULT': 'NA'});
+    expect(intentIqIdSubmodule.decode(resp)).to.equal(undefined);
+    expect(intentIqIdSubmodule.decode('NA')).to.equal(undefined);
+    expect(intentIqIdSubmodule.decode('')).to.equal(undefined);
+    expect(intentIqIdSubmodule.decode(undefined)).to.equal(undefined);
+  });
+
   it('should call the IntentIQ endpoint with only partner, pai', function () {
     let callBackSpy = sinon.spy();
     let submoduleCallback = intentIqIdSubmodule.getId(paiConfigParams).callback;