From e6bd48cfd09189ea4ed7a47b8aa4f41096046e64 Mon Sep 17 00:00:00 2001 From: Demetrio Girardi Date: Fri, 20 May 2022 12:21:01 -0700 Subject: [PATCH] convert bidders: missena --- modules/minutemediaBidAdapter.js | 5 +++-- modules/missenaBidAdapter.js | 3 ++- modules/my6senseBidAdapter.js | 1 + test/spec/modules/missenaBidAdapter_spec.js | 2 +- 4 files changed, 7 insertions(+), 4 deletions(-) diff --git a/modules/minutemediaBidAdapter.js b/modules/minutemediaBidAdapter.js index 9096fa3e31a..72f93c4fc20 100644 --- a/modules/minutemediaBidAdapter.js +++ b/modules/minutemediaBidAdapter.js @@ -423,8 +423,9 @@ function generateGeneralParams(generalObject, bidderRequest) { } if (bidderRequest && bidderRequest.refererInfo) { - generalParams.referrer = deepAccess(bidderRequest, 'refererInfo.referer'); - generalParams.page_url = config.getConfig('pageUrl') || deepAccess(window, 'location.href'); + // TODO: are these the right refererInfo values - does the fallback make sense? + generalParams.ref = deepAccess(bidderRequest, 'refererInfo.ref'); + generalParams.page_url = deepAccess(bidderRequest, 'refererInfo.page') || window.location.href } return generalParams diff --git a/modules/missenaBidAdapter.js b/modules/missenaBidAdapter.js index 41bae4d6568..4f629784a17 100644 --- a/modules/missenaBidAdapter.js +++ b/modules/missenaBidAdapter.js @@ -35,7 +35,8 @@ export const spec = { }; if (bidderRequest && bidderRequest.refererInfo) { - payload.referer = bidderRequest.refererInfo.referer; + // TODO: is 'topmostLocation' the right value here? + payload.referer = bidderRequest.refererInfo.topmostLocation; payload.referer_canonical = bidderRequest.refererInfo.canonicalUrl; } diff --git a/modules/my6senseBidAdapter.js b/modules/my6senseBidAdapter.js index b4fc1049304..163e3c20e4b 100644 --- a/modules/my6senseBidAdapter.js +++ b/modules/my6senseBidAdapter.js @@ -11,6 +11,7 @@ function isBidRequestValid(bid) { } function getUrl(url) { + // TODO: this should probably look at refererInfo if (!url) { url = window.location.href;// "clean" url of current web page } diff --git a/test/spec/modules/missenaBidAdapter_spec.js b/test/spec/modules/missenaBidAdapter_spec.js index 86b967cca5b..2b3a271e300 100644 --- a/test/spec/modules/missenaBidAdapter_spec.js +++ b/test/spec/modules/missenaBidAdapter_spec.js @@ -49,7 +49,7 @@ describe('Missena Adapter', function () { gdprApplies: true, }, refererInfo: { - referer: 'https://referer', + topmostLocation: 'https://referer', canonicalUrl: 'https://canonical', }, };