From f6e1008ad9216c86801d706ca875f13e3976bbf4 Mon Sep 17 00:00:00 2001
From: Patrick McCann <patmmccann@gmail.com>
Date: Thu, 27 Jun 2024 09:52:22 -0400
Subject: [PATCH] Update pairIdSystem.js: add defensive code before json parse
 (#11870)

* Update pairIdSystem.js: add defensive code before json parse

* Update pairIdSystem.js

* Update pairIdSystem.js

* Update pairIdSystem.js

fix indents

* Update pairIdSystem.js
---
 modules/pairIdSystem.js | 37 +++++++++++++++++++++++++++----------
 1 file changed, 27 insertions(+), 10 deletions(-)

diff --git a/modules/pairIdSystem.js b/modules/pairIdSystem.js
index dbff4c6a402..778857bae1c 100644
--- a/modules/pairIdSystem.js
+++ b/modules/pairIdSystem.js
@@ -50,9 +50,11 @@ export const pairIdSubmodule = {
     return value && Array.isArray(value) ? {'pairId': value} : undefined
   },
   /**
-   * performs action to obtain id and return a value in the callback's response argument
-   * @function
-   * @returns {id: string | undefined }
+   * Performs action to obtain ID and return a value in the callback's response argument.
+   * @function getId
+   * @param {Object} config - The configuration object.
+   * @param {Object} config.params - The parameters from the configuration.
+   * @returns {{id: string[] | undefined}} The obtained IDs or undefined if no IDs are found.
    */
   getId(config) {
     const pairIdsString = pairIdFromLocalStorage(PAIR_ID_KEY) || pairIdFromCookie(PAIR_ID_KEY)
@@ -67,13 +69,28 @@ export const pairIdSubmodule = {
 
     const configParams = (config && config.params) || {};
     if (configParams && configParams.liveramp) {
-      let LRStorageLocation = configParams.liveramp.storageKey || DEFAULT_LIVERAMP_PAIR_ID_KEY
-      const liverampValue = pairIdFromLocalStorage(LRStorageLocation) || pairIdFromCookie(LRStorageLocation)
-      try {
-        const obj = JSON.parse(atob(liverampValue));
-        ids = ids.concat(obj.envelope);
-      } catch (error) {
-        logInfo(error)
+      let LRStorageLocation = configParams.liveramp.storageKey || DEFAULT_LIVERAMP_PAIR_ID_KEY;
+      const liverampValue = pairIdFromLocalStorage(LRStorageLocation) || pairIdFromCookie(LRStorageLocation);
+
+      if (liverampValue) {
+        try {
+          const parsedValue = atob(liverampValue);
+          if (parsedValue) {
+            const obj = JSON.parse(parsedValue);
+
+            if (obj && typeof obj === 'object' && obj.envelope) {
+              ids = ids.concat(obj.envelope);
+            } else {
+              logInfo('Pairid: Parsed object is not valid or does not contain envelope');
+            }
+          } else {
+            logInfo('Pairid: Decoded value is empty');
+          }
+        } catch (error) {
+          logInfo('Pairid: Error parsing JSON: ', error);
+        }
+      } else {
+        logInfo('Pairid: liverampValue for pairId from storage is empty or null');
       }
     }