From 9a3b10bfcbd7e523bbb18007afa989fffc726992 Mon Sep 17 00:00:00 2001 From: "Timothy M. Ace" Date: Tue, 3 Oct 2023 11:47:06 -0400 Subject: [PATCH 1/4] imds: Rename usersync from "pixel" to correct name of "image". --- modules/imdsBidAdapter.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/imdsBidAdapter.js b/modules/imdsBidAdapter.js index 122662feb8a..8565b66c07b 100644 --- a/modules/imdsBidAdapter.js +++ b/modules/imdsBidAdapter.js @@ -324,7 +324,7 @@ export const spec = { }); } else if (syncOptions.pixelEnabled) { syncs.push({ - type: 'pixel', + type: 'image', url: `${USER_SYNC_PIXEL_URL}?srv=cs&${queryParams.join('&')}` }); } From 5271c705e50ff2e6c27c94169d3068fa37b2bad2 Mon Sep 17 00:00:00 2001 From: "Timothy M. Ace" Date: Tue, 3 Oct 2023 11:58:07 -0400 Subject: [PATCH 2/4] imds: Update documentation for "DFP Video Creative" to match prebid.github.io. --- modules/imdsBidAdapter.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/modules/imdsBidAdapter.md b/modules/imdsBidAdapter.md index 15fb407e7ef..2a50868d726 100644 --- a/modules/imdsBidAdapter.md +++ b/modules/imdsBidAdapter.md @@ -11,11 +11,11 @@ Maintainer: eng-demand@imds.tv The iMedia Digital Services adapter requires setup and approval from iMedia Digital Services. Please reach out to your account manager for more information. -### DFP Video Creative -To use video, setup a `VAST redirect` creative within Google AdManager (DFP) with the following VAST tag URL: +### Google Ad Manager Video Creative +To use video, setup a `VAST redirect` creative within Google Ad Manager with the following VAST tag URL: -``` -https://track.technoratimedia.com/openrtb/tags?ID=%%PATTERN:hb_cache_id_synacorm%%&AUCTION_PRICE=%%PATTERN:hb_pb_synacormedia%% +```text +https://track.technoratimedia.com/openrtb/tags?ID=%%PATTERN:hb_uuid_imds%%&AUCTION_PRICE=%%PATTERN:hb_pb_imds%% ``` # Test Parameters From 2f119f046891a026ee6d1d2f762caf55c9c4d599 Mon Sep 17 00:00:00 2001 From: "Timothy M. Ace" Date: Tue, 3 Oct 2023 12:27:12 -0400 Subject: [PATCH 3/4] imds: Test modifications for renamed pixel->image usersync --- test/spec/modules/imdsBidAdapter_spec.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/spec/modules/imdsBidAdapter_spec.js b/test/spec/modules/imdsBidAdapter_spec.js index 7d808a2528f..b71a0bc51d9 100644 --- a/test/spec/modules/imdsBidAdapter_spec.js +++ b/test/spec/modules/imdsBidAdapter_spec.js @@ -1362,17 +1362,17 @@ describe('imdsBidAdapter ', function () { expect(usersyncs[0].url).to.contain('https://ad-cdn.technoratimedia.com/html/usersync.html'); }); - it('should return a pixel usersync when pixels is enabled', function () { + it('should return an image usersync when pixels are enabled', function () { let usersyncs = spec.getUserSyncs({ pixelEnabled: true }, null); expect(usersyncs).to.be.an('array').with.lengthOf(1); - expect(usersyncs[0]).to.have.property('type', 'pixel'); + expect(usersyncs[0]).to.have.property('type', 'image'); expect(usersyncs[0]).to.have.property('url'); expect(usersyncs[0].url).to.contain('https://sync.technoratimedia.com/services'); }); - it('should return an iframe usersync when both iframe and pixels is enabled', function () { + it('should return an iframe usersync when both iframe and pixel are enabled', function () { let usersyncs = spec.getUserSyncs({ iframeEnabled: true, pixelEnabled: true From e4c44d052e0b538689db0f8a7e5a4bd924212fd6 Mon Sep 17 00:00:00 2001 From: "Timothy M. Ace" Date: Tue, 3 Oct 2023 13:49:41 -0400 Subject: [PATCH 4/4] imds: Remove warning for valid no-bid empty body 204 responses. --- modules/imdsBidAdapter.js | 1 - 1 file changed, 1 deletion(-) diff --git a/modules/imdsBidAdapter.js b/modules/imdsBidAdapter.js index 8565b66c07b..4cad1d614c5 100644 --- a/modules/imdsBidAdapter.js +++ b/modules/imdsBidAdapter.js @@ -224,7 +224,6 @@ export const spec = { }; if (!serverResponse.body || typeof serverResponse.body != 'object') { - logWarn('IMDS: server returned empty/non-json response: ' + JSON.stringify(serverResponse.body)); return; } const {id, seatbid: seatbids} = serverResponse.body;