From 989b2ab7a500a39c4c708387002785281e7a269e Mon Sep 17 00:00:00 2001 From: ahzgg Date: Tue, 2 Apr 2024 10:28:53 -0600 Subject: [PATCH 1/3] displaymanager: add field for displaymanager and displaymanagerver --- modules/gumgumBidAdapter.js | 3 ++- test/spec/modules/gumgumBidAdapter_spec.js | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/modules/gumgumBidAdapter.js b/modules/gumgumBidAdapter.js index 7f8627ec5f7..7deddb538ef 100644 --- a/modules/gumgumBidAdapter.js +++ b/modules/gumgumBidAdapter.js @@ -318,7 +318,8 @@ function buildRequests(validBidRequests, bidderRequest) { const gpid = deepAccess(ortb2Imp, 'ext.data.pbadslot') || deepAccess(ortb2Imp, 'ext.data.adserver.adslot'); let sizes = [1, 1]; let data = {}; - + data.displaymanager = 'Prebid.js'; + data.displaymanagerver = '$prebid.version$'; const date = new Date(); const lt = date.getTime(); const to = date.getTimezoneOffset(); diff --git a/test/spec/modules/gumgumBidAdapter_spec.js b/test/spec/modules/gumgumBidAdapter_spec.js index 52cfd0294e7..691d6ce8c9f 100644 --- a/test/spec/modules/gumgumBidAdapter_spec.js +++ b/test/spec/modules/gumgumBidAdapter_spec.js @@ -192,6 +192,8 @@ describe('gumgumAdapter', function () { const request = { ...bidRequests[0] }; const bidRequest = spec.buildRequests([request])[0]; expect(bidRequest.data.aun).to.equal(bidRequests[0].adUnitCode); + expect(bidRequest.data.displaymanager).to.equal('Prebid.js'); + expect(bidRequest.data.displaymanagerver).to.equal(JCSI.pbv); }); it('should set pubProvidedId if the uid and pubProvidedId are available', function () { const request = { ...bidRequests[0] }; From d61fc7dae67ba532fd0a124590f916ba5492731c Mon Sep 17 00:00:00 2001 From: ahzgg Date: Tue, 2 Apr 2024 15:46:24 -0600 Subject: [PATCH 2/3] fix: displayManager to include 'gumgum' --- modules/gumgumBidAdapter.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/gumgumBidAdapter.js b/modules/gumgumBidAdapter.js index 7deddb538ef..60851d2b4dd 100644 --- a/modules/gumgumBidAdapter.js +++ b/modules/gumgumBidAdapter.js @@ -318,7 +318,7 @@ function buildRequests(validBidRequests, bidderRequest) { const gpid = deepAccess(ortb2Imp, 'ext.data.pbadslot') || deepAccess(ortb2Imp, 'ext.data.adserver.adslot'); let sizes = [1, 1]; let data = {}; - data.displaymanager = 'Prebid.js'; + data.displaymanager = 'Prebid.js - gumgum'; data.displaymanagerver = '$prebid.version$'; const date = new Date(); const lt = date.getTime(); From 85ea75799747ef1f30afd1bddef80102ba8d218a Mon Sep 17 00:00:00 2001 From: ahzgg Date: Tue, 2 Apr 2024 15:52:49 -0600 Subject: [PATCH 3/3] fix: test case --- test/spec/modules/gumgumBidAdapter_spec.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/spec/modules/gumgumBidAdapter_spec.js b/test/spec/modules/gumgumBidAdapter_spec.js index 691d6ce8c9f..29e372d0f87 100644 --- a/test/spec/modules/gumgumBidAdapter_spec.js +++ b/test/spec/modules/gumgumBidAdapter_spec.js @@ -192,7 +192,7 @@ describe('gumgumAdapter', function () { const request = { ...bidRequests[0] }; const bidRequest = spec.buildRequests([request])[0]; expect(bidRequest.data.aun).to.equal(bidRequests[0].adUnitCode); - expect(bidRequest.data.displaymanager).to.equal('Prebid.js'); + expect(bidRequest.data.displaymanager).to.equal('Prebid.js - gumgum'); expect(bidRequest.data.displaymanagerver).to.equal(JCSI.pbv); }); it('should set pubProvidedId if the uid and pubProvidedId are available', function () {