From f5f6d97602a770e5eca4f5c9910a5cdd6937950d Mon Sep 17 00:00:00 2001
From: Aparna Hegde <aparna.hegde@33across.com>
Date: Tue, 7 Nov 2017 10:04:37 -0500
Subject: [PATCH 01/11] Adding 33across adapter

---
 modules/33acrossBidAdapter.js                | 140 ++++++
 modules/33acrossBidAdapter.md                |  95 ++++
 test/spec/modules/33acrossBidAdapter_spec.js | 443 +++++++++++++++++++
 3 files changed, 678 insertions(+)
 create mode 100644 modules/33acrossBidAdapter.js
 create mode 100644 modules/33acrossBidAdapter.md
 create mode 100644 test/spec/modules/33acrossBidAdapter_spec.js

diff --git a/modules/33acrossBidAdapter.js b/modules/33acrossBidAdapter.js
new file mode 100644
index 00000000000..b496a66d081
--- /dev/null
+++ b/modules/33acrossBidAdapter.js
@@ -0,0 +1,140 @@
+const { registerBidder } = require('../src/adapters/bidderFactory');
+const utils = require('../src/utils');
+
+const BIDDER_CODE = '33across';
+const END_POINT = 'https://ssc.33across.com/api/v1/hb';
+const SYNC_ENDPOINT = 'https://de.tynt.com/deb/v2?m=xch';
+
+// All this assumes that only one bid is ever returned by ttx
+function _createBidResponse(response) {
+  return {
+    requestId: response.id,
+    bidderCode: BIDDER_CODE,
+    cpm: response.seatbid[0].bid[0].price,
+    width: response.seatbid[0].bid[0].w,
+    height: response.seatbid[0].bid[0].h,
+    ad: response.seatbid[0].bid[0].adm,
+    ttl: response.seatbid[0].bid[0].ttl || 60,
+    creativeId: response.seatbid[0].bid[0].ext.rp.advid,
+    currency: response.cur,
+    netRevenue: true
+  }
+}
+
+// infer the necessary data from valid bid for a minimal ttxRequest and create HTTP request
+function _createServerRequest(bidRequest) {
+  const ttxRequest = {};
+  const params = bidRequest.params;
+
+  ttxRequest.imp = [];
+  ttxRequest.imp[0] = {
+    banner: {
+      format: bidRequest.sizes.map(_getFormatSize)
+    },
+    ext: {
+      ttx: {
+        prod: params.productId
+      }
+    }
+  }
+
+  // Allowing site to be a test configuration object or just the id (former required for testing,
+  // latter when used by publishers)
+  ttxRequest.site = params.site || { id: params.siteId };
+
+  // Go ahead send the bidId in request to 33exchange so it's kept track of in the bid response and
+  // therefore in ad targetting process
+  ttxRequest.id = bidRequest.bidId;
+
+  const options = {
+    contentType: 'application/json',
+    withCredentials: false
+  };
+
+  if (bidRequest.params.customHeaders) {
+    options.customHeaders = bidRequest.params.customHeaders;
+  }
+
+  return {
+    'method': 'POST',
+    'url': bidRequest.params.url || END_POINT,
+    'data': JSON.stringify(ttxRequest),
+    'options': options
+  }
+}
+
+// Sync object will always be of type iframe for ttx
+function _createSync(bid) {
+  const syncUrl = bid.params.syncUrl || SYNC_ENDPOINT;
+
+  return {
+    type: 'iframe',
+    url: `${syncUrl}&id=${bid.params.siteId || bid.params.site.id}`
+  }
+}
+
+function _getFormatSize(sizeArr) {
+  return {
+    w: sizeArr[0],
+    h: sizeArr[1],
+    ext: {}
+  }
+}
+
+function isBidRequestValid(bid) {
+  if (bid.bidder !== BIDDER_CODE || typeof bid.params === 'undefined') {
+    return false;
+  }
+
+  if ((typeof bid.params.site === 'undefined' || typeof bid.params.site.id === 'undefined') &&
+  (typeof bid.params.siteId === 'undefined')) {
+    return false;
+  }
+
+  if (typeof bid.params.productId === 'undefined') {
+    return false;
+  }
+
+  return true;
+}
+
+// NOTE: At this point, 33exchange only accepts request for a single impression
+function buildRequests(bidRequests) {
+  return bidRequests.map(_createServerRequest);
+}
+
+// NOTE: At this point, the response from 33exchange will only ever contain one bid i.e. the highest bid
+function interpretResponse(serverResponse) {
+  const bidResponses = [];
+
+  // If there are bids, look at the first bid of the first seatbid (see NOTE above for assumption about ttx)
+  if (serverResponse.body.seatbid.length > 0 && serverResponse.body.seatbid[0].bid.length > 0) {
+    bidResponses.push(_createBidResponse(serverResponse.body));
+  }
+
+  return bidResponses;
+}
+
+// Register one sync per bid since each ad unit may potenitally be linked to a uniqe guid
+function getUserSyncs(syncOptions) {
+  let syncs = [];
+  const ttxBidRequests = utils.getBidderRequestAllAdUnits(BIDDER_CODE).bids;
+
+  if (syncOptions.iframeEnabled) {
+    syncs = ttxBidRequests.map(_createSync);
+  }
+
+  return syncs;
+}
+
+const spec = {
+  code: BIDDER_CODE,
+  isBidRequestValid,
+  buildRequests,
+  interpretResponse,
+  getUserSyncs
+}
+
+registerBidder(spec);
+
+module.exports = spec;
diff --git a/modules/33acrossBidAdapter.md b/modules/33acrossBidAdapter.md
new file mode 100644
index 00000000000..c4eb319c157
--- /dev/null
+++ b/modules/33acrossBidAdapter.md
@@ -0,0 +1,95 @@
+# Overview
+
+```
+Module Name:  33Across Bid Adapter
+Module Type:  Bidder Adapter
+Maintainer: aparna.hegde@33across.com
+```
+
+# Description
+
+Connects to 33Across's exchange for bids.
+
+33Across bid adapter supports only Banner at present and follows MRA
+
+# Sample Ad Unit: For Publishers
+```
+var adUnits = [
+{
+    code: '33across-hb-ad-123456-1',    
+    sizes: [
+        [300, 250], 
+        [728, 90]
+    ],     
+    bids: [{
+        bidder: '33across',
+        params: {
+            siteId: 'pub1234',     
+            productId: 'infeed'     
+        }
+    }]
+}
+```
+
+# Ad Unit and Setup: For Testing
+In order to receive bids please map localhost to (any) test domain.
+
+```
+<--! Prebid Config section >
+<script> 
+    var PREBID_TIMEOUT = 3000;
+    var adUnits = [
+    {
+        code: '33across-hb-ad-123456-1',
+        sizes: [
+            [300, 250], 
+            [728, 90]
+        ],     
+        bids: [{
+            bidder: '33across',
+            params: {
+            site: {
+                id: 'aRlI5W_9yr5jkxacwqm_6r',
+                page: "http://thinkbabynames.com/baby-mcbabyface",
+                ext: {
+                    ttx: {
+                        ssp_configs: [
+                            {
+                            "name": "index",
+                            "enabled": false
+                            },
+                            {
+                            "name": "rubicon",
+                            "enabled": true
+                            },
+                            {
+                            "name": "33xchange",
+                            "enabled": false
+                            }
+                        ]
+                    }
+                }
+            },
+            productId: 'infeed'
+        }
+        }]
+    }
+    ];
+    
+    var pbjs = pbjs || {};
+    pbjs.que = pbjs.que || [];
+
+    // Adjust bid CPM to ensure it wins the auction (USED ONLY FOR TESTING). Need to do this since test bids have too low a CPM
+    pbjs.bidderSettings = {
+      '33across': {
+        bidCpmAdjustment : function(bidCpm, bid){
+          // adjust the bid in real time before the auction takes place, only do so for valid bids ignore no bids
+          if (bid.w !== 0 && bid.h !== 0 && bidCpm !== 0) {
+            return bidCpm + 0.50;
+          }
+        }
+      }
+    };
+  </script>
+  <!-- End Prebid Config section>
+  ```
\ No newline at end of file
diff --git a/test/spec/modules/33acrossBidAdapter_spec.js b/test/spec/modules/33acrossBidAdapter_spec.js
new file mode 100644
index 00000000000..1cd4953b965
--- /dev/null
+++ b/test/spec/modules/33acrossBidAdapter_spec.js
@@ -0,0 +1,443 @@
+const { expect } = require('chai');
+const utils = require('../../../src/utils');
+const { isBidRequestValid, buildRequests, interpretResponse, getUserSyncs } = require('../../../modules/33acrossBidAdapter');
+
+describe('33acrossBidAdapter:', function () {
+  const BIDDER_CODE = '33across';
+  const SITE_ID = 'pub1234';
+  const PRODUCT_ID = 'product1';
+  const END_POINT = 'https://ssc.33across.com/api/v1/hb';
+
+  beforeEach(function() {
+    this.bidRequests = [
+      {
+        bidId: 'b1',
+        bidder: '33across',
+        bidderRequestId: 'b1a',
+        params: {
+          siteId: SITE_ID,
+          productId: PRODUCT_ID
+        },
+        placementCode: 'div-id',
+        requestId: 'r1',
+        sizes: [
+          [300, 250],
+          [728, 90]
+        ],
+        transactionId: 't1'
+      }
+    ]
+    this.sandbox = sinon.sandbox.create();
+  });
+
+  afterEach(function() {
+    this.sandbox.restore();
+  });
+
+  describe('isBidRequestValid:', function () {
+    context('valid bid request:', function () {
+      it('returns true when bidder, params.siteId, params.productId are set', function() {
+        const validBid = {
+          bidder: BIDDER_CODE,
+          params: {
+            siteId: SITE_ID,
+            productId: PRODUCT_ID
+          }
+        }
+
+        expect(isBidRequestValid(validBid)).to.be.true;
+      })
+    });
+
+    context('valid test bid request:', function () {
+      it('returns true when bidder, params.site.id, params.productId are set', function() {
+        const validBid = {
+          bidder: BIDDER_CODE,
+          params: {
+            site: {
+              id: SITE_ID
+            },
+            productId: PRODUCT_ID
+          }
+        }
+
+        expect(isBidRequestValid(validBid)).to.be.true;
+      });
+    });
+
+    context('invalid bid request:', function () {
+      it('returns false when bidder not set to "33across"', function () {
+        const invalidBid = {
+          bidder: 'foo',
+          params: {
+            siteId: SITE_ID,
+            productId: PRODUCT_ID
+          }
+        }
+
+        expect(isBidRequestValid(invalidBid)).to.be.false;
+      });
+
+      it('returns false when params not set', function() {
+        const invalidBid = {
+          bidder: 'foo'
+        }
+
+        expect(isBidRequestValid(invalidBid)).to.be.false;
+      });
+
+      it('returns false when params.siteId or params.site.id not set', function() {
+        const invalidBid = {
+          bidder: 'foo',
+          params: {
+            productId: PRODUCT_ID
+          }
+        }
+
+        expect(isBidRequestValid(invalidBid)).to.be.false;
+      });
+
+      it('returns false when params.productId not set', function() {
+        const invalidBid = {
+          bidder: 'foo',
+          params: {
+            siteId: SITE_ID
+          }
+        }
+
+        expect(isBidRequestValid(invalidBid)).to.be.false;
+      });
+    });
+  });
+
+  describe('buildRequests:', function() {
+    it('returns corresponding server requests for each valid bidRequest', function() {
+      const ttxRequest = {
+        imp: [{
+          banner: {
+            format: [
+              {
+                w: 300,
+                h: 250,
+                ext: {}
+              },
+              {
+                w: 728,
+                h: 90,
+                ext: {}
+              }
+            ]
+          },
+          ext: {
+            ttx: {
+              prod: PRODUCT_ID
+            }
+          }
+        }],
+        site: {
+          id: SITE_ID
+        },
+        id: 'b1'
+      };
+      const serverRequest = {
+        method: 'POST',
+        url: END_POINT,
+        data: JSON.stringify(ttxRequest),
+        options: {
+          contentType: 'application/json',
+          withCredentials: false
+        }
+      }
+      const builtServerRequests = buildRequests(this.bidRequests);
+      expect(builtServerRequests).to.deep.equal([serverRequest]);
+      expect(builtServerRequests.length).to.equal(1);
+    });
+
+    it('returns corresponding server requests for each valid test bidRequest', function() {
+      delete this.bidRequests[0].params.siteId;
+      this.bidRequests[0].params.site = {
+        id: SITE_ID,
+        page: 'http://test-url.com'
+      }
+      this.bidRequests[0].params.customHeaders = {
+        foo: 'bar'
+      };
+      this.bidRequests[0].params.url = '//staging-ssc.33across.com/api/v1/hb';
+
+      const ttxRequest = {
+        imp: [{
+          banner: {
+            format: [
+              {
+                w: 300,
+                h: 250,
+                ext: {}
+              },
+              {
+                w: 728,
+                h: 90,
+                ext: {}
+              }
+            ]
+          },
+          ext: {
+            ttx: {
+              prod: PRODUCT_ID
+            }
+          }
+        }],
+        site: {
+          id: SITE_ID,
+          page: 'http://test-url.com'
+        },
+        id: 'b1'
+      };
+      const serverRequest = {
+        method: 'POST',
+        url: '//staging-ssc.33across.com/api/v1/hb',
+        data: JSON.stringify(ttxRequest),
+        options: {
+          contentType: 'application/json',
+          withCredentials: false,
+          customHeaders: {
+            foo: 'bar'
+          }
+        }
+      };
+
+      const builtServerRequests = buildRequests(this.bidRequests);
+      expect(builtServerRequests).to.deep.equal([serverRequest]);
+      expect(builtServerRequests.length).to.equal(1);
+    });
+
+    afterEach(function() {
+      delete this.bidRequests;
+    })
+  });
+
+  describe('interpretResponse', function() {
+    context('when exactly one bid is returned', function() {
+      it('interprets and returns the single bid response', function() {
+        const serverResponse = {
+          cur: 'USD',
+          ext: {},
+          id: 'b1',
+          seatbid: [
+            {
+              bid: [{
+                id: '1',
+                adm: '<html><h3>I am an ad</h3></html>',
+                ext: {
+                  rp: {
+                    advid: 1
+                  }
+                },
+                h: 250,
+                w: 300,
+                price: 0.0938
+              }]
+            }
+          ]
+        };
+
+        const bidResponse = {
+          requestId: 'b1',
+          bidderCode: BIDDER_CODE,
+          cpm: 0.0938,
+          width: 300,
+          height: 250,
+          ad: '<html><h3>I am an ad</h3></html>',
+          ttl: 60,
+          creativeId: 1,
+          currency: 'USD',
+          netRevenue: true
+        }
+
+        expect(interpretResponse({body: serverResponse})).to.deep.equal([bidResponse]);
+      });
+    });
+
+    context('when no bids are returned', function() {
+      it('interprets and returns empty array', function() {
+        const serverResponse = {
+          cur: 'USD',
+          ext: {},
+          id: 'b1',
+          seatbid: []
+        };
+
+        expect(interpretResponse({body: serverResponse})).to.deep.equal([]);
+      });
+    });
+
+    context('when more than one bids are returned', function() {
+      it('interprets and returns the the first bid of the first seatbid', function() {
+        const serverResponse = {
+          cur: 'USD',
+          ext: {},
+          id: 'b1',
+          seatbid: [
+            {
+              bid: [{
+                id: '1',
+                adm: '<html><h3>I am an ad</h3></html>',
+                ext: {
+                  rp: {
+                    advid: 1
+                  }
+                },
+                h: 250,
+                w: 300,
+                price: 0.0940
+              },
+              {
+                id: '2',
+                adm: '<html><h3>I am an ad</h3></html>',
+                ext: {
+                  rp: {
+                    advid: 2
+                  }
+                },
+                h: 250,
+                w: 300,
+                price: 0.0938
+              }
+              ]
+            },
+            {
+              bid: [{
+                id: '3',
+                adm: '<html><h3>I am an ad</h3></html>',
+                ext: {
+                  rp: {
+                    advid: 3
+                  }
+                },
+                h: 250,
+                w: 300,
+                price: 0.0938
+              }]
+            }
+          ]
+        };
+
+        const bidResponse = {
+          requestId: 'b1',
+          bidderCode: BIDDER_CODE,
+          cpm: 0.0940,
+          width: 300,
+          height: 250,
+          ad: '<html><h3>I am an ad</h3></html>',
+          ttl: 60,
+          creativeId: 1,
+          currency: 'USD',
+          netRevenue: true
+        }
+
+        expect(interpretResponse({body: serverResponse})).to.deep.equal([bidResponse]);
+      });
+    });
+  });
+
+  describe('getUserSyncs', function() {
+    beforeEach(function() {
+      this.ttxBids = [
+        {
+          params: {
+            siteId: 'id1',
+            productId: 'p1'
+          }
+        },
+        {
+          params: {
+            siteId: 'id2',
+            productId: 'p1'
+          }
+        }
+      ];
+
+      this.testTTXBids = [
+        {
+          params: {
+            site: { id: 'id1' },
+            productId: 'p1',
+            syncUrl: 'https://staging-de.tynt.com/deb/v2?m=xch'
+          }
+        },
+        {
+          params: {
+            site: { id: 'id2' },
+            productId: 'p1',
+            syncUrl: 'https://staging-de.tynt.com/deb/v2?m=xch'
+          }
+        }
+      ];
+
+      this.syncs = [
+        {
+          type: 'iframe',
+          url: 'https://de.tynt.com/deb/v2?m=xch&id=id1'
+        },
+        {
+          type: 'iframe',
+          url: 'https://de.tynt.com/deb/v2?m=xch&id=id2'
+        },
+      ];
+
+      this.testSyncs = [
+        {
+          type: 'iframe',
+          url: 'https://staging-de.tynt.com/deb/v2?m=xch&id=id1'
+        },
+        {
+          type: 'iframe',
+          url: 'https://staging-de.tynt.com/deb/v2?m=xch&id=id2'
+        },
+      ];
+    });
+
+    context('when iframe is not enabled', function() {
+      it('returns empty sync array', function() {
+        this.sandbox.stub(utils, 'getBidderRequestAllAdUnits', () => (
+          {
+            bids: this.ttxBids
+          }
+        ));
+        const syncOptions = {};
+        expect(getUserSyncs(syncOptions)).to.deep.equal([]);
+      });
+    });
+
+    context('when iframe is enabled', function() {
+      it('returns sync array equal to number of bids for ttx', function() {
+        this.sandbox.stub(utils, 'getBidderRequestAllAdUnits', () => (
+          {
+            bids: this.ttxBids
+          }
+        ));
+
+        const syncOptions = {
+          iframeEnabled: true
+        };
+        const syncs = getUserSyncs(syncOptions);
+        expect(syncs.length).to.equal(this.ttxBids.length);
+        expect(syncs).to.deep.equal(this.syncs);
+      });
+
+      it('returns sync array equal to number of test bids for ttx', function() {
+        this.sandbox.stub(utils, 'getBidderRequestAllAdUnits', () => (
+          {
+            bids: this.testTTXBids
+          }
+        ));
+
+        const syncOptions = {
+          iframeEnabled: true
+        };
+        const syncs = getUserSyncs(syncOptions);
+        expect(syncs.length).to.equal(this.testTTXBids.length);
+        expect(syncs).to.deep.equal(this.testSyncs);
+      });
+    });
+  });
+});

From 253ecfde98520ea02676245881eb49ec4c487fdb Mon Sep 17 00:00:00 2001
From: Aparna Hegde <aparna.hegde@33across.com>
Date: Wed, 8 Nov 2017 14:59:05 -0500
Subject: [PATCH 02/11] Updated per code review from Prebid. See
 https://github.com/prebid/Prebid.js/pull/1805#pullrequestreview-75218582

---
 test/spec/modules/33acrossBidAdapter_spec.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/spec/modules/33acrossBidAdapter_spec.js b/test/spec/modules/33acrossBidAdapter_spec.js
index 1cd4953b965..edb9958ae66 100644
--- a/test/spec/modules/33acrossBidAdapter_spec.js
+++ b/test/spec/modules/33acrossBidAdapter_spec.js
@@ -18,7 +18,7 @@ describe('33acrossBidAdapter:', function () {
           siteId: SITE_ID,
           productId: PRODUCT_ID
         },
-        placementCode: 'div-id',
+        adUnitCode: 'div-id',
         requestId: 'r1',
         sizes: [
           [300, 250],

From 22930f0d2ad95495c86fe03596079f36c8fbbb9a Mon Sep 17 00:00:00 2001
From: Aparna Hegde <aparna.hegde@33across.com>
Date: Fri, 17 Nov 2017 16:29:09 -0500
Subject: [PATCH 03/11] Added support for test bid and crid.

---
 modules/33acrossBidAdapter.js | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)

diff --git a/modules/33acrossBidAdapter.js b/modules/33acrossBidAdapter.js
index b496a66d081..9db9fd50891 100644
--- a/modules/33acrossBidAdapter.js
+++ b/modules/33acrossBidAdapter.js
@@ -3,7 +3,9 @@ const utils = require('../src/utils');
 
 const BIDDER_CODE = '33across';
 const END_POINT = 'https://ssc.33across.com/api/v1/hb';
+const TEST_END_POINT = 'https://staging-ssc.33across.com/api/v1/hb';
 const SYNC_ENDPOINT = 'https://de.tynt.com/deb/v2?m=xch';
+const TEST_SYNC_ENDPOINT = 'https://de.tynt.com/deb/v2?m=xch';
 
 // All this assumes that only one bid is ever returned by ttx
 function _createBidResponse(response) {
@@ -15,7 +17,7 @@ function _createBidResponse(response) {
     height: response.seatbid[0].bid[0].h,
     ad: response.seatbid[0].bid[0].adm,
     ttl: response.seatbid[0].bid[0].ttl || 60,
-    creativeId: response.seatbid[0].bid[0].ext.rp.advid,
+    creativeId: response.seatbid[0].bid[0].crid,
     currency: response.cur,
     netRevenue: true
   }
@@ -25,6 +27,7 @@ function _createBidResponse(response) {
 function _createServerRequest(bidRequest) {
   const ttxRequest = {};
   const params = bidRequest.params;
+  const url = (params.test === 1) ? (TEST_END_POINT) : (END_POINT);
 
   ttxRequest.imp = [];
   ttxRequest.imp[0] = {
@@ -38,14 +41,17 @@ function _createServerRequest(bidRequest) {
     }
   }
 
-  // Allowing site to be a test configuration object or just the id (former required for testing,
-  // latter when used by publishers)
-  ttxRequest.site = params.site || { id: params.siteId };
+  ttxRequest.site =  { id: params.siteId };
 
   // Go ahead send the bidId in request to 33exchange so it's kept track of in the bid response and
   // therefore in ad targetting process
   ttxRequest.id = bidRequest.bidId;
 
+  // Finally, set the openRTB 'test' param if this is to be a test bid
+  if (params.test === 1) {
+    ttxRequest.test = 1;
+  }
+
   const options = {
     contentType: 'application/json',
     withCredentials: false
@@ -57,7 +63,7 @@ function _createServerRequest(bidRequest) {
 
   return {
     'method': 'POST',
-    'url': bidRequest.params.url || END_POINT,
+    'url': url,
     'data': JSON.stringify(ttxRequest),
     'options': options
   }
@@ -65,7 +71,7 @@ function _createServerRequest(bidRequest) {
 
 // Sync object will always be of type iframe for ttx
 function _createSync(bid) {
-  const syncUrl = bid.params.syncUrl || SYNC_ENDPOINT;
+  const syncUrl = (bid.params.test === 1) ? (TEST_SYNC_ENDPOINT) : (SYNC_ENDPOINT);
 
   return {
     type: 'iframe',

From 53da36ac18be4c261ea6a75439de0d613025b1a7 Mon Sep 17 00:00:00 2001
From: Aparna Hegde <aparna.hegde@33across.com>
Date: Mon, 20 Nov 2017 12:38:04 -0500
Subject: [PATCH 04/11] Removed ability to set test url via params

---
 modules/33acrossBidAdapter.js                |  15 +-
 test/spec/modules/33acrossBidAdapter_spec.js | 459 +++++++++----------
 2 files changed, 213 insertions(+), 261 deletions(-)

diff --git a/modules/33acrossBidAdapter.js b/modules/33acrossBidAdapter.js
index 9db9fd50891..f754d909493 100644
--- a/modules/33acrossBidAdapter.js
+++ b/modules/33acrossBidAdapter.js
@@ -41,7 +41,7 @@ function _createServerRequest(bidRequest) {
     }
   }
 
-  ttxRequest.site =  { id: params.siteId };
+  ttxRequest.site = { id: params.siteId };
 
   // Go ahead send the bidId in request to 33exchange so it's kept track of in the bid response and
   // therefore in ad targetting process
@@ -57,10 +57,6 @@ function _createServerRequest(bidRequest) {
     withCredentials: false
   };
 
-  if (bidRequest.params.customHeaders) {
-    options.customHeaders = bidRequest.params.customHeaders;
-  }
-
   return {
     'method': 'POST',
     'url': url,
@@ -75,7 +71,7 @@ function _createSync(bid) {
 
   return {
     type: 'iframe',
-    url: `${syncUrl}&id=${bid.params.siteId || bid.params.site.id}`
+    url: `${syncUrl}&id=${bid.params.siteId}`
   }
 }
 
@@ -92,12 +88,7 @@ function isBidRequestValid(bid) {
     return false;
   }
 
-  if ((typeof bid.params.site === 'undefined' || typeof bid.params.site.id === 'undefined') &&
-  (typeof bid.params.siteId === 'undefined')) {
-    return false;
-  }
-
-  if (typeof bid.params.productId === 'undefined') {
+  if (typeof bid.params.siteId === 'undefined' || typeof bid.params.productId === 'undefined') {
     return false;
   }
 
diff --git a/test/spec/modules/33acrossBidAdapter_spec.js b/test/spec/modules/33acrossBidAdapter_spec.js
index edb9958ae66..4a295944ebb 100644
--- a/test/spec/modules/33acrossBidAdapter_spec.js
+++ b/test/spec/modules/33acrossBidAdapter_spec.js
@@ -1,6 +1,11 @@
 const { expect } = require('chai');
 const utils = require('../../../src/utils');
-const { isBidRequestValid, buildRequests, interpretResponse, getUserSyncs } = require('../../../modules/33acrossBidAdapter');
+const {
+  isBidRequestValid,
+  buildRequests,
+  interpretResponse,
+  getUserSyncs
+} = require('../../../modules/33acrossBidAdapter');
 
 describe('33acrossBidAdapter:', function () {
   const BIDDER_CODE = '33across';
@@ -21,8 +26,8 @@ describe('33acrossBidAdapter:', function () {
         adUnitCode: 'div-id',
         requestId: 'r1',
         sizes: [
-          [300, 250],
-          [728, 90]
+          [ 300, 250 ],
+          [ 728, 90 ]
         ],
         transactionId: 't1'
       }
@@ -35,85 +40,78 @@ describe('33acrossBidAdapter:', function () {
   });
 
   describe('isBidRequestValid:', function () {
-    context('valid bid request:', function () {
-      it('returns true when bidder, params.siteId, params.productId are set', function() {
-        const validBid = {
-          bidder: BIDDER_CODE,
-          params: {
-            siteId: SITE_ID,
-            productId: PRODUCT_ID
-          }
+    it('returns true when bidder params.siteId, params.productId are set', function() {
+      const validBid = {
+        bidder: BIDDER_CODE,
+        params: {
+          siteId: SITE_ID,
+          productId: PRODUCT_ID
         }
+      }
 
-        expect(isBidRequestValid(validBid)).to.be.true;
-      })
+      expect(isBidRequestValid(validBid)).to.be.true;
     });
 
-    context('valid test bid request:', function () {
-      it('returns true when bidder, params.site.id, params.productId are set', function() {
-        const validBid = {
-          bidder: BIDDER_CODE,
-          params: {
-            site: {
-              id: SITE_ID
-            },
-            productId: PRODUCT_ID
-          }
+    it('returns true when bidder, params.siteId, params.productId and test are set', function() {
+      const validBid = {
+        bidder: BIDDER_CODE,
+        params: {
+          siteId: SITE_ID,
+          productId: PRODUCT_ID,
+          test: 1
         }
+      }
 
-        expect(isBidRequestValid(validBid)).to.be.true;
-      });
+      expect(isBidRequestValid(validBid)).to.be.true;
     });
 
-    context('invalid bid request:', function () {
-      it('returns false when bidder not set to "33across"', function () {
-        const invalidBid = {
-          bidder: 'foo',
-          params: {
-            siteId: SITE_ID,
-            productId: PRODUCT_ID
-          }
+    it('returns false when bidder not set to "33across"', function () {
+      const invalidBid = {
+        bidder: 'foo',
+        params: {
+          siteId: SITE_ID,
+          productId: PRODUCT_ID
         }
+      }
 
-        expect(isBidRequestValid(invalidBid)).to.be.false;
-      });
+      expect(isBidRequestValid(invalidBid)).to.be.false;
+    });
 
-      it('returns false when params not set', function() {
-        const invalidBid = {
-          bidder: 'foo'
-        }
+    it('returns false when params not set', function() {
+      const invalidBid = {
+        bidder: 'foo'
+      }
 
-        expect(isBidRequestValid(invalidBid)).to.be.false;
-      });
+      expect(isBidRequestValid(invalidBid)).to.be.false;
+    });
 
-      it('returns false when params.siteId or params.site.id not set', function() {
-        const invalidBid = {
-          bidder: 'foo',
-          params: {
-            productId: PRODUCT_ID
-          }
+    it('returns false when params.siteId not set', function() {
+      const invalidBid = {
+        bidder: 'foo',
+        params: {
+          productId: PRODUCT_ID
         }
+      }
 
-        expect(isBidRequestValid(invalidBid)).to.be.false;
-      });
+      expect(isBidRequestValid(invalidBid)).to.be.false;
+    });
 
-      it('returns false when params.productId not set', function() {
-        const invalidBid = {
-          bidder: 'foo',
-          params: {
-            siteId: SITE_ID
-          }
+    it('returns false when params.productId not set', function() {
+      const invalidBid = {
+        bidder: 'foo',
+        params: {
+          siteId: SITE_ID
         }
+      }
 
-        expect(isBidRequestValid(invalidBid)).to.be.false;
-      });
+      expect(isBidRequestValid(invalidBid)).to.be.false;
     });
   });
 
   describe('buildRequests:', function() {
     it('returns corresponding server requests for each valid bidRequest', function() {
       const ttxRequest = {
-        imp: [{
+        imp: [ {
           banner: {
             format: [
               {
@@ -133,50 +131,42 @@ describe('33acrossBidAdapter:', function () {
               prod: PRODUCT_ID
             }
           }
-        }],
+        } ],
         site: {
           id: SITE_ID
         },
         id: 'b1'
       };
       const serverRequest = {
-        method: 'POST',
-        url: END_POINT,
-        data: JSON.stringify(ttxRequest),
-        options: {
-          contentType: 'application/json',
-          withCredentials: false
+        'method': 'POST',
+        'url': END_POINT,
+        'data': JSON.stringify(ttxRequest),
+        'options': {
+          'contentType': 'application/json',
+          'withCredentials': false
         }
       }
       const builtServerRequests = buildRequests(this.bidRequests);
-      expect(builtServerRequests).to.deep.equal([serverRequest]);
+      expect(builtServerRequests).to.deep.equal([ serverRequest ]);
       expect(builtServerRequests.length).to.equal(1);
     });
 
     it('returns corresponding server requests for each valid test bidRequest', function() {
-      delete this.bidRequests[0].params.siteId;
-      this.bidRequests[0].params.site = {
-        id: SITE_ID,
-        page: 'http://test-url.com'
-      }
-      this.bidRequests[0].params.customHeaders = {
-        foo: 'bar'
-      };
-      this.bidRequests[0].params.url = '//staging-ssc.33across.com/api/v1/hb';
+      this.bidRequests[0].params.test = 1;
 
       const ttxRequest = {
-        imp: [{
+        imp: [ {
           banner: {
             format: [
               {
                 w: 300,
                 h: 250,
-                ext: {}
+                ext: { }
               },
               {
                 w: 728,
                 h: 90,
-                ext: {}
+                ext: { }
               }
             ]
           },
@@ -185,28 +175,25 @@ describe('33acrossBidAdapter:', function () {
               prod: PRODUCT_ID
             }
           }
-        }],
+        } ],
         site: {
-          id: SITE_ID,
-          page: 'http://test-url.com'
+          id: SITE_ID
         },
-        id: 'b1'
+        id: 'b1',
+        test: 1
       };
       const serverRequest = {
-        method: 'POST',
-        url: '//staging-ssc.33across.com/api/v1/hb',
-        data: JSON.stringify(ttxRequest),
-        options: {
-          contentType: 'application/json',
-          withCredentials: false,
-          customHeaders: {
-            foo: 'bar'
-          }
+        'method': 'POST',
+        'url': 'https://staging-ssc.33across.com/api/v1/hb',
+        'data': JSON.stringify(ttxRequest),
+        'options': {
+          'contentType': 'application/json',
+          'withCredentials': false
         }
       };
 
       const builtServerRequests = buildRequests(this.bidRequests);
-      expect(builtServerRequests).to.deep.equal([serverRequest]);
+      expect(builtServerRequests).to.deep.equal([ serverRequest ]);
       expect(builtServerRequests.length).to.equal(1);
     });
 
@@ -216,126 +203,104 @@ describe('33acrossBidAdapter:', function () {
   });
 
   describe('interpretResponse', function() {
-    context('when exactly one bid is returned', function() {
-      it('interprets and returns the single bid response', function() {
-        const serverResponse = {
-          cur: 'USD',
-          ext: {},
-          id: 'b1',
-          seatbid: [
-            {
-              bid: [{
-                id: '1',
-                adm: '<html><h3>I am an ad</h3></html>',
-                ext: {
-                  rp: {
-                    advid: 1
-                  }
-                },
-                h: 250,
-                w: 300,
-                price: 0.0938
-              }]
-            }
-          ]
-        };
-
-        const bidResponse = {
-          requestId: 'b1',
-          bidderCode: BIDDER_CODE,
-          cpm: 0.0938,
-          width: 300,
-          height: 250,
-          ad: '<html><h3>I am an ad</h3></html>',
-          ttl: 60,
-          creativeId: 1,
-          currency: 'USD',
-          netRevenue: true
-        }
+    it('interprets and returns the single bid response', function() {
+      const serverResponse = {
+        cur: 'USD',
+        ext: { },
+        id: 'b1',
+        seatbid: [
+          {
+            bid: [ {
+              id: '1',
+              adm: '<html><h3>I am an ad</h3></html>',
+              crid: '1',
+              h: 250,
+              w: 300,
+              price: 0.0938
+            } ]
+          }
+        ]
+      };
+
+      const bidResponse = {
+        requestId: 'b1',
+        bidderCode: BIDDER_CODE,
+        cpm: 0.0938,
+        width: 300,
+        height: 250,
+        ad: '<html><h3>I am an ad</h3></html>',
+        ttl: 60,
+        creativeId: '1',
+        currency: 'USD',
+        netRevenue: true
+      }
 
-        expect(interpretResponse({body: serverResponse})).to.deep.equal([bidResponse]);
-      });
+      expect(interpretResponse({ body: serverResponse })).to.deep.equal([ bidResponse ]);
     });
 
-    context('when no bids are returned', function() {
-      it('interprets and returns empty array', function() {
-        const serverResponse = {
-          cur: 'USD',
-          ext: {},
-          id: 'b1',
-          seatbid: []
-        };
-
-        expect(interpretResponse({body: serverResponse})).to.deep.equal([]);
-      });
+    it('interprets and returns empty array', function() {
+      const serverResponse = {
+        cur: 'USD',
+        ext: { },
+        id: 'b1',
+        seatbid: [ ]
+      };
+
+      expect(interpretResponse({ body: serverResponse })).to.deep.equal([ ]);
     });
 
-    context('when more than one bids are returned', function() {
-      it('interprets and returns the the first bid of the first seatbid', function() {
-        const serverResponse = {
-          cur: 'USD',
-          ext: {},
-          id: 'b1',
-          seatbid: [
-            {
-              bid: [{
-                id: '1',
-                adm: '<html><h3>I am an ad</h3></html>',
-                ext: {
-                  rp: {
-                    advid: 1
-                  }
-                },
-                h: 250,
-                w: 300,
-                price: 0.0940
-              },
-              {
-                id: '2',
-                adm: '<html><h3>I am an ad</h3></html>',
-                ext: {
-                  rp: {
-                    advid: 2
-                  }
-                },
-                h: 250,
-                w: 300,
-                price: 0.0938
-              }
-              ]
+    it('interprets and returns the the first bid of the first seatbid when more bids are returned', function() {
+      const serverResponse = {
+        cur: 'USD',
+        ext: { },
+        id: 'b1',
+        seatbid: [
+          {
+            bid: [ {
+              id: '1',
+              adm: '<html><h3>I am an ad</h3></html>',
+              crid: '1',
+              h: 250,
+              w: 300,
+              price: 0.0940
             },
             {
-              bid: [{
-                id: '3',
-                adm: '<html><h3>I am an ad</h3></html>',
-                ext: {
-                  rp: {
-                    advid: 3
-                  }
-                },
-                h: 250,
-                w: 300,
-                price: 0.0938
-              }]
+              id: '2',
+              adm: '<html><h3>I am an ad</h3></html>',
+              crid: '2',
+              h: 250,
+              w: 300,
+              price: 0.0938
             }
-          ]
-        };
-
-        const bidResponse = {
-          requestId: 'b1',
-          bidderCode: BIDDER_CODE,
-          cpm: 0.0940,
-          width: 300,
-          height: 250,
-          ad: '<html><h3>I am an ad</h3></html>',
-          ttl: 60,
-          creativeId: 1,
-          currency: 'USD',
-          netRevenue: true
-        }
+            ]
+          },
+          {
+            bid: [ {
+              id: '3',
+              adm: '<html><h3>I am an ad</h3></html>',
+              crid: '3',
+              h: 250,
+              w: 300,
+              price: 0.0938
+            } ]
+          }
+        ]
+      };
+
+      const bidResponse = {
+        requestId: 'b1',
+        bidderCode: BIDDER_CODE,
+        cpm: 0.0940,
+        width: 300,
+        height: 250,
+        ad: '<html><h3>I am an ad</h3></html>',
+        ttl: 60,
+        creativeId: '1',
+        currency: 'USD',
+        netRevenue: true
+      }
 
-        expect(interpretResponse({body: serverResponse})).to.deep.equal([bidResponse]);
-      });
+      expect(interpretResponse({ body: serverResponse })).to.deep.equal([ bidResponse ]);
     });
   });
 
@@ -359,16 +324,16 @@ describe('33acrossBidAdapter:', function () {
       this.testTTXBids = [
         {
           params: {
-            site: { id: 'id1' },
+            siteId: 'id1',
             productId: 'p1',
-            syncUrl: 'https://staging-de.tynt.com/deb/v2?m=xch'
+            test: 1
           }
         },
         {
           params: {
-            site: { id: 'id2' },
+            siteId: 'id2',
             productId: 'p1',
-            syncUrl: 'https://staging-de.tynt.com/deb/v2?m=xch'
+            test: 1
           }
         }
       ];
@@ -387,57 +352,53 @@ describe('33acrossBidAdapter:', function () {
       this.testSyncs = [
         {
           type: 'iframe',
-          url: 'https://staging-de.tynt.com/deb/v2?m=xch&id=id1'
+          url: 'https://de.tynt.com/deb/v2?m=xch&id=id1'
         },
         {
           type: 'iframe',
-          url: 'https://staging-de.tynt.com/deb/v2?m=xch&id=id2'
+          url: 'https://de.tynt.com/deb/v2?m=xch&id=id2'
         },
       ];
+
+      this.getFakeBids = () => (
+        {
+          bids: this.ttxBids
+        }
+      );
+
+      this.getFakeTestBids = () => (
+        {
+          bids: this.testTTXBids
+        }
+      );
     });
 
-    context('when iframe is not enabled', function() {
-      it('returns empty sync array', function() {
-        this.sandbox.stub(utils, 'getBidderRequestAllAdUnits', () => (
-          {
-            bids: this.ttxBids
-          }
-        ));
-        const syncOptions = {};
-        expect(getUserSyncs(syncOptions)).to.deep.equal([]);
-      });
+    it('returns empty sync array when iframe is not enabled', function() {
+      this.sandbox.stub(utils, 'getBidderRequestAllAdUnits', this.getFakeBids);
+      const syncOptions = {};
+      expect(getUserSyncs(syncOptions)).to.deep.equal([]);
     });
 
-    context('when iframe is enabled', function() {
-      it('returns sync array equal to number of bids for ttx', function() {
-        this.sandbox.stub(utils, 'getBidderRequestAllAdUnits', () => (
-          {
-            bids: this.ttxBids
-          }
-        ));
-
-        const syncOptions = {
-          iframeEnabled: true
-        };
-        const syncs = getUserSyncs(syncOptions);
-        expect(syncs.length).to.equal(this.ttxBids.length);
-        expect(syncs).to.deep.equal(this.syncs);
-      });
-
-      it('returns sync array equal to number of test bids for ttx', function() {
-        this.sandbox.stub(utils, 'getBidderRequestAllAdUnits', () => (
-          {
-            bids: this.testTTXBids
-          }
-        ));
-
-        const syncOptions = {
-          iframeEnabled: true
-        };
-        const syncs = getUserSyncs(syncOptions);
-        expect(syncs.length).to.equal(this.testTTXBids.length);
-        expect(syncs).to.deep.equal(this.testSyncs);
-      });
+    it('returns sync array equal to number of bids for ttx when iframe is enabled', function() {
+      this.sandbox.stub(utils, 'getBidderRequestAllAdUnits', this.getFakeBids);
+
+      const syncOptions = {
+        iframeEnabled: true
+      };
+      const syncs = getUserSyncs(syncOptions);
+      expect(syncs.length).to.equal(this.ttxBids.length);
+      expect(syncs).to.deep.equal(this.syncs);
+    });
+
+    it('returns sync array equal to number of test bids for ttx when iframe is enabled', function() {
+      this.sandbox.stub(utils, 'getBidderRequestAllAdUnits', this.getFakeTestBids);
+
+      const syncOptions = {
+        iframeEnabled: true
+      };
+      const syncs = getUserSyncs(syncOptions);
+      expect(syncs.length).to.equal(this.testTTXBids.length);
+      expect(syncs).to.deep.equal(this.testSyncs);
     });
   });
 });

From 9f4ca78b6333027cc877f2082dad191f5bbfb10c Mon Sep 17 00:00:00 2001
From: Aparna Hegde <aparna.hegde@33across.com>
Date: Tue, 5 Dec 2017 14:18:34 -0500
Subject: [PATCH 05/11] Incorporated changes requested in
 https://github.com/prebid/Prebid.js/issues/1855 to fix usage of deprecated
 method

---
 modules/33acrossBidAdapter.js                |  25 ++--
 test/spec/modules/33acrossBidAdapter_spec.js | 126 +++++++++----------
 2 files changed, 73 insertions(+), 78 deletions(-)

diff --git a/modules/33acrossBidAdapter.js b/modules/33acrossBidAdapter.js
index f754d909493..261ee349905 100644
--- a/modules/33acrossBidAdapter.js
+++ b/modules/33acrossBidAdapter.js
@@ -1,11 +1,8 @@
 const { registerBidder } = require('../src/adapters/bidderFactory');
-const utils = require('../src/utils');
 
 const BIDDER_CODE = '33across';
 const END_POINT = 'https://ssc.33across.com/api/v1/hb';
-const TEST_END_POINT = 'https://staging-ssc.33across.com/api/v1/hb';
 const SYNC_ENDPOINT = 'https://de.tynt.com/deb/v2?m=xch';
-const TEST_SYNC_ENDPOINT = 'https://de.tynt.com/deb/v2?m=xch';
 
 // All this assumes that only one bid is ever returned by ttx
 function _createBidResponse(response) {
@@ -27,7 +24,7 @@ function _createBidResponse(response) {
 function _createServerRequest(bidRequest) {
   const ttxRequest = {};
   const params = bidRequest.params;
-  const url = (params.test === 1) ? (TEST_END_POINT) : (END_POINT);
+  const url = bidRequest.params.url || END_POINT;
 
   ttxRequest.imp = [];
   ttxRequest.imp[0] = {
@@ -41,7 +38,9 @@ function _createServerRequest(bidRequest) {
     }
   }
 
-  ttxRequest.site = { id: params.siteId };
+  // Allowing site to be a test configuration object or just the id (former required for testing,
+  // latter when used by publishers)
+  ttxRequest.site = params.site || { id: params.siteId };
 
   // Go ahead send the bidId in request to 33exchange so it's kept track of in the bid response and
   // therefore in ad targetting process
@@ -67,11 +66,11 @@ function _createServerRequest(bidRequest) {
 
 // Sync object will always be of type iframe for ttx
 function _createSync(bid) {
-  const syncUrl = (bid.params.test === 1) ? (TEST_SYNC_ENDPOINT) : (SYNC_ENDPOINT);
+  const syncUrl = bid.params.syncUrl || SYNC_ENDPOINT;
 
   return {
     type: 'iframe',
-    url: `${syncUrl}&id=${bid.params.siteId}`
+    url: `${syncUrl}&id=${bid.params.siteId || bid.params.site.id}`
   }
 }
 
@@ -88,7 +87,12 @@ function isBidRequestValid(bid) {
     return false;
   }
 
-  if (typeof bid.params.siteId === 'undefined' || typeof bid.params.productId === 'undefined') {
+  if ((typeof bid.params.site === 'undefined' || typeof bid.params.site.id === 'undefined') &&
+  (typeof bid.params.siteId === 'undefined')) {
+    return false;
+  }
+
+  if (typeof bid.params.productId === 'undefined') {
     return false;
   }
 
@@ -113,12 +117,11 @@ function interpretResponse(serverResponse) {
 }
 
 // Register one sync per bid since each ad unit may potenitally be linked to a uniqe guid
-function getUserSyncs(syncOptions) {
+function getUserSyncs(syncOptions, bidderRequests) {
   let syncs = [];
-  const ttxBidRequests = utils.getBidderRequestAllAdUnits(BIDDER_CODE).bids;
 
   if (syncOptions.iframeEnabled) {
-    syncs = ttxBidRequests.map(_createSync);
+    syncs = bidderRequests.bids.map(_createSync);
   }
 
   return syncs;
diff --git a/test/spec/modules/33acrossBidAdapter_spec.js b/test/spec/modules/33acrossBidAdapter_spec.js
index 4a295944ebb..a76a4280b31 100644
--- a/test/spec/modules/33acrossBidAdapter_spec.js
+++ b/test/spec/modules/33acrossBidAdapter_spec.js
@@ -1,5 +1,4 @@
 const { expect } = require('chai');
-const utils = require('../../../src/utils');
 const {
   isBidRequestValid,
   buildRequests,
@@ -31,16 +30,11 @@ describe('33acrossBidAdapter:', function () {
         ],
         transactionId: 't1'
       }
-    ]
-    this.sandbox = sinon.sandbox.create();
-  });
-
-  afterEach(function() {
-    this.sandbox.restore();
+    ];
   });
 
   describe('isBidRequestValid:', function () {
-    it('returns true when bidder params.siteId, params.productId are set', function() {
+    it('returns true when valid bid request is sent', function() {
       const validBid = {
         bidder: BIDDER_CODE,
         params: {
@@ -52,11 +46,13 @@ describe('33acrossBidAdapter:', function () {
       expect(isBidRequestValid(validBid)).to.be.true;
     });
 
-    it('returns true when bidder, params.siteId, params.productId and test are set', function() {
+    it('returns true when valid test bid request is sent', function() {
       const validBid = {
         bidder: BIDDER_CODE,
         params: {
-          siteId: SITE_ID,
+          site: {
+            id: SITE_ID
+          },
           productId: PRODUCT_ID,
           test: 1
         }
@@ -85,7 +81,7 @@ describe('33acrossBidAdapter:', function () {
       expect(isBidRequestValid(invalidBid)).to.be.false;
     });
 
-    it('returns false when params.siteId not set', function() {
+    it('returns false when site ID is not set in params', function() {
       const invalidBid = {
         bidder: 'foo',
         params: {
@@ -96,7 +92,7 @@ describe('33acrossBidAdapter:', function () {
       expect(isBidRequestValid(invalidBid)).to.be.false;
     });
 
-    it('returns false when params.productId not set', function() {
+    it('returns false when product ID not set in params', function() {
       const invalidBid = {
         bidder: 'foo',
         params: {
@@ -152,6 +148,12 @@ describe('33acrossBidAdapter:', function () {
     });
 
     it('returns corresponding server requests for each valid test bidRequest', function() {
+      delete this.bidRequests[0].params.siteId;
+      this.bidRequests[0].params.site = {
+        id: SITE_ID,
+        page: 'http://test-url.com'
+      }
+      this.bidRequests[0].params.url = 'https://staging-ssc.33across.com/api/v1/hb';
       this.bidRequests[0].params.test = 1;
 
       const ttxRequest = {
@@ -177,7 +179,8 @@ describe('33acrossBidAdapter:', function () {
           }
         } ],
         site: {
-          id: SITE_ID
+          id: SITE_ID,
+          page: 'http://test-url.com'
         },
         id: 'b1',
         test: 1
@@ -238,7 +241,7 @@ describe('33acrossBidAdapter:', function () {
       expect(interpretResponse({ body: serverResponse })).to.deep.equal([ bidResponse ]);
     });
 
-    it('interprets and returns empty array', function() {
+    it('interprets nbr and returns empty array', function() {
       const serverResponse = {
         cur: 'USD',
         ext: { },
@@ -304,39 +307,45 @@ describe('33acrossBidAdapter:', function () {
     });
   });
 
-  describe('getUserSyncs', function() {
+  describe('getUserSyncs:', function() {
     beforeEach(function() {
-      this.ttxBids = [
-        {
-          params: {
-            siteId: 'id1',
-            productId: 'p1'
-          }
-        },
-        {
-          params: {
-            siteId: 'id2',
-            productId: 'p1'
+      this.bidderRequests = {
+        bids: [
+          {
+            params: {
+              siteId: 'id1',
+              productId: 'p1'
+            }
+          },
+          {
+            params: {
+              siteId: 'id2',
+              productId: 'p1'
+            }
           }
-        }
-      ];
+        ]
+      };
 
-      this.testTTXBids = [
-        {
-          params: {
-            siteId: 'id1',
-            productId: 'p1',
-            test: 1
-          }
-        },
-        {
-          params: {
-            siteId: 'id2',
-            productId: 'p1',
-            test: 1
+      this.testBidderRequests = {
+        bids: [
+          {
+            params: {
+              site: { id: 'id1' },
+              productId: 'p1',
+              syncUrl: 'https://staging-de.tynt.com/deb/v2?m=xch',
+              test: 1
+            }
+          },
+          {
+            params: {
+              site: { id: 'id2' },
+              productId: 'p1',
+              syncUrl: 'https://staging-de.tynt.com/deb/v2?m=xch',
+              test: 1
+            }
           }
-        }
-      ];
+        ]
+      };
 
       this.syncs = [
         {
@@ -352,52 +361,35 @@ describe('33acrossBidAdapter:', function () {
       this.testSyncs = [
         {
           type: 'iframe',
-          url: 'https://de.tynt.com/deb/v2?m=xch&id=id1'
+          url: 'https://staging-de.tynt.com/deb/v2?m=xch&id=id1'
         },
         {
           type: 'iframe',
-          url: 'https://de.tynt.com/deb/v2?m=xch&id=id2'
+          url: 'https://staging-de.tynt.com/deb/v2?m=xch&id=id2'
         },
       ];
-
-      this.getFakeBids = () => (
-        {
-          bids: this.ttxBids
-        }
-      );
-
-      this.getFakeTestBids = () => (
-        {
-          bids: this.testTTXBids
-        }
-      );
     });
 
     it('returns empty sync array when iframe is not enabled', function() {
-      this.sandbox.stub(utils, 'getBidderRequestAllAdUnits', this.getFakeBids);
       const syncOptions = {};
-      expect(getUserSyncs(syncOptions)).to.deep.equal([]);
+      expect(getUserSyncs(syncOptions, this.biddderRequests)).to.deep.equal([]);
     });
 
     it('returns sync array equal to number of bids for ttx when iframe is enabled', function() {
-      this.sandbox.stub(utils, 'getBidderRequestAllAdUnits', this.getFakeBids);
-
       const syncOptions = {
         iframeEnabled: true
       };
-      const syncs = getUserSyncs(syncOptions);
-      expect(syncs.length).to.equal(this.ttxBids.length);
+      const syncs = getUserSyncs(syncOptions, this.bidderRequests);
+      expect(syncs.length).to.equal(this.bidderRequests.bids.length);
       expect(syncs).to.deep.equal(this.syncs);
     });
 
     it('returns sync array equal to number of test bids for ttx when iframe is enabled', function() {
-      this.sandbox.stub(utils, 'getBidderRequestAllAdUnits', this.getFakeTestBids);
-
       const syncOptions = {
         iframeEnabled: true
       };
-      const syncs = getUserSyncs(syncOptions);
-      expect(syncs.length).to.equal(this.testTTXBids.length);
+      const syncs = getUserSyncs(syncOptions, this.testBidderRequests);
+      expect(syncs.length).to.equal(this.testBidderRequests.bids.length);
       expect(syncs).to.deep.equal(this.testSyncs);
     });
   });

From 75b950e0c43c347c27a87158469ae70d8c781c23 Mon Sep 17 00:00:00 2001
From: Aparna Hegde <aparna.hegde@33across.com>
Date: Mon, 26 Feb 2018 12:27:50 -0500
Subject: [PATCH 06/11] Reverted hack to karma conf maker to make unit tests
 pass with --file option

---
 karma.conf.maker.js | 1 -
 1 file changed, 1 deletion(-)

diff --git a/karma.conf.maker.js b/karma.conf.maker.js
index 62e96a1ebd0..6afb5e4cf13 100644
--- a/karma.conf.maker.js
+++ b/karma.conf.maker.js
@@ -123,7 +123,6 @@ module.exports = function(codeCoverage, browserstack, watchMode, file) {
     // preprocess matching files before serving them to the browser
     // available preprocessors: https://npmjs.org/browse/keyword/karma-preprocessor
     preprocessors: {
-      'test/**/*_spec.js': ['webpack', 'sourcemap'],
       'test/test_index.js': ['webpack', 'sourcemap']
     },
 

From d7ea9f1e7822ebd9cb7711078eb888c72c9f420e Mon Sep 17 00:00:00 2001
From: Aparna Hegde <aparna.hegde@33across.com>
Date: Mon, 2 Apr 2018 11:38:54 -0400
Subject: [PATCH 07/11] Enabling POST withCredentials to send userSync cookies

---
 modules/33acrossBidAdapter.js                | 2 +-
 test/spec/modules/33acrossBidAdapter_spec.js | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/modules/33acrossBidAdapter.js b/modules/33acrossBidAdapter.js
index 93fd685ae15..15792240fdd 100644
--- a/modules/33acrossBidAdapter.js
+++ b/modules/33acrossBidAdapter.js
@@ -55,7 +55,7 @@ function _createServerRequest(bidRequest) {
    */
   const options = {
     contentType: 'application/json',
-    withCredentials: false
+    withCredentials: true
   };
   // Allow the ability to configure the HB endpoint for testing purposes.
   const ttxSettings = config.getConfig('ttxSettings');
diff --git a/test/spec/modules/33acrossBidAdapter_spec.js b/test/spec/modules/33acrossBidAdapter_spec.js
index 9c318e4bdd5..ff701d265a7 100644
--- a/test/spec/modules/33acrossBidAdapter_spec.js
+++ b/test/spec/modules/33acrossBidAdapter_spec.js
@@ -146,7 +146,7 @@ describe('33acrossBidAdapter:', function () {
         'data': JSON.stringify(ttxRequest),
         'options': {
           'contentType': 'application/json',
-          'withCredentials': false
+          'withCredentials': true
         }
       }
       const builtServerRequests = buildRequests(this.bidRequests);
@@ -194,7 +194,7 @@ describe('33acrossBidAdapter:', function () {
         data: JSON.stringify(ttxRequest),
         options: {
           contentType: 'application/json',
-          withCredentials: false
+          withCredentials: true
         }
       };
 
@@ -244,7 +244,7 @@ describe('33acrossBidAdapter:', function () {
         data: JSON.stringify(ttxRequest),
         options: {
           contentType: 'application/json',
-          withCredentials: false
+          withCredentials: true
         }
       };
 

From 0206e6930b8ea871d2765e968fe121d524110240 Mon Sep 17 00:00:00 2001
From: Aparna Hegde <aparna.hegde@33across.com>
Date: Wed, 11 Jul 2018 18:00:23 -0400
Subject: [PATCH 08/11] Sync based on unique site id

---
 modules/33acrossBidAdapter.js                | 55 +++++++++---------
 test/spec/modules/33acrossBidAdapter_spec.js | 60 ++++++++++----------
 2 files changed, 59 insertions(+), 56 deletions(-)

diff --git a/modules/33acrossBidAdapter.js b/modules/33acrossBidAdapter.js
index 15792240fdd..682c4730dae 100644
--- a/modules/33acrossBidAdapter.js
+++ b/modules/33acrossBidAdapter.js
@@ -1,7 +1,7 @@
-import { userSync } from 'src/userSync'
+import { userSync } from 'src/userSync';
+import { uniques } from 'src/utils';
 const { registerBidder } = require('../src/adapters/bidderFactory');
 const { config } = require('../src/config');
-
 const BIDDER_CODE = '33across';
 const END_POINT = 'https://ssc.33across.com/api/v1/hb';
 const SYNC_ENDPOINT = 'https://de.tynt.com/deb/v2?m=xch&rt=html';
@@ -70,6 +70,18 @@ function _createServerRequest(bidRequest) {
   }
 }
 
+
+// Sync object will always be of type iframe for ttx
+function _createSync(siteId) {
+  const ttxSettings = config.getConfig('ttxSettings');
+  const syncUrl = (ttxSettings && ttxSettings.syncUrl) || SYNC_ENDPOINT;
+
+  return {
+    type: 'iframe',
+    url: `${syncUrl}&id=${siteId}`
+  }
+}
+
 function _getFormatSize(sizeArr) {
   return {
     w: sizeArr[0],
@@ -78,24 +90,6 @@ function _getFormatSize(sizeArr) {
   }
 }
 
-// Register one sync per bid since each ad unit may potenitally be linked to a uniqe guid
-// Sync type will always be 'iframe' for 33Across
-function _registerUserSyncs(requestData) {
-  let ttxRequest;
-  try {
-    ttxRequest = JSON.parse(requestData);
-  } catch (err) {
-    // No point in trying to register sync since the requisite data cannot be parsed.
-    return;
-  }
-  const ttxSettings = config.getConfig('ttxSettings');
-
-  let syncUrl = (ttxSettings && ttxSettings.syncUrl) || SYNC_ENDPOINT;
-
-  syncUrl = `${syncUrl}&id=${ttxRequest.site.id}`;
-  userSync.registerSync('iframe', BIDDER_CODE, syncUrl);
-}
-
 function isBidRequestValid(bid) {
   if (bid.bidder !== BIDDER_CODE || typeof bid.params === 'undefined') {
     return false;
@@ -110,16 +104,13 @@ function isBidRequestValid(bid) {
 
 // NOTE: At this point, 33exchange only accepts request for a single impression
 function buildRequests(bidRequests) {
+  const siteIds = bidRequests.map(req=> req.params.siteId);
+  config.setConfig({ttxSiteIds: siteIds});
   return bidRequests.map(_createServerRequest);
 }
 
 // NOTE: At this point, the response from 33exchange will only ever contain one bid i.e. the highest bid
 function interpretResponse(serverResponse, bidRequest) {
-  // Register user sync first
-  if (bidRequest && bidRequest.data) {
-    _registerUserSyncs(bidRequest.data);
-  }
-
   const bidResponses = [];
 
   // If there are bids, look at the first bid of the first seatbid (see NOTE above for assumption about ttx)
@@ -130,11 +121,23 @@ function interpretResponse(serverResponse, bidRequest) {
   return bidResponses;
 }
 
+// Register one sync per unique guid
+function getUserSyncs(syncOptions) {
+  let syncs = [];
+  const uniqueSiteIds = config.getConfig('ttxSiteIds').filter(uniques);
+  if (syncOptions.iframeEnabled) {
+    syncs = uniqueSiteIds.map(_createSync);
+  }
+
+  return syncs;
+}
+
 const spec = {
   code: BIDDER_CODE,
   isBidRequestValid,
   buildRequests,
-  interpretResponse
+  interpretResponse,
+  getUserSyncs
 }
 
 registerBidder(spec);
diff --git a/test/spec/modules/33acrossBidAdapter_spec.js b/test/spec/modules/33acrossBidAdapter_spec.js
index ff701d265a7..cde67700b69 100644
--- a/test/spec/modules/33acrossBidAdapter_spec.js
+++ b/test/spec/modules/33acrossBidAdapter_spec.js
@@ -404,43 +404,43 @@ describe('33acrossBidAdapter:', function () {
         expect(interpretResponse({ body: serverResponse }, this.serverRequest)).to.deep.equal([ bidResponse ]);
       });
     });
+  });
 
-    context('and register user sync', function() {
-      it('via the production endpoint', function() {
-        const spy = this.sandbox.spy(userSync, 'registerSync');
-        const serverResponse = {
-          cur: 'USD',
-          ext: {},
-          id: 'b1',
-          seatbid: []
-        }
-        interpretResponse({ body: serverResponse }, this.serverRequest);
-        const syncUrl = `${SYNC_ENDPOINT}&id=${this.ttxRequest.site.id}`;
+  describe('getUserSyncs', function() {
+    beforeEach(function() {
+      this.syncs = [
+        {
+          type: 'iframe',
+          url: 'https://de.tynt.com/deb/v2?m=xch&rt=html&id=id1'
+        },
+        {
+          type: 'iframe',
+          url: 'https://de.tynt.com/deb/v2?m=xch&rt=html&id=id2'
+        },
+      ];
+    });
 
-        const registerSyncCalled = spy.calledWith('iframe', '33across', syncUrl);
-        expect(registerSyncCalled).to.be.true;
+    context('when iframe is not enabled', function() {
+      it('returns empty sync array', function() {
+        this.sandbox.stub(config, 'getConfig').callsFake(() => {
+          return  ['id1', 'id1', 'id2'];
+        });
+        const syncOptions = {};
+        expect(getUserSyncs(syncOptions)).to.deep.equal([]);
       });
+    });
 
-      it('via the test endpoint', function() {
-        const spy = this.sandbox.spy(userSync, 'registerSync');
-
+    context('when iframe is enabled', function() {
+      it('returns sync array equal to number of unique siteIDs', function() {
         this.sandbox.stub(config, 'getConfig').callsFake(() => {
-          return {
-            'syncUrl': 'https://foo.com/deb/v2?m=xch'
-          }
+          return  ['id1', 'id1', 'id2'];
         });
 
-        const serverResponse = {
-          cur: 'USD',
-          ext: {},
-          id: 'b1',
-          seatbid: []
-        }
-        interpretResponse({ body: serverResponse }, this.serverRequest);
-        const syncUrl = `https://foo.com/deb/v2?m=xch&id=${this.ttxRequest.site.id}`;
-
-        const registerSyncCalled = spy.calledWith('iframe', '33across', syncUrl);
-        expect(registerSyncCalled).to.be.true;
+        const syncOptions = {
+          iframeEnabled: true
+        };
+        const syncs = getUserSyncs(syncOptions);
+        expect(syncs).to.deep.equal(this.syncs);
       });
     });
   });

From d711c7c76e4cea8a16eca34ca5db18973202a65f Mon Sep 17 00:00:00 2001
From: Aparna Hegde <aparna.hegde@33across.com>
Date: Wed, 18 Jul 2018 15:22:07 -0400
Subject: [PATCH 09/11] Store siteID's in module level object instead of config

---
 modules/33acrossBidAdapter.js                | 22 +++++------
 test/spec/modules/33acrossBidAdapter_spec.js | 41 ++++++++++++++++----
 2 files changed, 43 insertions(+), 20 deletions(-)

diff --git a/modules/33acrossBidAdapter.js b/modules/33acrossBidAdapter.js
index 682c4730dae..e6689d0c26d 100644
--- a/modules/33acrossBidAdapter.js
+++ b/modules/33acrossBidAdapter.js
@@ -1,4 +1,3 @@
-import { userSync } from 'src/userSync';
 import { uniques } from 'src/utils';
 const { registerBidder } = require('../src/adapters/bidderFactory');
 const { config } = require('../src/config');
@@ -6,6 +5,8 @@ const BIDDER_CODE = '33across';
 const END_POINT = 'https://ssc.33across.com/api/v1/hb';
 const SYNC_ENDPOINT = 'https://de.tynt.com/deb/v2?m=xch&rt=html';
 
+const adapterState = {};
+
 // All this assumes that only one bid is ever returned by ttx
 function _createBidResponse(response) {
   return {
@@ -42,9 +43,11 @@ function _createServerRequest(bidRequest) {
     }
   }
   ttxRequest.site = { id: params.siteId };
+
   // Go ahead send the bidId in request to 33exchange so it's kept track of in the bid response and
   // therefore in ad targetting process
   ttxRequest.id = bidRequest.bidId;
+
   // Finally, set the openRTB 'test' param if this is to be a test bid
   if (params.test === 1) {
     ttxRequest.test = 1;
@@ -70,8 +73,7 @@ function _createServerRequest(bidRequest) {
   }
 }
 
-
-// Sync object will always be of type iframe for ttx
+// Sync object will always be of type iframe for TTX
 function _createSync(siteId) {
   const ttxSettings = config.getConfig('ttxSettings');
   const syncUrl = (ttxSettings && ttxSettings.syncUrl) || SYNC_ENDPOINT;
@@ -102,10 +104,10 @@ function isBidRequestValid(bid) {
   return true;
 }
 
-// NOTE: At this point, 33exchange only accepts request for a single impression
+// NOTE: At this point, TTX only accepts request for a single impression
 function buildRequests(bidRequests) {
-  const siteIds = bidRequests.map(req=> req.params.siteId);
-  config.setConfig({ttxSiteIds: siteIds});
+  adapterState.uniqueSiteIds = bidRequests.map(req => req.params.siteId).filter(uniques);
+
   return bidRequests.map(_createServerRequest);
 }
 
@@ -123,13 +125,7 @@ function interpretResponse(serverResponse, bidRequest) {
 
 // Register one sync per unique guid
 function getUserSyncs(syncOptions) {
-  let syncs = [];
-  const uniqueSiteIds = config.getConfig('ttxSiteIds').filter(uniques);
-  if (syncOptions.iframeEnabled) {
-    syncs = uniqueSiteIds.map(_createSync);
-  }
-
-  return syncs;
+  return (syncOptions.iframeEnabled) ? adapterState.uniqueSiteIds.map(_createSync) : ([]);
 }
 
 const spec = {
diff --git a/test/spec/modules/33acrossBidAdapter_spec.js b/test/spec/modules/33acrossBidAdapter_spec.js
index cde67700b69..c8f917cc1e5 100644
--- a/test/spec/modules/33acrossBidAdapter_spec.js
+++ b/test/spec/modules/33acrossBidAdapter_spec.js
@@ -418,27 +418,54 @@ describe('33acrossBidAdapter:', function () {
           url: 'https://de.tynt.com/deb/v2?m=xch&rt=html&id=id2'
         },
       ];
+      this.bidRequests = [
+        {
+          bidId: 'b1',
+          bidder: '33across',
+          bidderRequestId: 'b1a',
+          params: {
+            siteId: 'id1',
+            productId: 'foo'
+          },
+          adUnitCode: 'div-id',
+          auctionId: 'r1',
+          sizes: [
+            [ 300, 250 ]
+          ],
+          transactionId: 't1'
+        },
+        {
+          bidId: 'b2',
+          bidder: '33across',
+          bidderRequestId: 'b2a',
+          params: {
+            siteId: 'id2',
+            productId: 'foo'
+          },
+          adUnitCode: 'div-id',
+          auctionId: 'r1',
+          sizes: [
+            [ 300, 250 ]
+          ],
+          transactionId: 't2'
+        }
+      ];
     });
 
     context('when iframe is not enabled', function() {
       it('returns empty sync array', function() {
-        this.sandbox.stub(config, 'getConfig').callsFake(() => {
-          return  ['id1', 'id1', 'id2'];
-        });
         const syncOptions = {};
+        buildRequests(this.bidRequests);
         expect(getUserSyncs(syncOptions)).to.deep.equal([]);
       });
     });
 
     context('when iframe is enabled', function() {
       it('returns sync array equal to number of unique siteIDs', function() {
-        this.sandbox.stub(config, 'getConfig').callsFake(() => {
-          return  ['id1', 'id1', 'id2'];
-        });
-
         const syncOptions = {
           iframeEnabled: true
         };
+        buildRequests(this.bidRequests);
         const syncs = getUserSyncs(syncOptions);
         expect(syncs).to.deep.equal(this.syncs);
       });

From 2ef88610bdbad35a10bb635c34432b141c0e2e13 Mon Sep 17 00:00:00 2001
From: Aparna Hegde <aparna.hegde@33across.com>
Date: Tue, 24 Jul 2018 14:15:37 -0400
Subject: [PATCH 10/11] Eliminate preflight. Remove test setup in docs

---
 modules/33acrossBidAdapter.js                |  4 +-
 modules/33acrossBidAdapter.md                | 67 +-------------------
 test/spec/modules/33acrossBidAdapter_spec.js |  8 +--
 3 files changed, 8 insertions(+), 71 deletions(-)

diff --git a/modules/33acrossBidAdapter.js b/modules/33acrossBidAdapter.js
index e6689d0c26d..7b26f66331f 100644
--- a/modules/33acrossBidAdapter.js
+++ b/modules/33acrossBidAdapter.js
@@ -54,10 +54,10 @@ function _createServerRequest(bidRequest) {
   }
 
   /*
-   * Now construt the full server request
+   * Now construct the full server request
    */
   const options = {
-    contentType: 'application/json',
+    contentType: 'text/plain',
     withCredentials: true
   };
   // Allow the ability to configure the HB endpoint for testing purposes.
diff --git a/modules/33acrossBidAdapter.md b/modules/33acrossBidAdapter.md
index c4eb319c157..cfc02b08221 100644
--- a/modules/33acrossBidAdapter.md
+++ b/modules/33acrossBidAdapter.md
@@ -24,72 +24,9 @@ var adUnits = [
     bids: [{
         bidder: '33across',
         params: {
-            siteId: 'pub1234',     
-            productId: 'infeed'     
+            siteId: 'examplePub1234',     
+            productId: 'siab'     
         }
     }]
 }
 ```
-
-# Ad Unit and Setup: For Testing
-In order to receive bids please map localhost to (any) test domain.
-
-```
-<--! Prebid Config section >
-<script> 
-    var PREBID_TIMEOUT = 3000;
-    var adUnits = [
-    {
-        code: '33across-hb-ad-123456-1',
-        sizes: [
-            [300, 250], 
-            [728, 90]
-        ],     
-        bids: [{
-            bidder: '33across',
-            params: {
-            site: {
-                id: 'aRlI5W_9yr5jkxacwqm_6r',
-                page: "http://thinkbabynames.com/baby-mcbabyface",
-                ext: {
-                    ttx: {
-                        ssp_configs: [
-                            {
-                            "name": "index",
-                            "enabled": false
-                            },
-                            {
-                            "name": "rubicon",
-                            "enabled": true
-                            },
-                            {
-                            "name": "33xchange",
-                            "enabled": false
-                            }
-                        ]
-                    }
-                }
-            },
-            productId: 'infeed'
-        }
-        }]
-    }
-    ];
-    
-    var pbjs = pbjs || {};
-    pbjs.que = pbjs.que || [];
-
-    // Adjust bid CPM to ensure it wins the auction (USED ONLY FOR TESTING). Need to do this since test bids have too low a CPM
-    pbjs.bidderSettings = {
-      '33across': {
-        bidCpmAdjustment : function(bidCpm, bid){
-          // adjust the bid in real time before the auction takes place, only do so for valid bids ignore no bids
-          if (bid.w !== 0 && bid.h !== 0 && bidCpm !== 0) {
-            return bidCpm + 0.50;
-          }
-        }
-      }
-    };
-  </script>
-  <!-- End Prebid Config section>
-  ```
\ No newline at end of file
diff --git a/test/spec/modules/33acrossBidAdapter_spec.js b/test/spec/modules/33acrossBidAdapter_spec.js
index c8f917cc1e5..8ca2f3da902 100644
--- a/test/spec/modules/33acrossBidAdapter_spec.js
+++ b/test/spec/modules/33acrossBidAdapter_spec.js
@@ -145,7 +145,7 @@ describe('33acrossBidAdapter:', function () {
         'url': END_POINT,
         'data': JSON.stringify(ttxRequest),
         'options': {
-          'contentType': 'application/json',
+          'contentType': 'text/plain',
           'withCredentials': true
         }
       }
@@ -193,7 +193,7 @@ describe('33acrossBidAdapter:', function () {
         url: 'https://foo.com/hb/',
         data: JSON.stringify(ttxRequest),
         options: {
-          contentType: 'application/json',
+          contentType: 'text/plain',
           withCredentials: true
         }
       };
@@ -243,7 +243,7 @@ describe('33acrossBidAdapter:', function () {
         url: 'https://foo.com/hb/',
         data: JSON.stringify(ttxRequest),
         options: {
-          contentType: 'application/json',
+          contentType: 'text/plain',
           withCredentials: true
         }
       };
@@ -293,7 +293,7 @@ describe('33acrossBidAdapter:', function () {
         url: '//staging-ssc.33across.com/api/v1/hb',
         data: JSON.stringify(this.ttxRequest),
         options: {
-          contentType: 'application/json',
+          contentType: 'text/plain',
           withCredentials: false
         }
       };

From 8ee6949e820e38aacff3c63d0a31785d88156271 Mon Sep 17 00:00:00 2001
From: Aparna Hegde <aparna.hegde@33across.com>
Date: Thu, 26 Jul 2018 10:21:28 -0400
Subject: [PATCH 11/11] Added alias for contact mailing list

---
 modules/33acrossBidAdapter.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/modules/33acrossBidAdapter.md b/modules/33acrossBidAdapter.md
index cfc02b08221..bdb2b944861 100644
--- a/modules/33acrossBidAdapter.md
+++ b/modules/33acrossBidAdapter.md
@@ -3,7 +3,7 @@
 ```
 Module Name:  33Across Bid Adapter
 Module Type:  Bidder Adapter
-Maintainer: aparna.hegde@33across.com
+Maintainer: headerbidding@33across.com
 ```
 
 # Description