From 1a1eb24b94dfad5cb990d768bf7e25f9c2718eaa Mon Sep 17 00:00:00 2001 From: Matt Kendall <1870166+mkendall07@users.noreply.github.com> Date: Tue, 9 Oct 2018 15:48:58 -0400 Subject: [PATCH 1/4] Revert "Small bugfix and cleanup for Prebid Server OpenRTB code (#3113)" This reverts commit a1f07e95e8637ef2b02222db3b852e4f59d2e5c6. From 30e7460e9f2b85e7b12171a7cbb7e94bb2377a1d Mon Sep 17 00:00:00 2001 From: Matt Kendall <1870166+mkendall07@users.noreply.github.com> Date: Tue, 9 Oct 2018 15:48:58 -0400 Subject: [PATCH 2/4] Revert "Added support for user syncing pixel (#3092)" This reverts commit 8fdf61da6acd70792bf81a7a3f94d6fa4f0a2c20. From 7c87edefb2a84dbe566116c7bb3074f2049dea48 Mon Sep 17 00:00:00 2001 From: Matt Kendall <1870166+mkendall07@users.noreply.github.com> Date: Tue, 9 Oct 2018 15:48:58 -0400 Subject: [PATCH 3/4] Revert "Add RSA validation to Criteo FastBid (#3110)" This reverts commit e72e2dc1754c090b07922dafe61dd61cd6478be4. From 487f4631cd45c08f9dfa24d583509765422ab5c9 Mon Sep 17 00:00:00 2001 From: Matt Kendall <1870166+mkendall07@users.noreply.github.com> Date: Tue, 9 Oct 2018 15:48:58 -0400 Subject: [PATCH 4/4] Revert "Adding appnexus debug via cookie/params (#3152)" This reverts commit 4797ea2953612e915d9119ffa00393f7d417b5a3. --- modules/appnexusBidAdapter.js | 57 -------------------- test/spec/modules/appnexusBidAdapter_spec.js | 28 +--------- 2 files changed, 1 insertion(+), 84 deletions(-) diff --git a/modules/appnexusBidAdapter.js b/modules/appnexusBidAdapter.js index f65a3409684..aaec207dc1e 100644 --- a/modules/appnexusBidAdapter.js +++ b/modules/appnexusBidAdapter.js @@ -11,7 +11,6 @@ const VIDEO_TARGETING = ['id', 'mimes', 'minduration', 'maxduration', 'startdelay', 'skippable', 'playback_method', 'frameworks']; const USER_PARAMS = ['age', 'external_uid', 'segments', 'gender', 'dnt', 'language']; const APP_DEVICE_PARAMS = ['geo', 'device_id']; // appid is collected separately -const DEBUG_PARAMS = ['enabled', 'dongle', 'member_id', 'debug_timeout']; const NATIVE_MAPPING = { body: 'description', cta: 'ctatext', @@ -78,32 +77,6 @@ export const spec = { }; } - let debugObj = {}; - let debugObjParams = {}; - const debugCookieName = 'apn_prebid_debug'; - const debugCookie = getCookie(debugCookieName) || null; - - if (debugCookie) { - try { - debugObj = JSON.parse(debugCookie); - } catch (e) { - utils.logError('AppNexus Debug Auction Cookie Error:\n\n' + e); - } - } else { - const debugBidRequest = find(bidRequests, hasDebug); - if (debugBidRequest && debugBidRequest.debug) { - debugObj = debugBidRequest.debug; - } - } - - if (debugObj && debugObj.enabled) { - Object.keys(debugObj) - .filter(param => includes(DEBUG_PARAMS, param)) - .forEach(param => { - debugObjParams[param] = debugObj[param]; - }); - } - const memberIdBid = find(bidRequests, hasMemberId); const member = memberIdBid ? parseInt(memberIdBid.params.member, 10) : 0; @@ -126,11 +99,6 @@ export const spec = { payload.app = appIdObj; } - if (debugObjParams.enabled) { - payload.debug = debugObjParams; - utils.logInfo('AppNexus Debug Auction Settings:\n\n' + JSON.stringify(debugObjParams, null, 4)); - } - if (bidderRequest && bidderRequest.gdprConsent) { // note - objects for impbus use underscore instead of camelCase payload.gdpr_consent = { @@ -186,22 +154,6 @@ export const spec = { } }); } - - if (serverResponse.debug && serverResponse.debug.debug_info) { - let debugHeader = 'AppNexus Debug Auction for Prebid\n\n'; - let debugText = debugHeader + serverResponse.debug.debug_info; - debugText = debugText - .replace(/(|)/gm, '\t') // Tables - .replace(/(<\/td>|<\/th>)/gm, '\n') // Tables - .replace(/^
/gm, '') // Remove leading
- .replace(/(
\n|
)/gm, '\n') //
- .replace(/

(.*)<\/h1>/gm, '\n\n===== $1 =====\n\n') // Header H1 - .replace(/(.*)<\/h[2-6]>/gm, '\n\n*** $1 ***\n\n') // Headers - .replace(/(<([^>]+)>)/igm, ''); // Remove any other tags - utils.logMessage('AppNexus Debug Auction Glossary: https://wiki.appnexus.com/x/qwmHAg'); - utils.logMessage(debugText); - } - return bids; }, @@ -477,15 +429,6 @@ function hasAppId(bid) { return !!bid.params.app } -function hasDebug(bid) { - return !!bid.debug -} - -function getCookie(name) { - let m = window.document.cookie.match('(^|;)\\s*' + name + '\\s*=\\s*([^;]*)\\s*(;|$)'); - return m ? decodeURIComponent(m[2]) : null; -} - function getRtbBid(tag) { return tag && tag.ads && tag.ads.length && find(tag.ads, ad => ad.rtb); } diff --git a/test/spec/modules/appnexusBidAdapter_spec.js b/test/spec/modules/appnexusBidAdapter_spec.js index 0d7c670ee8a..9be87ac8628 100644 --- a/test/spec/modules/appnexusBidAdapter_spec.js +++ b/test/spec/modules/appnexusBidAdapter_spec.js @@ -396,33 +396,7 @@ describe('AppNexusAdapter', function () { rd_stk: bidderRequest.refererInfo.stack.map((url) => encodeURIComponent(url)).join(',') }); }); - - it('adds debug auction settings to payload', () => { - let debugRequest = Object.assign({}, - bidRequests[0], - { - params: { - placementId: '10433394' - }, - debug: { - enabled: true, - dongle: 'QWERTY', - member_id: 958, - debug_timeout: 1000 - } - } - ); - const request = spec.buildRequests([debugRequest]); - const payload = JSON.parse(request.data); - expect(payload.debug).to.exist; - expect(payload.debug).to.deep.equal({ - enabled: true, - dongle: 'QWERTY', - member_id: 958, - debug_timeout: 1000 - }); - }); - }); + }) describe('interpretResponse', function () { let response = {