-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restrict outstream w/o renderer to PBS #3881
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I setup an outstream video bid and sent it to PBS, the ORTB request still went out and returned with a 400 Bad Request
response because of the following error:
Invalid request: request.imp[0] must contain at least one of "banner", "video", "audio", or "native"
If there are no other valid bids to make, then the request shouldn't go out and prebid should return some type of error message indicating that the request for that adunit was rejected.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@jsnellbaker ,
So, now the
Can you please review this PR now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sumit116 I think these updates look good.
Can you put together a docs PR for the updated sample adUnit render code (for when serving from PBS)? The additions would be helpful to note down.
Thanks @jsnellbaker . Docs PR added: prebid/prebid.github.io#1385. |
how do you get this "renderer" thing to work with multi boxes? the docs are non existant and the examples dont show how to do it? |
@jsnellbaker , do you have any idea about this? |
@spormeon Can you please clarify a little further on what you mean? |
how do you get a renderer to work with "multi boxes" it just doesnt seem to work? |
@spormeon Do you have a page setup where you're trying to get this to work that I can see? I don't understand the term 'multi boxes' in this context. Do you mean just having multiple outstream video placements serving together? |
prebid "multi-format" my test pages are behind login, so unless i can Pm you its hard to give you it no mention of a 'renderer" anywhere or how to add one and throw in some bidders being S2S and got a mess, with no docs or info on how to do it? |
* restrict outstream w/o renderer to PBS * reject Request to Prebid Server for invalid media types * add player height and width to response
* restrict outstream w/o renderer to PBS * reject Request to Prebid Server for invalid media types * add player height and width to response
* restrict outstream w/o renderer to PBS * reject Request to Prebid Server for invalid media types * add player height and width to response
Type of change
Description of change
Be sure to test the integration with your adserver using the Hello World sample page.