From 1274a28575df2aa6e33b4e7053de5234754376e0 Mon Sep 17 00:00:00 2001 From: robertrmartinez Date: Thu, 14 Oct 2021 10:55:48 -0700 Subject: [PATCH 1/8] sourceTid --- modules/prebidServerBidAdapter/index.js | 2 +- src/adapterManager.js | 19 ++++++++++++------- test/spec/unit/core/adapterManager_spec.js | 8 ++++---- 3 files changed, 17 insertions(+), 12 deletions(-) diff --git a/modules/prebidServerBidAdapter/index.js b/modules/prebidServerBidAdapter/index.js index 245cb7fc0b0..af25d8afa4c 100644 --- a/modules/prebidServerBidAdapter/index.js +++ b/modules/prebidServerBidAdapter/index.js @@ -731,7 +731,7 @@ const OPEN_RTB_PROTOCOL = { return; } const request = { - id: s2sBidRequest.tid, + id: firstBidRequest.auctionId, source: {tid: s2sBidRequest.tid}, tmax: s2sConfig.timeout, imp: imps, diff --git a/src/adapterManager.js b/src/adapterManager.js index 9a3d05a4321..e9c4c4de9b3 100644 --- a/src/adapterManager.js +++ b/src/adapterManager.js @@ -262,14 +262,16 @@ adapterManager.makeBidRequests = hook('sync', function (adUnits, auctionStart, a } let adUnitsS2SCopy = getAdUnitCopyForPrebidServer(adUnits, s2sConfig); - let tid = generateUUID(); + + // uniqueServerId is so we know which server to send which bids to during the callBids function + let uniqueServerId = generateUUID(); adaptersServerSide.forEach(bidderCode => { const bidderRequestId = getUniqueIdentifierStr(); const bidderRequest = { bidderCode, auctionId, bidderRequestId, - tid, + uniqueServerId, bids: hookedGetBids({bidderCode, auctionId, bidderRequestId, 'adUnits': deepClone(adUnitsS2SCopy), labels, src: CONSTANTS.S2S.SRC}), auctionStart: auctionStart, timeout: s2sConfig.timeout, @@ -350,7 +352,7 @@ adapterManager.callBids = (adUnits, bidRequests, addBidResponse, doneCb, request serverBidRequests.forEach(serverBidRequest => { var index = -1; for (var i = 0; i < uniqueServerBidRequests.length; ++i) { - if (serverBidRequest.tid === uniqueServerBidRequests[i].tid) { + if (serverBidRequest.uniqueServerId === uniqueServerBidRequests[i].uniqueServerId) { index = i; break; } @@ -360,7 +362,10 @@ adapterManager.callBids = (adUnits, bidRequests, addBidResponse, doneCb, request } }); - let counter = 0 + let counter = 0; + + // $.source.tid MUST be a unique UUID and also THE SAME between all PBS Requests for a given Auction + const sourceTid = generateUUID(); _s2sConfigs.forEach((s2sConfig) => { if (s2sConfig && uniqueServerBidRequests[counter] && includes(s2sConfig.bidders, uniqueServerBidRequests[counter].bidderCode)) { // s2s should get the same client side timeout as other client side requests. @@ -370,13 +375,13 @@ adapterManager.callBids = (adUnits, bidRequests, addBidResponse, doneCb, request } : undefined); let adaptersServerSide = s2sConfig.bidders; const s2sAdapter = _bidderRegistry[s2sConfig.adapter]; - let tid = uniqueServerBidRequests[counter].tid; + let uniqueServerId = uniqueServerBidRequests[counter].uniqueServerId; let adUnitsS2SCopy = uniqueServerBidRequests[counter].adUnitsS2SCopy; - let uniqueServerRequests = serverBidRequests.filter(serverBidRequest => serverBidRequest.tid === tid) + let uniqueServerRequests = serverBidRequests.filter(serverBidRequest => serverBidRequest.uniqueServerId === uniqueServerId); if (s2sAdapter) { - let s2sBidRequest = {tid, 'ad_units': adUnitsS2SCopy, s2sConfig}; + let s2sBidRequest = {tid: sourceTid, 'ad_units': adUnitsS2SCopy, s2sConfig}; if (s2sBidRequest.ad_units.length) { let doneCbs = uniqueServerRequests.map(bidRequest => { bidRequest.start = timestamp(); diff --git a/test/spec/unit/core/adapterManager_spec.js b/test/spec/unit/core/adapterManager_spec.js index f33c9139e5f..eecf1b00b7d 100644 --- a/test/spec/unit/core/adapterManager_spec.js +++ b/test/spec/unit/core/adapterManager_spec.js @@ -162,7 +162,7 @@ describe('adapterManager tests', function () { 'bidderCode': 'appnexus', 'auctionId': '1863e370099523', 'bidderRequestId': '2946b569352ef2', - 'tid': '34566b569352ef2', + 'uniqueServerId': '34566b569352ef2', 'bids': [ { 'bidder': 'appnexus', @@ -447,7 +447,7 @@ describe('adapterManager tests', function () { 'bidderCode': 'appnexus', 'auctionId': '1863e370099523', 'bidderRequestId': '2946b569352ef2', - 'tid': '34566b569352ef2', + 'uniqueServerId': '34566b569352ef2', 'timeout': 1000, 'src': 's2s', 'adUnitsS2SCopy': [ @@ -676,7 +676,7 @@ describe('adapterManager tests', function () { 'bidderCode': 'appnexus', 'auctionId': '1863e370099523', 'bidderRequestId': '2946b569352ef2', - 'tid': '34566b569352ef2', + 'uniqueServerId': '34566b569352ef2', 'timeout': 1000, 'src': 's2s', 'adUnitsS2SCopy': [ @@ -812,7 +812,7 @@ describe('adapterManager tests', function () { 'bidderCode': 'pubmatic', 'auctionId': '1863e370099523', 'bidderRequestId': '2946b569352ef2', - 'tid': '2342342342lfi23', + 'uniqueServerId': '2342342342lfi23', 'timeout': 1000, 'src': 's2s', 'adUnitsS2SCopy': [ From 975bdc16a348e0a2e621e7b0c39b07fded1cba08 Mon Sep 17 00:00:00 2001 From: robertrmartinez Date: Thu, 14 Oct 2021 11:43:53 -0700 Subject: [PATCH 2/8] revert unique to tid cuz easier --- src/adapterManager.js | 12 ++++++------ test/spec/unit/core/adapterManager_spec.js | 8 ++++---- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/adapterManager.js b/src/adapterManager.js index e9c4c4de9b3..400324eb71a 100644 --- a/src/adapterManager.js +++ b/src/adapterManager.js @@ -263,15 +263,15 @@ adapterManager.makeBidRequests = hook('sync', function (adUnits, auctionStart, a let adUnitsS2SCopy = getAdUnitCopyForPrebidServer(adUnits, s2sConfig); - // uniqueServerId is so we know which server to send which bids to during the callBids function - let uniqueServerId = generateUUID(); + // tid is so we know which server to send which bids to during the callBids function + let tid = generateUUID(); adaptersServerSide.forEach(bidderCode => { const bidderRequestId = getUniqueIdentifierStr(); const bidderRequest = { bidderCode, auctionId, bidderRequestId, - uniqueServerId, + tid, bids: hookedGetBids({bidderCode, auctionId, bidderRequestId, 'adUnits': deepClone(adUnitsS2SCopy), labels, src: CONSTANTS.S2S.SRC}), auctionStart: auctionStart, timeout: s2sConfig.timeout, @@ -352,7 +352,7 @@ adapterManager.callBids = (adUnits, bidRequests, addBidResponse, doneCb, request serverBidRequests.forEach(serverBidRequest => { var index = -1; for (var i = 0; i < uniqueServerBidRequests.length; ++i) { - if (serverBidRequest.uniqueServerId === uniqueServerBidRequests[i].uniqueServerId) { + if (serverBidRequest.tid === uniqueServerBidRequests[i].tid) { index = i; break; } @@ -375,10 +375,10 @@ adapterManager.callBids = (adUnits, bidRequests, addBidResponse, doneCb, request } : undefined); let adaptersServerSide = s2sConfig.bidders; const s2sAdapter = _bidderRegistry[s2sConfig.adapter]; - let uniqueServerId = uniqueServerBidRequests[counter].uniqueServerId; + let tid = uniqueServerBidRequests[counter].tid; let adUnitsS2SCopy = uniqueServerBidRequests[counter].adUnitsS2SCopy; - let uniqueServerRequests = serverBidRequests.filter(serverBidRequest => serverBidRequest.uniqueServerId === uniqueServerId); + let uniqueServerRequests = serverBidRequests.filter(serverBidRequest => serverBidRequest.tid === tid); if (s2sAdapter) { let s2sBidRequest = {tid: sourceTid, 'ad_units': adUnitsS2SCopy, s2sConfig}; diff --git a/test/spec/unit/core/adapterManager_spec.js b/test/spec/unit/core/adapterManager_spec.js index eecf1b00b7d..f33c9139e5f 100644 --- a/test/spec/unit/core/adapterManager_spec.js +++ b/test/spec/unit/core/adapterManager_spec.js @@ -162,7 +162,7 @@ describe('adapterManager tests', function () { 'bidderCode': 'appnexus', 'auctionId': '1863e370099523', 'bidderRequestId': '2946b569352ef2', - 'uniqueServerId': '34566b569352ef2', + 'tid': '34566b569352ef2', 'bids': [ { 'bidder': 'appnexus', @@ -447,7 +447,7 @@ describe('adapterManager tests', function () { 'bidderCode': 'appnexus', 'auctionId': '1863e370099523', 'bidderRequestId': '2946b569352ef2', - 'uniqueServerId': '34566b569352ef2', + 'tid': '34566b569352ef2', 'timeout': 1000, 'src': 's2s', 'adUnitsS2SCopy': [ @@ -676,7 +676,7 @@ describe('adapterManager tests', function () { 'bidderCode': 'appnexus', 'auctionId': '1863e370099523', 'bidderRequestId': '2946b569352ef2', - 'uniqueServerId': '34566b569352ef2', + 'tid': '34566b569352ef2', 'timeout': 1000, 'src': 's2s', 'adUnitsS2SCopy': [ @@ -812,7 +812,7 @@ describe('adapterManager tests', function () { 'bidderCode': 'pubmatic', 'auctionId': '1863e370099523', 'bidderRequestId': '2946b569352ef2', - 'uniqueServerId': '2342342342lfi23', + 'tid': '2342342342lfi23', 'timeout': 1000, 'src': 's2s', 'adUnitsS2SCopy': [ From 5e428fff7498f6b73b6dd08ca7dde35233e3afd2 Mon Sep 17 00:00:00 2001 From: robertrmartinez Date: Thu, 14 Oct 2021 12:43:11 -0700 Subject: [PATCH 3/8] deep merge extprebid --- modules/prebidServerBidAdapter/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/prebidServerBidAdapter/index.js b/modules/prebidServerBidAdapter/index.js index 6167644b1bc..2fb221a0286 100644 --- a/modules/prebidServerBidAdapter/index.js +++ b/modules/prebidServerBidAdapter/index.js @@ -761,7 +761,7 @@ const OPEN_RTB_PROTOCOL = { // s2sConfig video.ext.prebid is passed through openrtb to PBS if (s2sConfig.extPrebid && typeof s2sConfig.extPrebid === 'object') { - request.ext.prebid = Object.assign(request.ext.prebid, s2sConfig.extPrebid); + request.ext.prebid = mergeDeep(request.ext.prebid, s2sConfig.extPrebid); } /** From 65bb7499f872fcdfd187edfb89e8cd3124ce6b99 Mon Sep 17 00:00:00 2001 From: robertrmartinez Date: Thu, 14 Oct 2021 13:14:58 -0700 Subject: [PATCH 4/8] add tests for changes --- modules/prebidServerBidAdapter/index.js | 2 +- .../modules/prebidServerBidAdapter_spec.js | 21 +++++++++++++++-- test/spec/unit/core/adapterManager_spec.js | 23 ++++++++++++++++++- 3 files changed, 42 insertions(+), 4 deletions(-) diff --git a/modules/prebidServerBidAdapter/index.js b/modules/prebidServerBidAdapter/index.js index 2fb221a0286..b5cd0232187 100644 --- a/modules/prebidServerBidAdapter/index.js +++ b/modules/prebidServerBidAdapter/index.js @@ -751,7 +751,7 @@ const OPEN_RTB_PROTOCOL = { } }; - // Sets pbjs version, can be overwritten below if channel exists in s2sConfig.extPrebid + // This is no longer overwritten unless name and version explicitly overwritten by extPrebid (mergeDeep) request.ext.prebid = Object.assign(request.ext.prebid, {channel: {name: 'pbjs', version: $$PREBID_GLOBAL$$.version}}) // set debug flag if in debug mode diff --git a/test/spec/modules/prebidServerBidAdapter_spec.js b/test/spec/modules/prebidServerBidAdapter_spec.js index a06d4dbcd68..be07e1dcc93 100644 --- a/test/spec/modules/prebidServerBidAdapter_spec.js +++ b/test/spec/modules/prebidServerBidAdapter_spec.js @@ -507,6 +507,17 @@ describe('S2S Adapter', function () { resetSyncedStatus(); }); + it('should set id to auction ID and source.tid to tid', function () { + config.setConfig({ s2sConfig: CONFIG }); + + adapter.callBids(OUTSTREAM_VIDEO_REQUEST, BID_REQUESTS, addBidResponse, done, ajax); + + const requestBid = JSON.parse(server.requests[0].requestBody); + expect(requestBid.id).to.equal('173afb6d132ba3'); + expect(requestBid.source).to.be.an('object'); + expect(requestBid.source.tid).to.equal('437fbbf5-33f5-487a-8e16-a7112903cfe5'); + }); + it('should block request if config did not define p1Consent URL in endpoint object config', function() { let badConfig = utils.deepClone(CONFIG); badConfig.endpoint = { noP1Consent: 'https://prebid.adnxs.com/pbs/v1/openrtb2/auction' }; @@ -1705,7 +1716,7 @@ describe('S2S Adapter', function () { expect(parsedRequestBody.ext.prebid.channel).to.deep.equal({name: 'pbjs', version: 'v$prebid.version$'}); }); - it('does not set pbjs version in request if channel does exist in s2sConfig', () => { + it('extPrebid is now mergedDeep -> should include default channel as well', () => { const s2sBidRequest = utils.deepClone(REQUEST); const bidRequests = utils.deepClone(BID_REQUESTS); @@ -1714,7 +1725,13 @@ describe('S2S Adapter', function () { adapter.callBids(s2sBidRequest, bidRequests, addBidResponse, done, ajax); const parsedRequestBody = JSON.parse(server.requests[0].requestBody); - expect(parsedRequestBody.ext.prebid.channel).to.deep.equal({test: 1}); + + // extPrebid is now deep merged with + expect(parsedRequestBody.ext.prebid.channel).to.deep.equal({ + name: 'pbjs', + test: 1, + version: 'v$prebid.version$' + }); }); it('passes first party data in request', () => { diff --git a/test/spec/unit/core/adapterManager_spec.js b/test/spec/unit/core/adapterManager_spec.js index f33c9139e5f..b4f5c4d66bd 100644 --- a/test/spec/unit/core/adapterManager_spec.js +++ b/test/spec/unit/core/adapterManager_spec.js @@ -986,11 +986,17 @@ describe('adapterManager tests', function () { describe('BID_REQUESTED event', function () { // function to count BID_REQUESTED events - let cnt, count = () => cnt++; + let cnt; + let tidCount = {}; + let count = bid => { + cnt++; + tidCount[bid.tid] = tidCount[bid.tid] ? tidCount[bid.tid]++ : 1; + } beforeEach(function () { prebidServerAdapterMock.callBids.reset(); cnt = 0; + tidCount = {}; events.on(CONSTANTS.EVENTS.BID_REQUESTED, count); }); @@ -1009,6 +1015,21 @@ describe('adapterManager tests', function () { sinon.assert.calledTwice(prebidServerAdapterMock.callBids); }); + it('should have one tid for ALL s2s bidRequests', function () { + let adUnits = utils.deepClone(getAdUnits()).map(adUnit => { + adUnit.bids = adUnit.bids.filter(bid => includes(['appnexus', 'pubmatic'], bid.bidder)); + return adUnit; + }) + let bidRequests = adapterManager.makeBidRequests(adUnits, 1111, 2222, 1000); + adapterManager.callBids(adUnits, bidRequests, () => {}, () => {}); + expect(Object.keys(tidCount)).to.equal(1); + + // should have 2 counts of the tid + let bidTid = Object.keys(tidCount)[0]; + expect(tidCount[bidTid]).to.equal(2); + sinon.assert.calledTwice(prebidServerAdapterMock.callBids); + }); + it('should fire for simultaneous s2s and client requests', function () { adapterManager.bidderRegistry['adequant'] = adequantAdapterMock; let adUnits = utils.deepClone(getAdUnits()).map(adUnit => { From 61d2cacd2507ca58e2ff8a9e39b516b26df72f39 Mon Sep 17 00:00:00 2001 From: robertrmartinez Date: Thu, 14 Oct 2021 13:17:22 -0700 Subject: [PATCH 5/8] .length duh --- test/spec/unit/core/adapterManager_spec.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/spec/unit/core/adapterManager_spec.js b/test/spec/unit/core/adapterManager_spec.js index b4f5c4d66bd..6a8de0dc2a5 100644 --- a/test/spec/unit/core/adapterManager_spec.js +++ b/test/spec/unit/core/adapterManager_spec.js @@ -1022,7 +1022,7 @@ describe('adapterManager tests', function () { }) let bidRequests = adapterManager.makeBidRequests(adUnits, 1111, 2222, 1000); adapterManager.callBids(adUnits, bidRequests, () => {}, () => {}); - expect(Object.keys(tidCount)).to.equal(1); + expect(Object.keys(tidCount).length).to.equal(1); // should have 2 counts of the tid let bidTid = Object.keys(tidCount)[0]; From 64558d1cc661c7ed3204a1cfa2c6e1e3817f46db Mon Sep 17 00:00:00 2001 From: robertrmartinez Date: Thu, 14 Oct 2021 13:29:04 -0700 Subject: [PATCH 6/8] test was incorrect --- test/spec/unit/core/adapterManager_spec.js | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/test/spec/unit/core/adapterManager_spec.js b/test/spec/unit/core/adapterManager_spec.js index 6a8de0dc2a5..88272f0bafe 100644 --- a/test/spec/unit/core/adapterManager_spec.js +++ b/test/spec/unit/core/adapterManager_spec.js @@ -986,17 +986,11 @@ describe('adapterManager tests', function () { describe('BID_REQUESTED event', function () { // function to count BID_REQUESTED events - let cnt; - let tidCount = {}; - let count = bid => { - cnt++; - tidCount[bid.tid] = tidCount[bid.tid] ? tidCount[bid.tid]++ : 1; - } + let cnt, count = () => cnt++; beforeEach(function () { prebidServerAdapterMock.callBids.reset(); cnt = 0; - tidCount = {}; events.on(CONSTANTS.EVENTS.BID_REQUESTED, count); }); @@ -1022,12 +1016,12 @@ describe('adapterManager tests', function () { }) let bidRequests = adapterManager.makeBidRequests(adUnits, 1111, 2222, 1000); adapterManager.callBids(adUnits, bidRequests, () => {}, () => {}); - expect(Object.keys(tidCount).length).to.equal(1); - - // should have 2 counts of the tid - let bidTid = Object.keys(tidCount)[0]; - expect(tidCount[bidTid]).to.equal(2); sinon.assert.calledTwice(prebidServerAdapterMock.callBids); + const firstBid = prebidServerAdapterMock.callBids.firstCall.args[0]; + const secondBid = prebidServerAdapterMock.callBids.secondCall.args[0]; + + // TIDS should be the same + expect(firstBid.tid).to.equal(secondBid.tid); }); it('should fire for simultaneous s2s and client requests', function () { From bc04dd335300dc2a1902c46f09b0fb9a2501e6fb Mon Sep 17 00:00:00 2001 From: robertrmartinez Date: Thu, 14 Oct 2021 13:36:46 -0700 Subject: [PATCH 7/8] no longer let this val be tid as it is not representitive --- src/adapterManager.js | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/src/adapterManager.js b/src/adapterManager.js index 400324eb71a..8903d233359 100644 --- a/src/adapterManager.js +++ b/src/adapterManager.js @@ -263,15 +263,15 @@ adapterManager.makeBidRequests = hook('sync', function (adUnits, auctionStart, a let adUnitsS2SCopy = getAdUnitCopyForPrebidServer(adUnits, s2sConfig); - // tid is so we know which server to send which bids to during the callBids function - let tid = generateUUID(); + // uniquePbsTid is so we know which server to send which bids to during the callBids function + let uniquePbsTid = generateUUID(); adaptersServerSide.forEach(bidderCode => { const bidderRequestId = getUniqueIdentifierStr(); const bidderRequest = { bidderCode, auctionId, bidderRequestId, - tid, + uniquePbsTid, bids: hookedGetBids({bidderCode, auctionId, bidderRequestId, 'adUnits': deepClone(adUnitsS2SCopy), labels, src: CONSTANTS.S2S.SRC}), auctionStart: auctionStart, timeout: s2sConfig.timeout, @@ -352,7 +352,7 @@ adapterManager.callBids = (adUnits, bidRequests, addBidResponse, doneCb, request serverBidRequests.forEach(serverBidRequest => { var index = -1; for (var i = 0; i < uniqueServerBidRequests.length; ++i) { - if (serverBidRequest.tid === uniqueServerBidRequests[i].tid) { + if (serverBidRequest.uniquePbsTid === uniqueServerBidRequests[i].uniquePbsTid) { index = i; break; } @@ -375,10 +375,10 @@ adapterManager.callBids = (adUnits, bidRequests, addBidResponse, doneCb, request } : undefined); let adaptersServerSide = s2sConfig.bidders; const s2sAdapter = _bidderRegistry[s2sConfig.adapter]; - let tid = uniqueServerBidRequests[counter].tid; + let uniquePbsTid = uniqueServerBidRequests[counter].uniquePbsTid; let adUnitsS2SCopy = uniqueServerBidRequests[counter].adUnitsS2SCopy; - let uniqueServerRequests = serverBidRequests.filter(serverBidRequest => serverBidRequest.tid === tid); + let uniqueServerRequests = serverBidRequests.filter(serverBidRequest => serverBidRequest.uniquePbsTid === uniquePbsTid); if (s2sAdapter) { let s2sBidRequest = {tid: sourceTid, 'ad_units': adUnitsS2SCopy, s2sConfig}; @@ -396,7 +396,8 @@ adapterManager.callBids = (adUnits, bidRequests, addBidResponse, doneCb, request // fire BID_REQUESTED event for each s2s bidRequest uniqueServerRequests.forEach(bidRequest => { - events.emit(CONSTANTS.EVENTS.BID_REQUESTED, bidRequest); + // add the new sourceTid + events.emit(CONSTANTS.EVENTS.BID_REQUESTED, {...bidRequest, tid: sourceTid}); }); // make bid requests From 44fe7507229773ac48c3a2cc8e210f2c6ea78b8c Mon Sep 17 00:00:00 2001 From: robertrmartinez Date: Thu, 14 Oct 2021 14:02:04 -0700 Subject: [PATCH 8/8] fix test --- test/spec/unit/core/adapterManager_spec.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/spec/unit/core/adapterManager_spec.js b/test/spec/unit/core/adapterManager_spec.js index 88272f0bafe..ba944a25f12 100644 --- a/test/spec/unit/core/adapterManager_spec.js +++ b/test/spec/unit/core/adapterManager_spec.js @@ -162,7 +162,7 @@ describe('adapterManager tests', function () { 'bidderCode': 'appnexus', 'auctionId': '1863e370099523', 'bidderRequestId': '2946b569352ef2', - 'tid': '34566b569352ef2', + 'uniquePbsTid': '34566b569352ef2', 'bids': [ { 'bidder': 'appnexus', @@ -447,7 +447,7 @@ describe('adapterManager tests', function () { 'bidderCode': 'appnexus', 'auctionId': '1863e370099523', 'bidderRequestId': '2946b569352ef2', - 'tid': '34566b569352ef2', + 'uniquePbsTid': '34566b569352ef2', 'timeout': 1000, 'src': 's2s', 'adUnitsS2SCopy': [ @@ -676,7 +676,7 @@ describe('adapterManager tests', function () { 'bidderCode': 'appnexus', 'auctionId': '1863e370099523', 'bidderRequestId': '2946b569352ef2', - 'tid': '34566b569352ef2', + 'uniquePbsTid': '34566b569352ef2', 'timeout': 1000, 'src': 's2s', 'adUnitsS2SCopy': [ @@ -812,7 +812,7 @@ describe('adapterManager tests', function () { 'bidderCode': 'pubmatic', 'auctionId': '1863e370099523', 'bidderRequestId': '2946b569352ef2', - 'tid': '2342342342lfi23', + 'uniquePbsTid': '2342342342lfi23', 'timeout': 1000, 'src': 's2s', 'adUnitsS2SCopy': [