From f9f8e0581501e55eba6f54845d6f194205c34e4b Mon Sep 17 00:00:00 2001 From: oath-jac Date: Tue, 6 Jun 2023 21:24:10 +0300 Subject: [PATCH] YahooSSP rebranding to Yahoo Advertising. --- .../params_test.go | 16 ++++++++-------- .../yahooAdvertising.go} | 12 ++++++------ .../yahooAdvertising_test.go} | 14 +++++++------- .../exemplary/simple-app-banner.json | 2 +- .../exemplary/simple-banner.json | 2 +- .../exemplary/simple-video.json | 2 +- .../supplemental/empty-banner-format.json | 0 .../supplemental/invalid-banner-height.json | 0 .../supplemental/invalid-banner-width.json | 0 .../non-supported-requests-bids-ignored.json | 2 +- .../supplemental/required-nobidder-info.json | 0 .../supplemental/server-error.json | 0 .../server-response-wrong-impid.json | 2 +- .../simple-banner-gpp-overwrite.json | 2 +- .../supplemental/simple-banner-gpp.json | 2 +- ...-banner-ignore-width-when-height-missing.json | 2 +- exchange/adapter_builders.go | 6 +++--- exchange/adapter_util.go | 2 +- exchange/adapter_util_test.go | 8 ++++---- openrtb_ext/bidders.go | 4 ++-- openrtb_ext/imp_verizonmedia.go | 7 ------- openrtb_ext/imp_yahooAdvertising.go | 7 +++++++ .../{verizonmedia.yaml => yahooAdvertising.yaml} | 8 +++++--- .../{verizonmedia.json => yahooAdvertising.json} | 6 ++++-- 24 files changed, 55 insertions(+), 51 deletions(-) rename adapters/{yahoossp => yahooAdvertising}/params_test.go (63%) rename adapters/{yahoossp/yahoossp.go => yahooAdvertising/yahooAdvertising.go} (93%) rename adapters/{yahoossp/yahoossp_test.go => yahooAdvertising/yahooAdvertising_test.go} (51%) rename adapters/{yahoossp/yahoossptest => yahooAdvertising/yahooAdvertisingtest}/exemplary/simple-app-banner.json (98%) rename adapters/{yahoossp/yahoossptest => yahooAdvertising/yahooAdvertisingtest}/exemplary/simple-banner.json (98%) rename adapters/{yahoossp/yahoossptest => yahooAdvertising/yahooAdvertisingtest}/exemplary/simple-video.json (98%) rename adapters/{yahoossp/yahoossptest => yahooAdvertising/yahooAdvertisingtest}/supplemental/empty-banner-format.json (100%) rename adapters/{yahoossp/yahoossptest => yahooAdvertising/yahooAdvertisingtest}/supplemental/invalid-banner-height.json (100%) rename adapters/{yahoossp/yahoossptest => yahooAdvertising/yahooAdvertisingtest}/supplemental/invalid-banner-width.json (100%) rename adapters/{yahoossp/yahoossptest => yahooAdvertising/yahooAdvertisingtest}/supplemental/non-supported-requests-bids-ignored.json (98%) rename adapters/{yahoossp/yahoossptest => yahooAdvertising/yahooAdvertisingtest}/supplemental/required-nobidder-info.json (100%) rename adapters/{yahoossp/yahoossptest => yahooAdvertising/yahooAdvertisingtest}/supplemental/server-error.json (100%) rename adapters/{yahoossp/yahoossptest => yahooAdvertising/yahooAdvertisingtest}/supplemental/server-response-wrong-impid.json (98%) rename adapters/{yahoossp/yahoossptest => yahooAdvertising/yahooAdvertisingtest}/supplemental/simple-banner-gpp-overwrite.json (98%) rename adapters/{yahoossp/yahoossptest => yahooAdvertising/yahooAdvertisingtest}/supplemental/simple-banner-gpp.json (98%) rename adapters/{yahoossp/yahoossptest => yahooAdvertising/yahooAdvertisingtest}/supplemental/simple-banner-ignore-width-when-height-missing.json (98%) delete mode 100644 openrtb_ext/imp_verizonmedia.go create mode 100644 openrtb_ext/imp_yahooAdvertising.go rename static/bidder-info/{verizonmedia.yaml => yahooAdvertising.yaml} (52%) rename static/bidder-params/{verizonmedia.json => yahooAdvertising.json} (75%) diff --git a/adapters/yahoossp/params_test.go b/adapters/yahooAdvertising/params_test.go similarity index 63% rename from adapters/yahoossp/params_test.go rename to adapters/yahooAdvertising/params_test.go index 47d8d26894b..10d504cb291 100644 --- a/adapters/yahoossp/params_test.go +++ b/adapters/yahooAdvertising/params_test.go @@ -1,4 +1,4 @@ -package yahoossp +package yahooAdvertising import ( "encoding/json" @@ -7,11 +7,11 @@ import ( "github.com/prebid/prebid-server/openrtb_ext" ) -// This file actually intends to test static/bidder-params/yahoossp.json +// This file actually intends to test static/bidder-params/yahooAdvertising.json // -// These also validate the format of the external API: request.imp[i].ext.yahoossp +// These also validate the format of the external API: request.imp[i].ext.yahooAdvertising -// TestValidParams makes sure that the yahoossp schema accepts all imp.ext fields which we intend to support. +// TestValidParams makes sure that the yahooAdvertising schema accepts all imp.ext fields which we intend to support. func TestValidParams(t *testing.T) { validator, err := openrtb_ext.NewBidderParamsValidator("../../static/bidder-params") if err != nil { @@ -19,13 +19,13 @@ func TestValidParams(t *testing.T) { } for _, validParam := range validParams { - if err := validator.Validate(openrtb_ext.BidderYahooSSP, json.RawMessage(validParam)); err != nil { - t.Errorf("Schema rejected yahoossp params: %s", validParam) + if err := validator.Validate(openrtb_ext.BidderYahooAdvertising, json.RawMessage(validParam)); err != nil { + t.Errorf("Schema rejected yahooAdvertising params: %s", validParam) } } } -// TestInvalidParams makes sure that the yahoossp schema rejects all the imp.ext fields we don't support. +// TestInvalidParams makes sure that the yahooAdvertising schema rejects all the imp.ext fields we don't support. func TestInvalidParams(t *testing.T) { validator, err := openrtb_ext.NewBidderParamsValidator("../../static/bidder-params") if err != nil { @@ -33,7 +33,7 @@ func TestInvalidParams(t *testing.T) { } for _, invalidParam := range invalidParams { - if err := validator.Validate(openrtb_ext.BidderYahooSSP, json.RawMessage(invalidParam)); err == nil { + if err := validator.Validate(openrtb_ext.BidderYahooAdvertising, json.RawMessage(invalidParam)); err == nil { t.Errorf("Schema allowed unexpected params: %s", invalidParam) } } diff --git a/adapters/yahoossp/yahoossp.go b/adapters/yahooAdvertising/yahooAdvertising.go similarity index 93% rename from adapters/yahoossp/yahoossp.go rename to adapters/yahooAdvertising/yahooAdvertising.go index 797ea708be6..d476adb4e8e 100644 --- a/adapters/yahoossp/yahoossp.go +++ b/adapters/yahooAdvertising/yahooAdvertising.go @@ -1,4 +1,4 @@ -package yahoossp +package yahooAdvertising import ( "encoding/json" @@ -41,8 +41,8 @@ func (a *adapter) MakeRequests(request *openrtb2.BidRequest, reqInfo *adapters.E continue } - var yahoosspExt openrtb_ext.ExtImpYahooSSP - err = json.Unmarshal(bidderExt.Bidder, &yahoosspExt) + var yahooAdvertisingExt openrtb_ext.ExtImpYahooAdvertising + err = json.Unmarshal(bidderExt.Bidder, &yahooAdvertisingExt) if err != nil { err = &errortypes.BadInput{ Message: fmt.Sprintf("imp #%d: %s", idx, err.Error()), @@ -64,7 +64,7 @@ func (a *adapter) MakeRequests(request *openrtb2.BidRequest, reqInfo *adapters.E reqCopy.App = &appCopy } - if err := changeRequestForBidService(&reqCopy, &yahoosspExt); err != nil { + if err := changeRequestForBidService(&reqCopy, &yahooAdvertisingExt); err != nil { errors = append(errors, err) continue } @@ -150,7 +150,7 @@ func getImpInfo(impId string, imps []openrtb2.Imp) (bool, openrtb_ext.BidType) { return exists, mediaType } -func changeRequestForBidService(request *openrtb2.BidRequest, extension *openrtb_ext.ExtImpYahooSSP) error { +func changeRequestForBidService(request *openrtb2.BidRequest, extension *openrtb_ext.ExtImpYahooAdvertising) error { /* Always override the tag ID and (site ID or app ID) of the request */ request.Imp[0].TagID = extension.Pos if request.Site != nil { @@ -218,7 +218,7 @@ func validateBanner(banner *openrtb2.Banner) error { return nil } -// Builder builds a new instance of the YahooSSP adapter for the given bidder with the given config. +// Builder builds a new instance of the YahooAdvertising adapter for the given bidder with the given config. func Builder(bidderName openrtb_ext.BidderName, config config.Adapter, server config.Server) (adapters.Bidder, error) { bidder := &adapter{ URI: config.Endpoint, diff --git a/adapters/yahoossp/yahoossp_test.go b/adapters/yahooAdvertising/yahooAdvertising_test.go similarity index 51% rename from adapters/yahoossp/yahoossp_test.go rename to adapters/yahooAdvertising/yahooAdvertising_test.go index eeb739c612f..e701c3335c1 100644 --- a/adapters/yahoossp/yahoossp_test.go +++ b/adapters/yahooAdvertising/yahooAdvertising_test.go @@ -1,4 +1,4 @@ -package yahoossp +package yahooAdvertising import ( "testing" @@ -10,8 +10,8 @@ import ( "github.com/prebid/prebid-server/openrtb_ext" ) -func TestYahooSSPBidderEndpointConfig(t *testing.T) { - bidder, buildErr := Builder(openrtb_ext.BidderYahooSSP, config.Adapter{ +func TestYahooAdvertisingBidderEndpointConfig(t *testing.T) { + bidder, buildErr := Builder(openrtb_ext.BidderYahooAdvertising, config.Adapter{ Endpoint: "http://localhost/bid", }, config.Server{ExternalUrl: "http://hosturl.com", GvlID: 1, DataCenter: "2"}) @@ -19,17 +19,17 @@ func TestYahooSSPBidderEndpointConfig(t *testing.T) { t.Fatalf("Builder returned unexpected error %v", buildErr) } - bidderYahooSSP := bidder.(*adapter) + bidderYahooAdvertising := bidder.(*adapter) - assert.Equal(t, "http://localhost/bid", bidderYahooSSP.URI) + assert.Equal(t, "http://localhost/bid", bidderYahooAdvertising.URI) } func TestJsonSamples(t *testing.T) { - bidder, buildErr := Builder(openrtb_ext.BidderYahooSSP, config.Adapter{}, config.Server{ExternalUrl: "http://hosturl.com", GvlID: 1, DataCenter: "2"}) + bidder, buildErr := Builder(openrtb_ext.BidderYahooAdvertising, config.Adapter{}, config.Server{ExternalUrl: "http://hosturl.com", GvlID: 1, DataCenter: "2"}) if buildErr != nil { t.Fatalf("Builder returned unexpected error %v", buildErr) } - adapterstest.RunJSONBidderTest(t, "yahoossptest", bidder) + adapterstest.RunJSONBidderTest(t, "yahooAdvertisingtest", bidder) } diff --git a/adapters/yahoossp/yahoossptest/exemplary/simple-app-banner.json b/adapters/yahooAdvertising/yahooAdvertisingtest/exemplary/simple-app-banner.json similarity index 98% rename from adapters/yahoossp/yahoossptest/exemplary/simple-app-banner.json rename to adapters/yahooAdvertising/yahooAdvertisingtest/exemplary/simple-app-banner.json index 319e22e31dd..d5e77c71d3d 100644 --- a/adapters/yahoossp/yahoossptest/exemplary/simple-app-banner.json +++ b/adapters/yahooAdvertising/yahooAdvertisingtest/exemplary/simple-app-banner.json @@ -77,7 +77,7 @@ "id": "test-request-id", "seatbid": [ { - "seat": "yahoossp", + "seat": "yahooAdvertising", "bid": [{ "id": "8ee514f1-b2b8-4abb-89fd-084437d1e800", "impid": "test-imp-id", diff --git a/adapters/yahoossp/yahoossptest/exemplary/simple-banner.json b/adapters/yahooAdvertising/yahooAdvertisingtest/exemplary/simple-banner.json similarity index 98% rename from adapters/yahoossp/yahoossptest/exemplary/simple-banner.json rename to adapters/yahooAdvertising/yahooAdvertisingtest/exemplary/simple-banner.json index 344bbe9af94..d08bdf06019 100644 --- a/adapters/yahoossp/yahoossptest/exemplary/simple-banner.json +++ b/adapters/yahooAdvertising/yahooAdvertisingtest/exemplary/simple-banner.json @@ -77,7 +77,7 @@ "id": "test-request-id", "seatbid": [ { - "seat": "yahoossp", + "seat": "yahooAdvertising", "bid": [{ "id": "8ee514f1-b2b8-4abb-89fd-084437d1e800", "impid": "test-imp-id", diff --git a/adapters/yahoossp/yahoossptest/exemplary/simple-video.json b/adapters/yahooAdvertising/yahooAdvertisingtest/exemplary/simple-video.json similarity index 98% rename from adapters/yahoossp/yahoossptest/exemplary/simple-video.json rename to adapters/yahooAdvertising/yahooAdvertisingtest/exemplary/simple-video.json index d62272643a1..ea95ec40306 100644 --- a/adapters/yahoossp/yahoossptest/exemplary/simple-video.json +++ b/adapters/yahooAdvertising/yahooAdvertisingtest/exemplary/simple-video.json @@ -92,7 +92,7 @@ "id": "test-request-id", "seatbid": [ { - "seat": "yahoossp", + "seat": "yahooAdvertising", "bid": [{ "id": "8ee514f1-b2b8-4abb-89fd-084437d1e800", "impid": "test-imp-id", diff --git a/adapters/yahoossp/yahoossptest/supplemental/empty-banner-format.json b/adapters/yahooAdvertising/yahooAdvertisingtest/supplemental/empty-banner-format.json similarity index 100% rename from adapters/yahoossp/yahoossptest/supplemental/empty-banner-format.json rename to adapters/yahooAdvertising/yahooAdvertisingtest/supplemental/empty-banner-format.json diff --git a/adapters/yahoossp/yahoossptest/supplemental/invalid-banner-height.json b/adapters/yahooAdvertising/yahooAdvertisingtest/supplemental/invalid-banner-height.json similarity index 100% rename from adapters/yahoossp/yahoossptest/supplemental/invalid-banner-height.json rename to adapters/yahooAdvertising/yahooAdvertisingtest/supplemental/invalid-banner-height.json diff --git a/adapters/yahoossp/yahoossptest/supplemental/invalid-banner-width.json b/adapters/yahooAdvertising/yahooAdvertisingtest/supplemental/invalid-banner-width.json similarity index 100% rename from adapters/yahoossp/yahoossptest/supplemental/invalid-banner-width.json rename to adapters/yahooAdvertising/yahooAdvertisingtest/supplemental/invalid-banner-width.json diff --git a/adapters/yahoossp/yahoossptest/supplemental/non-supported-requests-bids-ignored.json b/adapters/yahooAdvertising/yahooAdvertisingtest/supplemental/non-supported-requests-bids-ignored.json similarity index 98% rename from adapters/yahoossp/yahoossptest/supplemental/non-supported-requests-bids-ignored.json rename to adapters/yahooAdvertising/yahooAdvertisingtest/supplemental/non-supported-requests-bids-ignored.json index 11a93f685a4..a44020daf3f 100644 --- a/adapters/yahoossp/yahoossptest/supplemental/non-supported-requests-bids-ignored.json +++ b/adapters/yahooAdvertising/yahooAdvertisingtest/supplemental/non-supported-requests-bids-ignored.json @@ -74,7 +74,7 @@ "id": "test-request-id", "seatbid": [ { - "seat": "yahoossp", + "seat": "yahooAdvertising", "bid": [{ "id": "8ee514f1-b2b8-4abb-89fd-084437d1e800", "impid": "test-imp-id", diff --git a/adapters/yahoossp/yahoossptest/supplemental/required-nobidder-info.json b/adapters/yahooAdvertising/yahooAdvertisingtest/supplemental/required-nobidder-info.json similarity index 100% rename from adapters/yahoossp/yahoossptest/supplemental/required-nobidder-info.json rename to adapters/yahooAdvertising/yahooAdvertisingtest/supplemental/required-nobidder-info.json diff --git a/adapters/yahoossp/yahoossptest/supplemental/server-error.json b/adapters/yahooAdvertising/yahooAdvertisingtest/supplemental/server-error.json similarity index 100% rename from adapters/yahoossp/yahoossptest/supplemental/server-error.json rename to adapters/yahooAdvertising/yahooAdvertisingtest/supplemental/server-error.json diff --git a/adapters/yahoossp/yahoossptest/supplemental/server-response-wrong-impid.json b/adapters/yahooAdvertising/yahooAdvertisingtest/supplemental/server-response-wrong-impid.json similarity index 98% rename from adapters/yahoossp/yahoossptest/supplemental/server-response-wrong-impid.json rename to adapters/yahooAdvertising/yahooAdvertisingtest/supplemental/server-response-wrong-impid.json index 5b33f3af67d..1fcf61e12b7 100644 --- a/adapters/yahoossp/yahoossptest/supplemental/server-response-wrong-impid.json +++ b/adapters/yahooAdvertising/yahooAdvertisingtest/supplemental/server-response-wrong-impid.json @@ -76,7 +76,7 @@ "id": "test-request-id", "seatbid": [ { - "seat": "yahoossp", + "seat": "yahooAdvertising", "bid": [{ "id": "8ee514f1-b2b8-4abb-89fd-084437d1e800", "impid": "wrong", diff --git a/adapters/yahoossp/yahoossptest/supplemental/simple-banner-gpp-overwrite.json b/adapters/yahooAdvertising/yahooAdvertisingtest/supplemental/simple-banner-gpp-overwrite.json similarity index 98% rename from adapters/yahoossp/yahoossptest/supplemental/simple-banner-gpp-overwrite.json rename to adapters/yahooAdvertising/yahooAdvertisingtest/supplemental/simple-banner-gpp-overwrite.json index ffc7ae651e7..190f96bf0a6 100644 --- a/adapters/yahoossp/yahoossptest/supplemental/simple-banner-gpp-overwrite.json +++ b/adapters/yahooAdvertising/yahooAdvertisingtest/supplemental/simple-banner-gpp-overwrite.json @@ -92,7 +92,7 @@ "id": "test-request-id", "seatbid": [ { - "seat": "yahoossp", + "seat": "yahooAdvertising", "bid": [{ "id": "8ee514f1-b2b8-4abb-89fd-084437d1e800", "impid": "test-imp-id", diff --git a/adapters/yahoossp/yahoossptest/supplemental/simple-banner-gpp.json b/adapters/yahooAdvertising/yahooAdvertisingtest/supplemental/simple-banner-gpp.json similarity index 98% rename from adapters/yahoossp/yahoossptest/supplemental/simple-banner-gpp.json rename to adapters/yahooAdvertising/yahooAdvertisingtest/supplemental/simple-banner-gpp.json index 88f97d116d3..81c89f55c3d 100644 --- a/adapters/yahoossp/yahoossptest/supplemental/simple-banner-gpp.json +++ b/adapters/yahooAdvertising/yahooAdvertisingtest/supplemental/simple-banner-gpp.json @@ -87,7 +87,7 @@ "id": "test-request-id", "seatbid": [ { - "seat": "yahoossp", + "seat": "yahooAdvertising", "bid": [{ "id": "8ee514f1-b2b8-4abb-89fd-084437d1e800", "impid": "test-imp-id", diff --git a/adapters/yahoossp/yahoossptest/supplemental/simple-banner-ignore-width-when-height-missing.json b/adapters/yahooAdvertising/yahooAdvertisingtest/supplemental/simple-banner-ignore-width-when-height-missing.json similarity index 98% rename from adapters/yahoossp/yahoossptest/supplemental/simple-banner-ignore-width-when-height-missing.json rename to adapters/yahooAdvertising/yahooAdvertisingtest/supplemental/simple-banner-ignore-width-when-height-missing.json index 16e64c6165b..353d5e29e71 100644 --- a/adapters/yahoossp/yahoossptest/supplemental/simple-banner-ignore-width-when-height-missing.json +++ b/adapters/yahooAdvertising/yahooAdvertisingtest/supplemental/simple-banner-ignore-width-when-height-missing.json @@ -78,7 +78,7 @@ "id": "test-request-id", "seatbid": [ { - "seat": "yahoossp", + "seat": "yahooAdvertising", "bid": [{ "id": "8ee514f1-b2b8-4abb-89fd-084437d1e800", "impid": "test-imp-id", diff --git a/exchange/adapter_builders.go b/exchange/adapter_builders.go index a9f547100f5..e60ca978af4 100755 --- a/exchange/adapter_builders.go +++ b/exchange/adapter_builders.go @@ -166,7 +166,7 @@ import ( "github.com/prebid/prebid-server/adapters/visx" "github.com/prebid/prebid-server/adapters/vrtcal" "github.com/prebid/prebid-server/adapters/xeworks" - "github.com/prebid/prebid-server/adapters/yahoossp" + "github.com/prebid/prebid-server/adapters/yahooAdvertising" "github.com/prebid/prebid-server/adapters/yeahmobi" "github.com/prebid/prebid-server/adapters/yieldlab" "github.com/prebid/prebid-server/adapters/yieldmo" @@ -352,7 +352,6 @@ func newAdapterBuilders() map[openrtb_ext.BidderName]adapters.Builder { openrtb_ext.BidderUnicorn: unicorn.Builder, openrtb_ext.BidderUnruly: unruly.Builder, openrtb_ext.BidderValueImpression: apacdex.Builder, - openrtb_ext.BidderVerizonMedia: yahoossp.Builder, openrtb_ext.BidderVideoByte: videobyte.Builder, openrtb_ext.BidderVideoHeroes: videoheroes.Builder, openrtb_ext.BidderVidoomy: vidoomy.Builder, @@ -361,7 +360,8 @@ func newAdapterBuilders() map[openrtb_ext.BidderName]adapters.Builder { openrtb_ext.BidderVisx: visx.Builder, openrtb_ext.BidderVrtcal: vrtcal.Builder, openrtb_ext.BidderXeworks: xeworks.Builder, - openrtb_ext.BidderYahooSSP: yahoossp.Builder, + openrtb_ext.BidderYahooAdvertising: yahooAdvertising.Builder, + openrtb_ext.BidderYahooSSP: yahooAdvertising.Builder, openrtb_ext.BidderYeahmobi: yeahmobi.Builder, openrtb_ext.BidderYieldlab: yieldlab.Builder, openrtb_ext.BidderYieldmo: yieldmo.Builder, diff --git a/exchange/adapter_util.go b/exchange/adapter_util.go index 4876cef7ae7..33904aaec86 100644 --- a/exchange/adapter_util.go +++ b/exchange/adapter_util.go @@ -88,7 +88,7 @@ func GetDisabledBiddersErrorMessages(infos config.BidderInfos) map[string]string "lifestreet": `Bidder "lifestreet" is no longer available in Prebid Server. Please update your configuration.`, "adagio": `Bidder "adagio" is no longer available in Prebid Server. Please update your configuration.`, "somoaudience": `Bidder "somoaudience" is no longer available in Prebid Server. Please update your configuration.`, - "yssp": `Bidder "yssp" is no longer available in Prebid Server. If you're looking to use the Yahoo SSP adapter, please rename it to "yahoossp" in your configuration.`, + "yssp": `Bidder "yssp" is no longer available in Prebid Server. If you're looking to use the Yahoo SSP adapter, please rename it to "yahooAdvertising" in your configuration.`, "andbeyondmedia": `Bidder "andbeyondmedia" is no longer available in Prebid Server. If you're looking to use the AndBeyond.Media SSP adapter, please rename it to "beyondmedia" in your configuration.`, "oftmedia": `Bidder "oftmedia" is no longer available in Prebid Server. Please update your configuration.`, "groupm": `Bidder "groupm" is no longer available in Prebid Server. Please update your configuration.`, diff --git a/exchange/adapter_util_test.go b/exchange/adapter_util_test.go index b08a85de802..43cefeecc17 100644 --- a/exchange/adapter_util_test.go +++ b/exchange/adapter_util_test.go @@ -210,7 +210,7 @@ func TestGetDisabledBiddersErrorMessages(t *testing.T) { "lifestreet": `Bidder "lifestreet" is no longer available in Prebid Server. Please update your configuration.`, "adagio": `Bidder "adagio" is no longer available in Prebid Server. Please update your configuration.`, "somoaudience": `Bidder "somoaudience" is no longer available in Prebid Server. Please update your configuration.`, - "yssp": `Bidder "yssp" is no longer available in Prebid Server. If you're looking to use the Yahoo SSP adapter, please rename it to "yahoossp" in your configuration.`, + "yssp": `Bidder "yssp" is no longer available in Prebid Server. If you're looking to use the Yahoo SSP adapter, please rename it to "yahooAdvertising" in your configuration.`, "andbeyondmedia": `Bidder "andbeyondmedia" is no longer available in Prebid Server. If you're looking to use the AndBeyond.Media SSP adapter, please rename it to "beyondmedia" in your configuration.`, "oftmedia": `Bidder "oftmedia" is no longer available in Prebid Server. Please update your configuration.`, "groupm": `Bidder "groupm" is no longer available in Prebid Server. Please update your configuration.`, @@ -223,7 +223,7 @@ func TestGetDisabledBiddersErrorMessages(t *testing.T) { "lifestreet": `Bidder "lifestreet" is no longer available in Prebid Server. Please update your configuration.`, "adagio": `Bidder "adagio" is no longer available in Prebid Server. Please update your configuration.`, "somoaudience": `Bidder "somoaudience" is no longer available in Prebid Server. Please update your configuration.`, - "yssp": `Bidder "yssp" is no longer available in Prebid Server. If you're looking to use the Yahoo SSP adapter, please rename it to "yahoossp" in your configuration.`, + "yssp": `Bidder "yssp" is no longer available in Prebid Server. If you're looking to use the Yahoo SSP adapter, please rename it to "yahooAdvertising" in your configuration.`, "andbeyondmedia": `Bidder "andbeyondmedia" is no longer available in Prebid Server. If you're looking to use the AndBeyond.Media SSP adapter, please rename it to "beyondmedia" in your configuration.`, "oftmedia": `Bidder "oftmedia" is no longer available in Prebid Server. Please update your configuration.`, "groupm": `Bidder "groupm" is no longer available in Prebid Server. Please update your configuration.`, @@ -236,7 +236,7 @@ func TestGetDisabledBiddersErrorMessages(t *testing.T) { "lifestreet": `Bidder "lifestreet" is no longer available in Prebid Server. Please update your configuration.`, "adagio": `Bidder "adagio" is no longer available in Prebid Server. Please update your configuration.`, "somoaudience": `Bidder "somoaudience" is no longer available in Prebid Server. Please update your configuration.`, - "yssp": `Bidder "yssp" is no longer available in Prebid Server. If you're looking to use the Yahoo SSP adapter, please rename it to "yahoossp" in your configuration.`, + "yssp": `Bidder "yssp" is no longer available in Prebid Server. If you're looking to use the Yahoo SSP adapter, please rename it to "yahooAdvertising" in your configuration.`, "appnexus": `Bidder "appnexus" has been disabled on this instance of Prebid Server. Please work with the PBS host to enable this bidder again.`, "andbeyondmedia": `Bidder "andbeyondmedia" is no longer available in Prebid Server. If you're looking to use the AndBeyond.Media SSP adapter, please rename it to "beyondmedia" in your configuration.`, "oftmedia": `Bidder "oftmedia" is no longer available in Prebid Server. Please update your configuration.`, @@ -250,7 +250,7 @@ func TestGetDisabledBiddersErrorMessages(t *testing.T) { "lifestreet": `Bidder "lifestreet" is no longer available in Prebid Server. Please update your configuration.`, "adagio": `Bidder "adagio" is no longer available in Prebid Server. Please update your configuration.`, "somoaudience": `Bidder "somoaudience" is no longer available in Prebid Server. Please update your configuration.`, - "yssp": `Bidder "yssp" is no longer available in Prebid Server. If you're looking to use the Yahoo SSP adapter, please rename it to "yahoossp" in your configuration.`, + "yssp": `Bidder "yssp" is no longer available in Prebid Server. If you're looking to use the Yahoo SSP adapter, please rename it to "yahooAdvertising" in your configuration.`, "appnexus": `Bidder "appnexus" has been disabled on this instance of Prebid Server. Please work with the PBS host to enable this bidder again.`, "andbeyondmedia": `Bidder "andbeyondmedia" is no longer available in Prebid Server. If you're looking to use the AndBeyond.Media SSP adapter, please rename it to "beyondmedia" in your configuration.`, "oftmedia": `Bidder "oftmedia" is no longer available in Prebid Server. Please update your configuration.`, diff --git a/openrtb_ext/bidders.go b/openrtb_ext/bidders.go index 9f74a710937..211c5695ebf 100644 --- a/openrtb_ext/bidders.go +++ b/openrtb_ext/bidders.go @@ -257,7 +257,6 @@ const ( BidderUnicorn BidderName = "unicorn" BidderUnruly BidderName = "unruly" BidderValueImpression BidderName = "valueimpression" - BidderVerizonMedia BidderName = "verizonmedia" BidderVideoByte BidderName = "videobyte" BidderVideoHeroes BidderName = "videoheroes" BidderVidoomy BidderName = "vidoomy" @@ -266,6 +265,7 @@ const ( BidderVisx BidderName = "visx" BidderVrtcal BidderName = "vrtcal" BidderXeworks BidderName = "xeworks" + BidderYahooAdvertising BidderName = "yahooAdvertising" BidderYahooSSP BidderName = "yahoossp" BidderYeahmobi BidderName = "yeahmobi" BidderYieldlab BidderName = "yieldlab" @@ -449,7 +449,6 @@ func CoreBidderNames() []BidderName { BidderUnicorn, BidderUnruly, BidderValueImpression, - BidderVerizonMedia, BidderVideoByte, BidderVideoHeroes, BidderVidoomy, @@ -458,6 +457,7 @@ func CoreBidderNames() []BidderName { BidderVisx, BidderVrtcal, BidderXeworks, + BidderYahooAdvertising, BidderYahooSSP, BidderYeahmobi, BidderYieldlab, diff --git a/openrtb_ext/imp_verizonmedia.go b/openrtb_ext/imp_verizonmedia.go deleted file mode 100644 index 2ae8e5ea70a..00000000000 --- a/openrtb_ext/imp_verizonmedia.go +++ /dev/null @@ -1,7 +0,0 @@ -package openrtb_ext - -// ExtImpVerizonMedia defines the contract for bidrequest.imp[i].ext.prebid.bidder.verizonmedia -type ExtImpVerizonMedia struct { - Dcn string `json:"dcn"` - Pos string `json:"pos"` -} diff --git a/openrtb_ext/imp_yahooAdvertising.go b/openrtb_ext/imp_yahooAdvertising.go new file mode 100644 index 00000000000..e0e8614a0f9 --- /dev/null +++ b/openrtb_ext/imp_yahooAdvertising.go @@ -0,0 +1,7 @@ +package openrtb_ext + +// ExtImpYahooAdvertising defines the contract for bidrequest.imp[i].ext.prebid.bidder.yahooAdvertising +type ExtImpYahooAdvertising struct { + Dcn string `json:"dcn"` + Pos string `json:"pos"` +} diff --git a/static/bidder-info/verizonmedia.yaml b/static/bidder-info/yahooAdvertising.yaml similarity index 52% rename from static/bidder-info/verizonmedia.yaml rename to static/bidder-info/yahooAdvertising.yaml index 9be15b84091..3798adf7ca2 100644 --- a/static/bidder-info/verizonmedia.yaml +++ b/static/bidder-info/yahooAdvertising.yaml @@ -1,16 +1,18 @@ -disabled: true +endpoint: "https://s2shb.ssp.yahoo.com/admax/bid/partners/PBS" maintainer: - email: "dsp-supply-prebid@verizonmedia.com" + email: "hb-fe-tech@yahooinc.com" gvlVendorID: 25 capabilities: app: mediaTypes: - banner + - video site: mediaTypes: - banner + - video userSync: - # verizonmedia supports user syncing, but requires configuration by the host. contact this + # yahooAdvertising supports user syncing, but requires configuration by the host. contact this # bidder directly at the email address in this file to ask about enabling user sync. supports: - redirect \ No newline at end of file diff --git a/static/bidder-params/verizonmedia.json b/static/bidder-params/yahooAdvertising.json similarity index 75% rename from static/bidder-params/verizonmedia.json rename to static/bidder-params/yahooAdvertising.json index 96649f085bd..4778f0778c7 100644 --- a/static/bidder-params/verizonmedia.json +++ b/static/bidder-params/yahooAdvertising.json @@ -1,15 +1,17 @@ { "$schema": "http://json-schema.org/draft-04/schema#", - "title": "VerizonMedia Adapter Params", - "description": "A schema which validates params accepted by the VerizonMedia adapter", + "title": "YahooAdvertising Adapter Params", + "description": "A schema which validates params accepted by the YahooAdvertising adapter", "type": "object", "properties": { "dcn": { "type": "string", + "minLength": 1, "description": "Site ID provided by One Mobile" }, "pos": { "type": "string", + "minLength": 1, "description": "Placement ID" } },