From 915218ccafc27800eb37674a538d79ade09c2d82 Mon Sep 17 00:00:00 2001 From: Matt Kendall Date: Thu, 28 Sep 2017 15:15:07 -0400 Subject: [PATCH 1/2] Add some missing deprecations --- dev-docs/prebid-1.0-API.md | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/dev-docs/prebid-1.0-API.md b/dev-docs/prebid-1.0-API.md index 2f3cf7fe8d..9181ee9f64 100644 --- a/dev-docs/prebid-1.0-API.md +++ b/dev-docs/prebid-1.0-API.md @@ -17,6 +17,23 @@ This document describes the changes to the Publisher API for version 1.0. * TOC {:toc} +## Deprecations +The following functions/variables are removed as part of 1.0. + +- All `pbjs._*` varaibles will be depracated as part of 1.0. This includes the following + - `pbjs._winningBids` + - `pbjs._bidsReceived` + - `pbjs._bidsRequested` + - `pbjs._adUnitCodes` + - `pbjs._adsReceived` + - `pbjs.cbTimeout ` +- `pbjs.addCallback` & `pbjs.removeCallback` in favor of [onEvent API](http://prebid.org/dev-docs/publisher-api-reference.html#module_pbjs.onEvent). +- `pbjs.allBidsAvailable` +- `pbjs.buildMasterVideoTagFromAdserverTag` in favor of `pbjs.adServers.dfp.buildVideoUrl` +- `adUnit.sizeMapping` - see below for [details on sizeConfig]({{site.baseurl}}/dev-docs/prebid-1.0-API.html#size-mapping-changes) + +Other methods are removed as part of the `setConfig` API - see below `pbjs.setConfig` for details. + ## New API - `pbjs.setConfig` For 1.0, we're **deprecating** the following APIs in favor of a generic "options" param object passed to the [`pbjs.setConfig`]({{site.baseurl}}/dev-docs/publisher-api-reference.html#module_pbjs.setConfig) method: From 906f49d88ab2111622c2c8b68a2a2f44e4ff0bfa Mon Sep 17 00:00:00 2001 From: Matt Kendall Date: Thu, 28 Sep 2017 18:12:22 -0400 Subject: [PATCH 2/2] Added pbjs.timeoutBuffer --- dev-docs/prebid-1.0-API.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dev-docs/prebid-1.0-API.md b/dev-docs/prebid-1.0-API.md index 9181ee9f64..16ad22036d 100644 --- a/dev-docs/prebid-1.0-API.md +++ b/dev-docs/prebid-1.0-API.md @@ -26,7 +26,7 @@ The following functions/variables are removed as part of 1.0. - `pbjs._bidsRequested` - `pbjs._adUnitCodes` - `pbjs._adsReceived` - - `pbjs.cbTimeout ` + - `pbjs.cbTimeout` - `pbjs.addCallback` & `pbjs.removeCallback` in favor of [onEvent API](http://prebid.org/dev-docs/publisher-api-reference.html#module_pbjs.onEvent). - `pbjs.allBidsAvailable` - `pbjs.buildMasterVideoTagFromAdserverTag` in favor of `pbjs.adServers.dfp.buildVideoUrl` @@ -46,6 +46,7 @@ For 1.0, we're **deprecating** the following APIs in favor of a generic "options - `pbjs.enableSendAllBids` (* [2](#options-footnotes)) - `pbjs.setBidderSequence` - `pbjs.setS2SConfig` +- `pbjs.timeoutBuffer` Mapping will be straightforward with the name of the param being the same, except dropping the `set` prefix where appropriate.