Improve search #578
Merged
Improve search #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to add a wildcard in the search prefix-dev#378
|
Cool! |
ruben-arts
requested changes
Dec 19, 2023
There was a problem hiding this comment.
Thanks for your PR. There are still some things that need changing but I like the feature!
Seeing you're learning Rust, the ?(question mark operator) is something to read about. It can be pretty powerful but also confusing at first. If you have issue with the question mark not being accepted, checkout the miette::into_diagnostics We use this to create better reports from the errors.
If any of the remarks are unclear or you have general questions just ask!
Code cleanup & formatting
ruben-arts
reviewed
Dec 20, 2023
|
@ruben-arts I implemented all remarks, could you check if I missed anything? |
ruben-arts
approved these changes
Dec 26, 2023
ruben-arts
approved these changes
Dec 26, 2023
baszalmstra
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve search with more info about specific package and possibility to add a wildcard in the search
#378
Rattler:
conda/rattler#446
Specific package
Using wildcard
