Skip to content

fix: allow relinking on read-only files #1708

fix: allow relinking on read-only files

fix: allow relinking on read-only files #1708

Triggered via pull request December 1, 2024 09:12
Status Success
Total duration 16m 51s
Artifacts 7

rust.yml

on: pull_request
Matrix: build
Matrix: test
Post-process
4s
Post-process
Fit to window
Zoom out
Zoom in

Annotations

8 errors
test (ubuntu-latest): src/macos/link.rs#L264
[clippy] reported by reviewdog 🐶 error: call to `set_readonly` with argument `false` --> src/macos/link.rs:264:17 | 264 | perms.set_readonly(false); | ^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: on Unix platforms this results in the file being world writable = help: you can set the desired permissions using `PermissionsExt`. For more information, see https://doc.rust-lang.org/std/os/unix/fs/trait.PermissionsExt.html = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#permissions_set_readonly_false = note: `-D clippy::permissions-set-readonly-false` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::permissions_set_readonly_false)]` Raw Output: src/macos/link.rs:264:17:e:error: call to `set_readonly` with argument `false` --> src/macos/link.rs:264:17 | 264 | perms.set_readonly(false); | ^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: on Unix platforms this results in the file being world writable = help: you can set the desired permissions using `PermissionsExt`. For more information, see https://doc.rust-lang.org/std/os/unix/fs/trait.PermissionsExt.html = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#permissions_set_readonly_false = note: `-D clippy::permissions-set-readonly-false` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::permissions_set_readonly_false)]` __END__
test (ubuntu-latest): src/macos/link.rs#L268
[clippy] reported by reviewdog 🐶 error: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` --> src/macos/link.rs:268:13 | 268 | / match relink(&self.path, &changes) { 269 | | Err(e) => { 270 | | assert!(self.path.exists()); 271 | | tracing::warn!("Builtin relink failed {:?}, trying install_name_tool", e); ... | 274 | | Ok(_) => {} 275 | | } | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match = note: `-D clippy::single-match` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::single_match)]` help: try | 268 ~ if let Err(e) = relink(&self.path, &changes) { 269 + assert!(self.path.exists()); 270 + tracing::warn!("Builtin relink failed {:?}, trying install_name_tool", e); 271 + install_name_tool(&self.path, &changes, system_tools)?; 272 + } | Raw Output: src/macos/link.rs:268:13:e:error: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` --> src/macos/link.rs:268:13 | 268 | / match relink(&self.path, &changes) { 269 | | Err(e) => { 270 | | assert!(self.path.exists()); 271 | | tracing::warn!("Builtin relink failed {:?}, trying install_name_tool", e); ... | 274 | | Ok(_) => {} 275 | | } | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match = note: `-D clippy::single-match` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::single_match)]` help: try | 268 ~ if let Err(e) = relink(&self.path, &changes) { 269 + assert!(self.path.exists()); 270 + tracing::warn!("Builtin relink failed {:?}, trying install_name_tool", e); 271 + install_name_tool(&self.path, &changes, system_tools)?; 272 + } | __END__
test (ubuntu-latest): src/macos/link.rs#L264
[clippy] reported by reviewdog 🐶 error: call to `set_readonly` with argument `false` --> src/macos/link.rs:264:17 | 264 | perms.set_readonly(false); | ^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: on Unix platforms this results in the file being world writable = help: you can set the desired permissions using `PermissionsExt`. For more information, see https://doc.rust-lang.org/std/os/unix/fs/trait.PermissionsExt.html = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#permissions_set_readonly_false = note: `-D clippy::permissions-set-readonly-false` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::permissions_set_readonly_false)]` Raw Output: src/macos/link.rs:264:17:e:error: call to `set_readonly` with argument `false` --> src/macos/link.rs:264:17 | 264 | perms.set_readonly(false); | ^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: on Unix platforms this results in the file being world writable = help: you can set the desired permissions using `PermissionsExt`. For more information, see https://doc.rust-lang.org/std/os/unix/fs/trait.PermissionsExt.html = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#permissions_set_readonly_false = note: `-D clippy::permissions-set-readonly-false` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::permissions_set_readonly_false)]` __END__
test (ubuntu-latest): src/macos/link.rs#L268
[clippy] reported by reviewdog 🐶 error: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` --> src/macos/link.rs:268:13 | 268 | / match relink(&self.path, &changes) { 269 | | Err(e) => { 270 | | assert!(self.path.exists()); 271 | | tracing::warn!("Builtin relink failed {:?}, trying install_name_tool", e); ... | 274 | | Ok(_) => {} 275 | | } | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match = note: `-D clippy::single-match` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::single_match)]` help: try | 268 ~ if let Err(e) = relink(&self.path, &changes) { 269 + assert!(self.path.exists()); 270 + tracing::warn!("Builtin relink failed {:?}, trying install_name_tool", e); 271 + install_name_tool(&self.path, &changes, system_tools)?; 272 + } | Raw Output: src/macos/link.rs:268:13:e:error: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` --> src/macos/link.rs:268:13 | 268 | / match relink(&self.path, &changes) { 269 | | Err(e) => { 270 | | assert!(self.path.exists()); 271 | | tracing::warn!("Builtin relink failed {:?}, trying install_name_tool", e); ... | 274 | | Ok(_) => {} 275 | | } | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match = note: `-D clippy::single-match` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::single_match)]` help: try | 268 ~ if let Err(e) = relink(&self.path, &changes) { 269 + assert!(self.path.exists()); 270 + tracing::warn!("Builtin relink failed {:?}, trying install_name_tool", e); 271 + install_name_tool(&self.path, &changes, system_tools)?; 272 + } | __END__
test (macos-latest): src/macos/link.rs#L264
[clippy] reported by reviewdog 🐶 error: call to `set_readonly` with argument `false` --> src/macos/link.rs:264:17 | 264 | perms.set_readonly(false); | ^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: on Unix platforms this results in the file being world writable = help: you can set the desired permissions using `PermissionsExt`. For more information, see https://doc.rust-lang.org/std/os/unix/fs/trait.PermissionsExt.html = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#permissions_set_readonly_false = note: `-D clippy::permissions-set-readonly-false` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::permissions_set_readonly_false)]` Raw Output: src/macos/link.rs:264:17:e:error: call to `set_readonly` with argument `false` --> src/macos/link.rs:264:17 | 264 | perms.set_readonly(false); | ^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: on Unix platforms this results in the file being world writable = help: you can set the desired permissions using `PermissionsExt`. For more information, see https://doc.rust-lang.org/std/os/unix/fs/trait.PermissionsExt.html = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#permissions_set_readonly_false = note: `-D clippy::permissions-set-readonly-false` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::permissions_set_readonly_false)]` __END__
test (macos-latest): src/macos/link.rs#L268
[clippy] reported by reviewdog 🐶 error: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` --> src/macos/link.rs:268:13 | 268 | / match relink(&self.path, &changes) { 269 | | Err(e) => { 270 | | assert!(self.path.exists()); 271 | | tracing::warn!("Builtin relink failed {:?}, trying install_name_tool", e); ... | 274 | | Ok(_) => {} 275 | | } | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match = note: `-D clippy::single-match` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::single_match)]` help: try | 268 ~ if let Err(e) = relink(&self.path, &changes) { 269 + assert!(self.path.exists()); 270 + tracing::warn!("Builtin relink failed {:?}, trying install_name_tool", e); 271 + install_name_tool(&self.path, &changes, system_tools)?; 272 + } | Raw Output: src/macos/link.rs:268:13:e:error: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` --> src/macos/link.rs:268:13 | 268 | / match relink(&self.path, &changes) { 269 | | Err(e) => { 270 | | assert!(self.path.exists()); 271 | | tracing::warn!("Builtin relink failed {:?}, trying install_name_tool", e); ... | 274 | | Ok(_) => {} 275 | | } | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match = note: `-D clippy::single-match` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::single_match)]` help: try | 268 ~ if let Err(e) = relink(&self.path, &changes) { 269 + assert!(self.path.exists()); 270 + tracing::warn!("Builtin relink failed {:?}, trying install_name_tool", e); 271 + install_name_tool(&self.path, &changes, system_tools)?; 272 + } | __END__
test (macos-latest): src/macos/link.rs#L264
[clippy] reported by reviewdog 🐶 error: call to `set_readonly` with argument `false` --> src/macos/link.rs:264:17 | 264 | perms.set_readonly(false); | ^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: on Unix platforms this results in the file being world writable = help: you can set the desired permissions using `PermissionsExt`. For more information, see https://doc.rust-lang.org/std/os/unix/fs/trait.PermissionsExt.html = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#permissions_set_readonly_false = note: `-D clippy::permissions-set-readonly-false` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::permissions_set_readonly_false)]` Raw Output: src/macos/link.rs:264:17:e:error: call to `set_readonly` with argument `false` --> src/macos/link.rs:264:17 | 264 | perms.set_readonly(false); | ^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: on Unix platforms this results in the file being world writable = help: you can set the desired permissions using `PermissionsExt`. For more information, see https://doc.rust-lang.org/std/os/unix/fs/trait.PermissionsExt.html = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#permissions_set_readonly_false = note: `-D clippy::permissions-set-readonly-false` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::permissions_set_readonly_false)]` __END__
test (macos-latest): src/macos/link.rs#L268
[clippy] reported by reviewdog 🐶 error: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` --> src/macos/link.rs:268:13 | 268 | / match relink(&self.path, &changes) { 269 | | Err(e) => { 270 | | assert!(self.path.exists()); 271 | | tracing::warn!("Builtin relink failed {:?}, trying install_name_tool", e); ... | 274 | | Ok(_) => {} 275 | | } | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match = note: `-D clippy::single-match` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::single_match)]` help: try | 268 ~ if let Err(e) = relink(&self.path, &changes) { 269 + assert!(self.path.exists()); 270 + tracing::warn!("Builtin relink failed {:?}, trying install_name_tool", e); 271 + install_name_tool(&self.path, &changes, system_tools)?; 272 + } | Raw Output: src/macos/link.rs:268:13:e:error: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` --> src/macos/link.rs:268:13 | 268 | / match relink(&self.path, &changes) { 269 | | Err(e) => { 270 | | assert!(self.path.exists()); 271 | | tracing::warn!("Builtin relink failed {:?}, trying install_name_tool", e); ... | 274 | | Ok(_) => {} 275 | | } | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match = note: `-D clippy::single-match` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::single_match)]` help: try | 268 ~ if let Err(e) = relink(&self.path, &changes) { 269 + assert!(self.path.exists()); 270 + tracing::warn!("Builtin relink failed {:?}, trying install_name_tool", e); 271 + install_name_tool(&self.path, &changes, system_tools)?; 272 + } | __END__

Artifacts

Produced during runtime
Name Size
rattler-build-aarch64-apple-darwin.tar.gz
12.8 MB
rattler-build-aarch64-unknown-linux-musl.tar.gz
16.4 MB
rattler-build-powerpc64le-unknown-linux-gnu.tar.gz
17.2 MB
rattler-build-x86_64-apple-darwin.tar.gz
13.3 MB
rattler-build-x86_64-pc-windows-gnu.zip
19.3 MB
rattler-build-x86_64-pc-windows-msvc.zip
11.4 MB
rattler-build-x86_64-unknown-linux-musl.tar.gz
17.1 MB