Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 19 Support #16827

Open
mertsincan opened this issue Nov 22, 2024 · 14 comments
Open

Angular 19 Support #16827

mertsincan opened this issue Nov 22, 2024 · 14 comments
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@mertsincan
Copy link
Member

Details; #16783

@mertsincan mertsincan pinned this issue Nov 22, 2024
@mertsincan mertsincan added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Nov 22, 2024
@mertsincan mertsincan added this to the 18.0.0-rc.2 milestone Nov 22, 2024
@mertsincan mertsincan moved this to Review in PrimeNG v18 Nov 22, 2024
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 22, 2024
@mertsincan mertsincan removed the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 22, 2024
@AStoker
Copy link

AStoker commented Nov 22, 2024

If it helps, here's a list of files that needed to be updated in my testing. The Docs still have a lot of work though. AStoker@a1bad87

mertsincan added a commit that referenced this issue Nov 25, 2024
@github-project-automation github-project-automation bot moved this from Review to Done in PrimeNG v18 Nov 25, 2024
@mertsincan mertsincan reopened this Nov 25, 2024
@mertsincan mertsincan moved this from Done to In Progress in PrimeNG v18 Nov 25, 2024
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 25, 2024
@mertsincan mertsincan added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Pending Review Issue or pull request is being reviewed by Core Team Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 25, 2024
@NateRadebaugh
Copy link

Can this be back-ported to a 17.x release once this is ready?

@mertsincan
Copy link
Member Author

Today, we had a detailed meeting about Angular 19 and decided to support it with PrimeNG 19. We are very close to the PrimeNG 18.Final. After releasing it, we plan to release PrimeNG 19.rc.1 within 1 to 2 weeks. Thanks a lot for your understanding!

@mertsincan
Copy link
Member Author

Can this be back-ported to a 17.x release once this is ready?

Unfortunately, we do not plan to port it to version 17. Primeng versions will be released following the Angular versions. Otherwise, there will be many breakages in frameworks and libraries that are under such active development. I think this is the most logical thing.

@mertsincan mertsincan modified the milestones: 18.0.0-rc.2, 19.x Nov 25, 2024
@mertsincan mertsincan removed this from PrimeNG v18 Nov 25, 2024
@genopapashvili
Copy link

this issue is very important

@giusepperevoltech
Copy link

Not to put pressure on this, but I'm starting a new project with Angular 19 and I am not currently able to achieve it

@aberonni
Copy link
Contributor

aberonni commented Nov 26, 2024

The current strategy you are proposing means we won't be able to upgrade to angular v19 in projects that use primeng for at least several weeks (based on your estimation, which I believe to be optimistic). Even then, we will only be able to upgrade by also accepting the breaking changes which will be introduced in primeng 18/19 - which is extra effort for users of primeng. Ideally, you would give the users a choice on whether they deem it worth putting in this effort or not, instead, what I'm effectively hearing is "If you want to use angular 19, you must accept the breaking changes and update to primeng 18/19".

As a primeng user, I feel neglected by the strategy you are proposing. I understand that the proposed strategy is less effort for you and potentially helps you to push forward the v18 release, but I only see it as "the most logical thing" if you are fine with not prioritising the short to midterm impact this has on your users.

Ultimately, you folks are in charge and know what's best for the project. And I will continue using and supporting primeng whatever you decide. But I feel it is important you hear the thoughts and perspective of how your actions are affecting (at least one of) your users, and that this has the potential of turning some of your users against you.

EDIT: I'd also like to add the angular v19 RC has been out for weeks, and I am a bit surprised to see the primeng team decide to prioritise and plan for this only after the official release. Maybe reacting to new angular releases earlier is something to be taken into account for future angular releases. (Again, I say this well aware that the status quo is affected by the complications of the primeng v18 release, but I think this is still valid).

@igordanilovski
Copy link

So as I understand v17 & v18 (which still is in beta) will not have support for Angular 19? First release to support Angular 19 will be 19.x?

@David-Ben-Mesecke
Copy link

David-Ben-Mesecke commented Nov 29, 2024

@mertsincan I agree with all of what @aberonni said, however, as opposed to him, if I do not at least see a drastic attitude change from your team, I am switching back to free and well supported angular material, this is completely unacceptable for my workflow. When angular updates, I update, I can wait a maximum of a week to update to a new major version upgrade but not even an day longer. I am pretty sure many of your other paying customers feel the same. That said, this gives me a much needed kick in the butt to finally abstract my use of frontend UI components using facades. Yet @mertsincan please, pretty please, with sugar on top, please don't make me go back to angular material, right now, I have better things to do. Also, from what I can tell, the fix does not demand much of an efforts from your team, so please do it, and please do it as soon as possible.

@David-Ben-Mesecke
Copy link

David-Ben-Mesecke commented Nov 29, 2024

Today, we had a detailed meeting about Angular 19 and decided to support it with PrimeNG 19. We are very close to the PrimeNG 18.Final. After releasing it, we plan to release PrimeNG 19.rc.1 within 1 to 2 weeks. Thanks a lot for your understanding!

Are you a team of devs without a formal administration? If so that approach works great for dev to dev businesses like this one, for a while. Yet then, as you grow bigger and bigger, your administrative task grow disproportionally so you may hire some secretaries our outsource at least parts it to some bureau doing your bidding there and for a time, that may work too. Yet as you grow even bigger you need a non dev marketing manager , a technical manager who is a non participating software architect (CTO) and a dedicated professional CEO.

Because if your meeting had included professional management, including marketing, I am sure they would have told you your approach will cost you a lot of customers and it certainly won't boost customer satisfaction. Now I don't know the percentage of your customers who like me are using continuous integration in their software development process. my guess is very high.

Anyway, we who do, my guess is, most of us, can't work with 3rd party code whose vendor doesn't understand or for some other reason is unable to meet that requirement. For one, because many of us then won't be able to meet our customers requirements. Not be able to update causes a lot of problems, security related for instance. The latest security fixes can't be implemented, to mention a highly important one.

@yarikwest
Copy link

Come on, guys! Don't be too harsh on the maintainers. Please remember that this is a free, open-source project. If you're eager to see updates, you can fork the repo or submit a PR to help speed up the work for the maintainers. Alternatively, you can use Angular Material, which is updated alongside Angular. Oh, wait, I almost forgot—it lacks many of the cool components that are available in PrimeNG.

I don't believe PrimeNG is the only library in your projects that doesn't update immediately after each new Angular version. I, too, am waiting for the possibility to upgrade to Angular 19. I have at least 10 large enterprise projects that need upgrading, but I prefer to wait a month for a well-tested library rather than rushing into an update with potential bugs.

@zygarios
Copy link

I use Material in projects, and sometimes PrimeNG. I definitely wouldn’t be so harsh on the creators when it comes to a free tool—I’d just express my disappointment and wait. However, if I were indeed a paying customer (@David-Ben-Mesecke claims he uses the paid version), I’d probably be upset about such an approach to updates as well... But it’s not my place, so I politely wait and hope the creators will improve the process.

@NateRadebaugh
Copy link

From my understanding, there's 2 things at play:

  • Support Angular 19
  • Support new prime theming

The main desire from the prime team is that new prime theming is a breaking change and will only be supported starting in primeng 18+

The main desire from the community in this thread is to upgrade their current projects to angular 19 in-place without breaking changes.

Based on the conversation in #16783 it seems the only breaking change in angular 19 blocking primeng 17 from supporting angular 19 is the switching of default standalone from false to true. If the prime components that are not currently standalone were updated to explicitly mark as standalone: false, would that be enough to satisfy the angular 19 runtime issues in a primeng v17 release?

@David-Ben-Mesecke
Copy link

David-Ben-Mesecke commented Nov 30, 2024

I use Material in projects, and sometimes PrimeNG. I definitely wouldn’t be so harsh on the creators when it comes to a free tool—I’d just express my disappointment and wait. However, if I were indeed a paying customer (@David-Ben-Mesecke claims he uses the paid version), I’d probably be upset about such an approach to updates as well... But it’s not my place, so I politely wait and hope the creators will improve the process.

I totally agree, if I hadn't paid for it, I would have formulated my critique differently. On the other hand, they are a business, thriving from what I can tell, and my critique while maybe a bit on the harsher side, is well meant and constructive. I have a lifetime of experience in the business and I wrote it because I believe the critique, and suggestions for change may be valuable to them.

Like most businesses, I paid for it because I wanted to support what was a great product that seemed to have the ambition to become even greater. But for me, and I am sure that goes for most of their customers, its not about the money I paid for their product, it's about the time invested in implementing the product into ours, which now may turn out to have been a complete waste of a significant amount of time and effort, depending on how this goes. Now in my case, its not even as bad as it may be for many others, I have planned to add a facade to abstract the ui component library, in about 12 month or so. It's a lot of work to go ahead and replace it. That is why businesses pay for their components, to ensure they are being well maintained and to be able to get support if or when needed. That is of course the main reason for why I bother writing this, hoping my, certainly well meant, and I believe good advice for their business, will motivate them to get this done before I am forced to switch libraries, losing lots of money.

@yarikwest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests