Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialogs don't move to the corners of the view when moved quickly #2042

Open
hstevanoski opened this issue May 17, 2021 · 1 comment · Fixed by #3709 · May be fixed by #3715
Open

Dialogs don't move to the corners of the view when moved quickly #2042

hstevanoski opened this issue May 17, 2021 · 1 comment · Fixed by #3709 · May be fixed by #3715
Assignees
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@hstevanoski
Copy link

I'm submitting a ... (check one with "x")

[x] bug report
[ ] feature request
[ ] support request

Current behavior
If you try to move any dialog quickly into the edges of the page it does two things:

  1. It doesn't go all the way (see screenshot below)
  2. When you move it to the right while still having your left mouse key pressed, it quickly repositions itself to the edge of the page and gives you the feeling like when something is flickering

This is a screenshot of one of the scenarios where you try to slam it in the upper left corner of the page and it not going all the way (notice the gaps between the edges of the page and the dialog):

Also, on MacOS (all browsers; I'm not sure about other OSs), the dialog slides beneath the scrollbar of the browser (notice the scrollbar of the dialog appearing below the scrollbar of the browser):

Expected behavior
The movement of the dialog should not be dependent of the speed the dialog is being moved with.
Also, if possible, it would be nice if the max dragging position is calculated including the scrollbar.

  • React version:
    17.0.3

  • PrimeReact version:
    6.3.2.

  • Browser: all

@mcandu mcandu added the Type: Bug Issue contains a defect related to a specific component. label Dec 9, 2021
@mcandu mcandu added this to the Future milestone Dec 9, 2021
@mcandu mcandu self-assigned this Dec 9, 2021
@mcandu mcandu removed their assignment Jul 29, 2022
@melloware
Copy link
Member

It looks like this happens in all 3 Prime libs NG, React, Vue

melloware added a commit to melloware/primereact that referenced this issue Nov 26, 2022
@melloware melloware self-assigned this Nov 26, 2022
@melloware melloware modified the milestones: Future, 8.7.3 Nov 26, 2022
melloware added a commit that referenced this issue Nov 28, 2022
@melloware melloware reopened this Nov 28, 2022
@melloware melloware removed this from the 8.7.3 milestone Nov 28, 2022
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 28, 2022
melloware added a commit to melloware/primereact that referenced this issue Nov 28, 2022
@melloware melloware linked a pull request Nov 28, 2022 that will close this issue
@melloware melloware removed the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 29, 2022
@melloware melloware added this to the 8.7.3 milestone Nov 29, 2022
@mertsincan mertsincan modified the milestones: 8.7.3, 8.7.4 Dec 5, 2022
@mertsincan mertsincan modified the milestones: 8.7.4, 10.0.0 Jan 26, 2023
melloware added a commit to melloware/primereact that referenced this issue Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
4 participants