Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2042: Dialog better handling of draggable #3709

Merged
merged 1 commit into from
Nov 28, 2022
Merged

Fix #2042: Dialog better handling of draggable #3709

merged 1 commit into from
Nov 28, 2022

Conversation

melloware
Copy link
Member

@melloware melloware commented Nov 26, 2022 •
edited
Loading

Defect Fixes

Fix #2042: Dialog better handling of draggable

  • Wraps complex logic up in reusable hook
  • Handles mobile or desktop with touch or mouse events
  • Adds aria-grabbed to the handle
  • Fix these bug with redrawing the dialog when moving too fast as it calculates the complexities in dragStart instead of inside drag itself.

@melloware melloware added the Core Team Issue or pull request has been *opened* by a member of Core Team label Nov 26, 2022
@melloware melloware merged commit 6bac6b3 into primefaces:master Nov 28, 2022
@melloware melloware deleted the PR2042 branch November 28, 2022 20:52
melloware added a commit that referenced this pull request Nov 28, 2022
@melloware
Revert "Fix #2042: Dialog better handling of draggable (#3709)"
4b4dbfa 
This reverts commit 6bac6b3.
@melloware melloware mentioned this pull request Nov 28, 2022
Merged
melloware added a commit that referenced this pull request Nov 28, 2022
@melloware
Revert "Fix #2042: Dialog better handling of draggable (#3709)" (#3714)
80db560 
This reverts commit 6bac6b3.
@melloware melloware restored the PR2042 branch November 28, 2022 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Core Team Issue or pull request has been *opened* by a member of Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dialogs don't move to the corners of the view when moved quickly
1 participant
@melloware