Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datatable: Allow ignore of data-tag in CellEdit outside click #7439

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Datatable: Allow ignore of data-tag in CellEdit outside click #7439

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
98200e4
Allow ignore of data-tag in CellEdit outside click
gnawjaren Nov 20, 2024
301dc57
Fix style issue
gnawjaren Nov 20, 2024
8e271c3
Fix lint warnings
gnawjaren Nov 20, 2024
ef637b0
Fix lint warnings
gnawjaren Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions components/lib/datatable/BodyCell.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,19 @@ export const BodyCell = React.memo((props) => {
return getColumnProp('cellEditValidateOnClose');
};

const isIgnoredElement = (element) => {
const isCellEditor = (el) => el.getAttribute && el.getAttribute('data-pr-is-overlay');

return isCellEditor(element) || DomHandler.getParents(element).find((el) => isCellEditor(el));
};

const [bindDocumentClickListener, unbindDocumentClickListener] = useEventListener({
type: 'click',
listener: (e) => {
if (isIgnoredElement(e.target)) {
return;
}

setTimeout(() => {
if (!selfClick.current && isOutsideClicked(e.target)) {
// #2666 for overlay components and outside is clicked
Expand Down
Loading