Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox: border-radius missmatch #78

Open
joaomarcelofm opened this issue May 24, 2024 · 1 comment
Open

Checkbox: border-radius missmatch #78

joaomarcelofm opened this issue May 24, 2024 · 1 comment

Comments

@joaomarcelofm
Copy link

joaomarcelofm commented May 24, 2024

The border-radius for the checkbox component uses the global definition for it ($borderRadius). However, if I look at the theme presets on PrimeVue docs, the value differs when applied to the component.

The problem with this definition is that the checkbox becomes almost round for larger radius values. Still, most importantly, it behaves inconsistently based on what's in the document versus what's generated with the sass themes.

Example of field with the default radius value:
Screenshot 2024-05-24 at 14 39 11

Example of checkbox with the overwritten value:
Screenshot 2024-05-24 at 14 40 42

These specs aren't available on the Figma file either so it's hard to understand what's happening here.

Here's a sample stackblitz project to validate that. The difference can be seen in the below comparison as well:
Screenshot 2024-05-24 at 14 46 06

What's the best approach to solve this issue?
I wouldn't like to custom change the theme as it'd require us to manually update it on every PV or theme update.

@joaomarcelofm
Copy link
Author

@tugcekucukoglu do you have any feedback on this topic? I could open a PR if that's allowed. The main issue I see is that this property is not available as a token in the UI Kit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant