From 002f6378ce8556690dbc6321a758115e62899875 Mon Sep 17 00:00:00 2001 From: Emily Date: Tue, 2 Oct 2018 16:15:28 -0700 Subject: [PATCH 1/2] remove unecessary font props from link components --- src/LinkDark.js | 4 +--- src/LinkLight.js | 3 +-- src/LinkPromo.js | 3 +-- 3 files changed, 3 insertions(+), 7 deletions(-) diff --git a/src/LinkDark.js b/src/LinkDark.js index 9f9cdee88f..a2cbf2a6ac 100644 --- a/src/LinkDark.js +++ b/src/LinkDark.js @@ -1,4 +1,4 @@ -// Extends Link from primer/components to make color primitives available, as well as fontSize and space which should be added in primer/components. Ideally I'd use defaultProps here but because we use !important on utilities the theme colors won't override. We could probably add a function to handle this. +// Extends Link from primer/components to make color primitives available. Ideally I'd use defaultProps here but because we use !important on utilities the theme colors won't override. We could probably add a function to handle this. import {Link} from '@primer/components' import { @@ -13,8 +13,6 @@ const LinkDark = styled(Link)` &:hover { color: ${props => props.theme.colors.gray[8]}; } - ${fontSize} - ${fontWeight} ` export default LinkDark diff --git a/src/LinkLight.js b/src/LinkLight.js index 22a30f21cd..44ecd3eae3 100644 --- a/src/LinkLight.js +++ b/src/LinkLight.js @@ -1,4 +1,4 @@ -// Extends Link from primer/components to make color primitives available, as well as fontSize and space which should be added in primer/components. Ideally I'd use defaultProps here but because we use !important on utilities the theme colors won't override. We could probably add a function to handle this. +// Extends Link from primer/components to make color primitives available. Ideally I'd use defaultProps here but because we use !important on utilities the theme colors won't override. We could probably add a function to handle this. import {Link} from '@primer/components' import { @@ -9,7 +9,6 @@ import styled from 'react-emotion' const LinkLight = styled(Link)` color: ${props => props.theme.colors.blue[3]} !important; - ${fontSize} ` LinkLight.defaultProps = { diff --git a/src/LinkPromo.js b/src/LinkPromo.js index feffedff03..c0eb31c61e 100644 --- a/src/LinkPromo.js +++ b/src/LinkPromo.js @@ -1,4 +1,4 @@ -// Extends Link from primer/components to make color primitives available, as well as fontSize and space which should be added in primer/components. Ideally I'd use defaultProps here but because we use !important on utilities the theme colors won't override. We could probably add a function to handle this. +// Extends Link from primer/components to make color primitives available. Ideally I'd use defaultProps here but because we use !important on utilities the theme colors won't override. We could probably add a function to handle this. import {Link} from '@primer/components' import { @@ -9,7 +9,6 @@ import styled from 'react-emotion' const LinkPromo = styled(Link)` color: ${props => props.theme.colors.orange[3]} !important; - ${fontSize} ` export default LinkPromo From a9c61e3ca6fef9f8f2660650549b7a65c87e7d31 Mon Sep 17 00:00:00 2001 From: Emily Date: Tue, 2 Oct 2018 16:15:45 -0700 Subject: [PATCH 2/2] indent links properly so fontFamily gets applied correctly --- src/Hero.js | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/src/Hero.js b/src/Hero.js index ca489bb287..38b6fef7de 100644 --- a/src/Hero.js +++ b/src/Hero.js @@ -16,18 +16,18 @@ const Hero = props => ( Primer Resources, tooling, and design guidelines for building interfaces with GitHub’s design system - - Style guide - ・ - - Community - ・ - - Open-source - + + Style guide + ・ + + Community + ・ + + Open-source +