From 626fa754505888b3ebe4b13ddae2596afb8e239b Mon Sep 17 00:00:00 2001 From: langermank Date: Mon, 26 Sep 2022 09:52:30 -0700 Subject: [PATCH 1/3] remove placeholder for scrollbar --- src/overlay/overlay.scss | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/overlay/overlay.scss b/src/overlay/overlay.scss index 702ba1af2b..6655b3571f 100644 --- a/src/overlay/overlay.scss +++ b/src/overlay/overlay.scss @@ -162,7 +162,7 @@ $primer-borderRadius-large: 0.75rem; // stylelint-disable-next-line primer/box-shadow box-shadow: inset 0 #{-$border-width} var(--color-border-default); - + .Overlay-body { + +.Overlay-body { padding-top: $spacer-3; } } @@ -224,7 +224,6 @@ $primer-borderRadius-large: 0.75rem; padding-top: 0; overflow-y: auto; scrollbar-width: thin; - scrollbar-gutter: stable; font-size: $body-font-size; flex-grow: 1; @@ -345,7 +344,7 @@ $primer-borderRadius-large: 0.75rem; align-items: center; justify-content: left; - > .Overlay#{$responsiveVariant} { + >.Overlay#{$responsiveVariant} { height: 100vh; max-height: unset; border-radius: $primer-borderRadius-large; @@ -362,7 +361,7 @@ $primer-borderRadius-large: 0.75rem; align-items: center; justify-content: right; - > .Overlay#{$responsiveVariant} { + >.Overlay#{$responsiveVariant} { height: 100vh; max-height: unset; border-radius: $primer-borderRadius-large; @@ -379,7 +378,7 @@ $primer-borderRadius-large: 0.75rem; align-items: end; justify-content: center; - > .Overlay#{$responsiveVariant} { + >.Overlay#{$responsiveVariant} { width: 100vw; height: auto; max-height: calc(100vh - 2rem); @@ -397,7 +396,7 @@ $primer-borderRadius-large: 0.75rem; align-items: start; justify-content: center; - > .Overlay#{$responsiveVariant} { + >.Overlay#{$responsiveVariant} { border-radius: $primer-borderRadius-large; border-top-left-radius: 0; border-top-right-radius: 0; From 6b2bd15539a3333b661ee7b6fa1175d9df5033db Mon Sep 17 00:00:00 2001 From: Katie Langerman Date: Mon, 26 Sep 2022 09:54:48 -0700 Subject: [PATCH 2/3] Create cool-ligers-yell.md --- .changeset/cool-ligers-yell.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/cool-ligers-yell.md diff --git a/.changeset/cool-ligers-yell.md b/.changeset/cool-ligers-yell.md new file mode 100644 index 0000000000..6e0b68ea81 --- /dev/null +++ b/.changeset/cool-ligers-yell.md @@ -0,0 +1,5 @@ +--- +"@primer/css": patch +--- + +Remove scrollbar CSS property from Overlay From 6fb94b36a0878c9d9004024726faa70fbed30033 Mon Sep 17 00:00:00 2001 From: langermank Date: Mon, 26 Sep 2022 09:55:48 -0700 Subject: [PATCH 3/3] format issues --- src/overlay/overlay.scss | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/overlay/overlay.scss b/src/overlay/overlay.scss index 6655b3571f..827d5113b2 100644 --- a/src/overlay/overlay.scss +++ b/src/overlay/overlay.scss @@ -162,7 +162,7 @@ $primer-borderRadius-large: 0.75rem; // stylelint-disable-next-line primer/box-shadow box-shadow: inset 0 #{-$border-width} var(--color-border-default); - +.Overlay-body { + + .Overlay-body { padding-top: $spacer-3; } } @@ -344,7 +344,7 @@ $primer-borderRadius-large: 0.75rem; align-items: center; justify-content: left; - >.Overlay#{$responsiveVariant} { + > .Overlay#{$responsiveVariant} { height: 100vh; max-height: unset; border-radius: $primer-borderRadius-large; @@ -361,7 +361,7 @@ $primer-borderRadius-large: 0.75rem; align-items: center; justify-content: right; - >.Overlay#{$responsiveVariant} { + > .Overlay#{$responsiveVariant} { height: 100vh; max-height: unset; border-radius: $primer-borderRadius-large; @@ -378,7 +378,7 @@ $primer-borderRadius-large: 0.75rem; align-items: end; justify-content: center; - >.Overlay#{$responsiveVariant} { + > .Overlay#{$responsiveVariant} { width: 100vw; height: auto; max-height: calc(100vh - 2rem); @@ -396,7 +396,7 @@ $primer-borderRadius-large: 0.75rem; align-items: start; justify-content: center; - >.Overlay#{$responsiveVariant} { + > .Overlay#{$responsiveVariant} { border-radius: $primer-borderRadius-large; border-top-left-radius: 0; border-top-right-radius: 0;